Re: [PR] Add comments to ClickBench queries about setting binary_as_string [datafusion]

2025-07-08 Thread via GitHub
comphead merged PR #16605: URL: https://github.com/apache/datafusion/pull/16605 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@dataf

Re: [PR] Add comments to ClickBench queries about setting binary_as_string [datafusion]

2025-07-08 Thread via GitHub
alamb commented on code in PR #16605: URL: https://github.com/apache/datafusion/pull/16605#discussion_r2192567377 ## benchmarks/queries/clickbench/queries/q0.sql: ## @@ -1 +1,3 @@ +-- Must set for ClickBench hits_partitioned dataset. See https://github.com/apache/datafusion/iss

Re: [PR] Add comments to ClickBench queries about setting binary_as_string [datafusion]

2025-07-07 Thread via GitHub
comphead commented on code in PR #16605: URL: https://github.com/apache/datafusion/pull/16605#discussion_r2191250802 ## benchmarks/queries/clickbench/queries/q0.sql: ## @@ -1 +1,3 @@ +-- Must set for ClickBench hits_partitioned dataset. See https://github.com/apache/datafusion/

Re: [PR] Add comments to ClickBench queries about setting binary_as_string [datafusion]

2025-07-07 Thread via GitHub
comphead commented on code in PR #16605: URL: https://github.com/apache/datafusion/pull/16605#discussion_r2191249463 ## benchmarks/queries/clickbench/queries/q0.sql: ## @@ -1 +1,3 @@ +-- Must set for ClickBench hits_partitioned dataset. See https://github.com/apache/datafusion/

Re: [PR] Add comments to ClickBench queries about setting binary_as_string [datafusion]

2025-07-03 Thread via GitHub
alamb commented on PR #16605: URL: https://github.com/apache/datafusion/pull/16605#issuecomment-3033684735 @Dandandan can i trouble you for a review of this PR (it makes no code changes, just comments0 -- This is an automated message from the Apache Git Service. To respond to the message

[PR] Add comments to ClickBench queries about setting binary_as_string [datafusion]

2025-06-28 Thread via GitHub
alamb opened a new pull request, #16605: URL: https://github.com/apache/datafusion/pull/16605 ## Which issue does this PR close? - Closes https://github.com/apache/datafusion/issues/16591 - Closes https://github.com/apache/datafusion/pull/16599 ## Rationale for this c