alamb commented on PR #11417:
URL: https://github.com/apache/datafusion/pull/11417#issuecomment-2231886271
Thanks again @joroKr21 and @lewiszlw
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
alamb merged PR #11417:
URL: https://github.com/apache/datafusion/pull/11417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #11417:
URL: https://github.com/apache/datafusion/pull/11417#issuecomment-2231886145
> I got this error before, running `cargo update` fixed it.
🤔 looks like we probably need to increase the minimum version of chrono
required to one that has `MappedLocalTime`
lewiszlw commented on PR #11417:
URL: https://github.com/apache/datafusion/pull/11417#issuecomment-2230141932
I got this error before, running `cargo update` fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
joroKr21 commented on PR #11417:
URL: https://github.com/apache/datafusion/pull/11417#issuecomment-2230131517
@alamb do you get this issue locally on `main`?
```
error[E0432]: unresolved import `chrono::MappedLocalTime`
--> datafusion/functions/src/datetime/to_local_time.rs:34:24
lewiszlw commented on code in PR #11417:
URL: https://github.com/apache/datafusion/pull/11417#discussion_r1677505817
##
datafusion-examples/examples/composed_extension_codec.rs:
##
@@ -239,53 +240,52 @@ struct ComposedPhysicalExtensionCodec {
codecs: Vec>,
}
+impl Compos
lewiszlw commented on code in PR #11417:
URL: https://github.com/apache/datafusion/pull/11417#discussion_r1677491458
##
datafusion/proto/src/physical_plan/mod.rs:
##
@@ -2018,6 +2021,16 @@ pub trait PhysicalExtensionCodec: Debug + Send + Sync {
fn try_encode_udf(&self, _nod
alamb commented on PR #11417:
URL: https://github.com/apache/datafusion/pull/11417#issuecomment-2227111319
Thanks for the reviews @thinkharderdev and @avantgardnerio -- @joroKr21
it appears this branch has conflicts that need to be resolved. Once those are
sorted out I think we can merge
alamb commented on code in PR #11417:
URL: https://github.com/apache/datafusion/pull/11417#discussion_r1676357997
##
datafusion-examples/examples/composed_extension_codec.rs:
##
@@ -239,53 +240,52 @@ struct ComposedPhysicalExtensionCodec {
codecs: Vec>,
}
+impl ComposedP
joroKr21 opened a new pull request, #11417:
URL: https://github.com/apache/datafusion/pull/11417
## Which issue does this PR close?
Closes #.
## Rationale for this change
## What changes are included in this PR?
## Are these changes tested?
10 matches
Mail list logo
