iffyio merged PR #1657:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
MartinSahlen commented on code in PR #1657:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1657#discussion_r1917906505
##
tests/sqlparser_bigquery.rs:
##
@@ -2244,3 +2244,15 @@ fn test_any_type() {
fn test_any_type_dont_break_custom_type() {
bigquery_and_gene
MartinSahlen commented on code in PR #1657:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1657#discussion_r1917904556
##
src/parser/mod.rs:
##
@@ -7341,6 +7341,10 @@ impl<'a> Parser<'a> {
pub fn parse_options(&mut self, keyword: Keyword) ->
Result, ParserErr
MartinSahlen commented on code in PR #1657:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1657#discussion_r1917893541
##
src/parser/mod.rs:
##
@@ -7341,6 +7341,10 @@ impl<'a> Parser<'a> {
pub fn parse_options(&mut self, keyword: Keyword) ->
Result, ParserErr
MartinSahlen commented on code in PR #1657:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1657#discussion_r1917882700
##
src/parser/mod.rs:
##
@@ -7341,6 +7341,10 @@ impl<'a> Parser<'a> {
pub fn parse_options(&mut self, keyword: Keyword) ->
Result, ParserErr
MartinSahlen commented on code in PR #1657:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1657#discussion_r1917876805
##
src/parser/mod.rs:
##
@@ -7341,6 +7341,10 @@ impl<'a> Parser<'a> {
pub fn parse_options(&mut self, keyword: Keyword) ->
Result, ParserErr
iffyio commented on code in PR #1657:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1657#discussion_r1917060943
##
tests/sqlparser_bigquery.rs:
##
@@ -2244,3 +2244,15 @@ fn test_any_type() {
fn test_any_type_dont_break_custom_type() {
bigquery_and_generic().
MartinSahlen opened a new pull request, #1657:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1657
In BigQuery, it's possible to have statements like these (added tests for
them):
```sql
CREATE TABLE foo (x INT64) OPTIONS()
```
```sql
CREATE TABLE db.schem
