Re: [PR] Chore: Improve array contains test coverage [datafusion-comet]

2025-07-31 Thread via GitHub
andygrove merged PR #2030: URL: https://github.com/apache/datafusion-comet/pull/2030 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

Re: [PR] Chore: Improve array contains test coverage [datafusion-comet]

2025-07-31 Thread via GitHub
kazantsev-maksim commented on PR #2030: URL: https://github.com/apache/datafusion-comet/pull/2030#issuecomment-3140349961 @comphead @andygrove thanks for the feedback! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] Chore: Improve array contains test coverage [datafusion-comet]

2025-07-28 Thread via GitHub
andygrove commented on code in PR #2030: URL: https://github.com/apache/datafusion-comet/pull/2030#discussion_r2237958273 ## spark/src/test/scala/org/apache/comet/CometArrayExpressionSuite.scala: ## @@ -218,16 +218,111 @@ class CometArrayExpressionSuite extends CometTestBase wi

Re: [PR] Chore: Improve array contains test coverage [datafusion-comet]

2025-07-28 Thread via GitHub
andygrove commented on code in PR #2030: URL: https://github.com/apache/datafusion-comet/pull/2030#discussion_r2237927682 ## spark/src/main/scala/org/apache/comet/serde/arrays.scala: ## @@ -136,7 +136,7 @@ object CometArrayAppend extends CometExpressionSerde with IncompatExpr {

Re: [PR] Chore: Improve array contains test coverage [datafusion-comet]

2025-07-22 Thread via GitHub
comphead commented on code in PR #2030: URL: https://github.com/apache/datafusion-comet/pull/2030#discussion_r2223402109 ## spark/src/main/scala/org/apache/comet/serde/arrays.scala: ## @@ -136,7 +136,7 @@ object CometArrayAppend extends CometExpressionSerde with IncompatExpr {

Re: [PR] Chore: Improve array contains test coverage [datafusion-comet]

2025-07-20 Thread via GitHub
kazantsev-maksim commented on code in PR #2030: URL: https://github.com/apache/datafusion-comet/pull/2030#discussion_r2217759307 ## spark/src/test/scala/org/apache/comet/CometArrayExpressionSuite.scala: ## @@ -218,7 +218,7 @@ class CometArrayExpressionSuite extends CometTestBase

Re: [PR] Chore: Improve array contains test coverage [datafusion-comet]

2025-07-20 Thread via GitHub
kazantsev-maksim commented on code in PR #2030: URL: https://github.com/apache/datafusion-comet/pull/2030#discussion_r2217758957 ## spark/src/test/scala/org/apache/comet/CometArrayExpressionSuite.scala: ## @@ -232,6 +232,78 @@ class CometArrayExpressionSuite extends CometTestBas

Re: [PR] Chore: Improve array contains test coverage [datafusion-comet]

2025-07-19 Thread via GitHub
codecov-commenter commented on PR #2030: URL: https://github.com/apache/datafusion-comet/pull/2030#issuecomment-3092466454 ## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/2030?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca

Re: [PR] Chore: Improve array contains test coverage [datafusion-comet]

2025-07-19 Thread via GitHub
comphead commented on PR #2030: URL: https://github.com/apache/datafusion-comet/pull/2030#issuecomment-3092455358 related to #1929 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Chore: Improve array contains test coverage [datafusion-comet]

2025-07-19 Thread via GitHub
comphead commented on code in PR #2030: URL: https://github.com/apache/datafusion-comet/pull/2030#discussion_r2217374605 ## spark/src/test/scala/org/apache/comet/CometArrayExpressionSuite.scala: ## @@ -232,6 +232,78 @@ class CometArrayExpressionSuite extends CometTestBase with

Re: [PR] Chore: Improve array contains test coverage [datafusion-comet]

2025-07-19 Thread via GitHub
comphead commented on code in PR #2030: URL: https://github.com/apache/datafusion-comet/pull/2030#discussion_r2217374144 ## spark/src/test/scala/org/apache/comet/CometArrayExpressionSuite.scala: ## @@ -218,7 +218,7 @@ class CometArrayExpressionSuite extends CometTestBase with A

[PR] Chore: Improve array contains test coverage [datafusion-comet]

2025-07-15 Thread via GitHub
kazantsev-maksim opened a new pull request, #2030: URL: https://github.com/apache/datafusion-comet/pull/2030 ## Which issue does this PR close? Part of: https://github.com/apache/datafusion-comet/issues/1902 ## Rationale for this change Part of: https://github.com/apache/