Re: [PR] Feat/use uv python management [datafusion-python]

2025-01-16 Thread via GitHub
kylebarron commented on code in PR #994: URL: https://github.com/apache/datafusion-python/pull/994#discussion_r1918910519 ## README.md: ## @@ -164,61 +170,69 @@ You can verify the installation by running: ## How to develop Review Comment: Just a personal nit that I usuall

Re: [PR] Feat/use uv python management [datafusion-python]

2025-01-14 Thread via GitHub
timsaucer commented on code in PR #994: URL: https://github.com/apache/datafusion-python/pull/994#discussion_r1915787482 ## .github/workflows/build.yml: ## @@ -35,8 +35,6 @@ jobs: - name: Install dependencies uses: astral-sh/setup-uv@v5 -with: -

Re: [PR] Feat/use uv python management [datafusion-python]

2025-01-14 Thread via GitHub
timsaucer commented on PR #994: URL: https://github.com/apache/datafusion-python/pull/994#issuecomment-2591078566 @kylebarron ready for review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Feat/use uv python management [datafusion-python]

2025-01-14 Thread via GitHub
timsaucer commented on PR #994: URL: https://github.com/apache/datafusion-python/pull/994#issuecomment-2590252479 Remaining things to do: - [ ] Try enabling the cache - [ ] Update instructions for local docs building - [ ] Update readme - [ ] Update online docs -- This is

Re: [PR] Feat/use uv python management [datafusion-python]

2025-01-14 Thread via GitHub
timsaucer commented on code in PR #994: URL: https://github.com/apache/datafusion-python/pull/994#discussion_r1915049658 ## .github/workflows/build.yml: ## @@ -46,7 +46,13 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - - uses: dtolnay/

Re: [PR] Feat/use uv python management [datafusion-python]

2025-01-13 Thread via GitHub
kylebarron commented on code in PR #994: URL: https://github.com/apache/datafusion-python/pull/994#discussion_r1913845387 ## .github/workflows/build.yml: ## @@ -46,7 +46,13 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - - uses: dtolnay

Re: [PR] Feat/use uv python management [datafusion-python]

2025-01-13 Thread via GitHub
timsaucer commented on code in PR #994: URL: https://github.com/apache/datafusion-python/pull/994#discussion_r1913841497 ## .github/workflows/docs.yaml: ## @@ -66,6 +66,7 @@ jobs: run: | set -x cd docs + uv pip install -r requirements.txt

Re: [PR] Feat/use uv python management [datafusion-python]

2025-01-13 Thread via GitHub
timsaucer commented on code in PR #994: URL: https://github.com/apache/datafusion-python/pull/994#discussion_r1913839249 ## .github/workflows/build.yml: ## @@ -46,7 +46,13 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - - uses: dtolnay/

Re: [PR] Feat/use uv python management [datafusion-python]

2025-01-13 Thread via GitHub
timsaucer commented on code in PR #994: URL: https://github.com/apache/datafusion-python/pull/994#discussion_r1913839706 ## .github/workflows/docs.yaml: ## @@ -60,11 +60,15 @@ jobs: - name: Install dependencies and build uses: astral-sh/setup-uv@v5 + - nam

Re: [PR] Feat/use uv python management [datafusion-python]

2025-01-13 Thread via GitHub
kylebarron commented on code in PR #994: URL: https://github.com/apache/datafusion-python/pull/994#discussion_r1913832418 ## .github/workflows/docs.yaml: ## @@ -60,11 +60,15 @@ jobs: - name: Install dependencies and build uses: astral-sh/setup-uv@v5 + - na

Re: [PR] Feat/use uv python management [datafusion-python]

2025-01-13 Thread via GitHub
kylebarron commented on code in PR #994: URL: https://github.com/apache/datafusion-python/pull/994#discussion_r1913829064 ## .github/workflows/build.yml: ## @@ -46,7 +46,13 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - - uses: dtolnay

Re: [PR] Feat/use uv python management [datafusion-python]

2025-01-13 Thread via GitHub
kylebarron commented on code in PR #994: URL: https://github.com/apache/datafusion-python/pull/994#discussion_r1913828054 ## .github/workflows/build.yml: ## @@ -35,8 +35,6 @@ jobs: - name: Install dependencies uses: astral-sh/setup-uv@v5 -with: -

Re: [PR] Feat/use uv python management [datafusion-python]

2025-01-13 Thread via GitHub
kylebarron commented on code in PR #994: URL: https://github.com/apache/datafusion-python/pull/994#discussion_r1913827666 ## .github/workflows/docs.yaml: ## @@ -66,6 +66,7 @@ jobs: run: | set -x cd docs + uv pip install -r requirements.txt

Re: [PR] Feat/use uv python management [datafusion-python]

2025-01-13 Thread via GitHub
kylebarron commented on code in PR #994: URL: https://github.com/apache/datafusion-python/pull/994#discussion_r1913413498 ## .github/workflows/build.yml: ## @@ -31,11 +31,13 @@ jobs: - name: Install Python uses: actions/setup-python@v5 with: - p

[PR] Feat/use uv python management [datafusion-python]

2025-01-12 Thread via GitHub
timsaucer opened a new pull request, #994: URL: https://github.com/apache/datafusion-python/pull/994 # Which issue does this PR close? Closes #977 # Rationale for this change As described in the issue, there is a confusing mix of pip and conda for dependency management.