alamb commented on PR #10573:
URL: https://github.com/apache/datafusion/pull/10573#issuecomment-2131235504
> This shouldn't have passed checks.
>
> ```
> + cargo fmt --all -- --check
> `cargo metadata` exited with an error: error: failed to load manifest for
workspace member
Omega359 commented on PR #10573:
URL: https://github.com/apache/datafusion/pull/10573#issuecomment-2129537623
This shouldn't have passed checks.
```
+ cargo fmt --all -- --check
`cargo metadata` exited with an error: error: failed to load manifest for
workspace member
goldmedal commented on PR #10573:
URL: https://github.com/apache/datafusion/pull/10573#issuecomment-2125974338
Thanks again @alamb @backkem @phillipleblanc @lewiszlw @comphead :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
alamb merged PR #10573:
URL: https://github.com/apache/datafusion/pull/10573
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
goldmedal commented on code in PR #10573:
URL: https://github.com/apache/datafusion/pull/10573#discussion_r1609871256
##
datafusion/sql/src/unparser/dialect.rs:
##
@@ -15,41 +15,54 @@
// specific language governing permissions and limitations
// under the License.
-///
backkem commented on code in PR #10573:
URL: https://github.com/apache/datafusion/pull/10573#discussion_r1609866123
##
datafusion/sql/src/unparser/dialect.rs:
##
@@ -15,41 +15,54 @@
// specific language governing permissions and limitations
// under the License.
-///
goldmedal commented on code in PR #10573:
URL: https://github.com/apache/datafusion/pull/10573#discussion_r1609859327
##
datafusion/sql/src/unparser/dialect.rs:
##
@@ -15,41 +15,54 @@
// specific language governing permissions and limitations
// under the License.
-///
backkem commented on code in PR #10573:
URL: https://github.com/apache/datafusion/pull/10573#discussion_r1609843395
##
datafusion/sql/src/unparser/dialect.rs:
##
@@ -15,41 +15,54 @@
// specific language governing permissions and limitations
// under the License.
-///
goldmedal commented on code in PR #10573:
URL: https://github.com/apache/datafusion/pull/10573#discussion_r1609802546
##
datafusion/sql/src/unparser/dialect.rs:
##
@@ -15,19 +15,33 @@
// specific language governing permissions and limitations
// under the License.
-///
goldmedal commented on code in PR #10573:
URL: https://github.com/apache/datafusion/pull/10573#discussion_r1609665909
##
datafusion/sql/src/unparser/dialect.rs:
##
@@ -15,19 +15,33 @@
// specific language governing permissions and limitations
// under the License.
-///
goldmedal commented on code in PR #10573:
URL: https://github.com/apache/datafusion/pull/10573#discussion_r1609802546
##
datafusion/sql/src/unparser/dialect.rs:
##
@@ -15,19 +15,33 @@
// specific language governing permissions and limitations
// under the License.
-///
goldmedal commented on code in PR #10573:
URL: https://github.com/apache/datafusion/pull/10573#discussion_r1609665909
##
datafusion/sql/src/unparser/dialect.rs:
##
@@ -15,19 +15,33 @@
// specific language governing permissions and limitations
// under the License.
-///
alamb commented on code in PR #10573:
URL: https://github.com/apache/datafusion/pull/10573#discussion_r1609656048
##
datafusion/sql/src/unparser/dialect.rs:
##
@@ -15,19 +15,33 @@
// specific language governing permissions and limitations
// under the License.
-/// Dialect
backkem commented on code in PR #10573:
URL: https://github.com/apache/datafusion/pull/10573#discussion_r1609558483
##
datafusion/sql/src/unparser/dialect.rs:
##
@@ -15,19 +15,33 @@
// specific language governing permissions and limitations
// under the License.
-///
backkem commented on code in PR #10573:
URL: https://github.com/apache/datafusion/pull/10573#discussion_r1609558483
##
datafusion/sql/src/unparser/dialect.rs:
##
@@ -15,19 +15,33 @@
// specific language governing permissions and limitations
// under the License.
-///
lewiszlw commented on code in PR #10573:
URL: https://github.com/apache/datafusion/pull/10573#discussion_r1609550161
##
datafusion/sql/src/unparser/dialect.rs:
##
@@ -15,19 +15,33 @@
// specific language governing permissions and limitations
// under the License.
-///
goldmedal commented on code in PR #10573:
URL: https://github.com/apache/datafusion/pull/10573#discussion_r1609280746
##
datafusion/sql/src/unparser/dialect.rs:
##
@@ -15,19 +15,33 @@
// specific language governing permissions and limitations
// under the License.
-///
phillipleblanc commented on code in PR #10573:
URL: https://github.com/apache/datafusion/pull/10573#discussion_r1609277646
##
datafusion/sql/src/unparser/dialect.rs:
##
@@ -15,19 +15,33 @@
// specific language governing permissions and limitations
// under the License.
-///
goldmedal commented on PR #10573:
URL: https://github.com/apache/datafusion/pull/10573#issuecomment-2123883816
> Thank you @goldmedal -- I think this looks really nice
>
> Thank you for the reviews @comphead
>
> I left some suggestions for improvement but I think they could be
goldmedal commented on code in PR #10573:
URL: https://github.com/apache/datafusion/pull/10573#discussion_r1609270235
##
datafusion/sql/src/unparser/dialect.rs:
##
@@ -15,19 +15,30 @@
// specific language governing permissions and limitations
// under the License.
+use
alamb commented on code in PR #10573:
URL: https://github.com/apache/datafusion/pull/10573#discussion_r1608928216
##
datafusion-examples/examples/plan_to_sql.rs:
##
@@ -52,7 +52,7 @@ fn simple_expr_to_sql_demo() -> Result<()> {
let expr =
goldmedal commented on PR #10573:
URL: https://github.com/apache/datafusion/pull/10573#issuecomment-2122464482
> Thanks @goldmedal I'm thinking how this will work with whitespaces columns
like
>
> ```
> select 1 as "a a";
> ```
Thanks @comphead :)
I'm not sure what
goldmedal commented on code in PR #10573:
URL: https://github.com/apache/datafusion/pull/10573#discussion_r1608186725
##
datafusion/sql/src/unparser/expr.rs:
##
@@ -504,6 +508,14 @@ impl Unparser<'_> {
.collect::>>()
}
+pub(super) fn
goldmedal commented on code in PR #10573:
URL: https://github.com/apache/datafusion/pull/10573#discussion_r1608186038
##
datafusion/sql/Cargo.toml:
##
@@ -47,6 +47,7 @@ arrow-schema = { workspace = true }
datafusion-common = { workspace = true, default-features = true }
comphead commented on code in PR #10573:
URL: https://github.com/apache/datafusion/pull/10573#discussion_r1607067858
##
datafusion/sql/src/unparser/expr.rs:
##
@@ -504,6 +508,14 @@ impl Unparser<'_> {
.collect::>>()
}
+pub(super) fn
comphead commented on code in PR #10573:
URL: https://github.com/apache/datafusion/pull/10573#discussion_r1607055206
##
datafusion/sql/Cargo.toml:
##
@@ -47,6 +47,7 @@ arrow-schema = { workspace = true }
datafusion-common = { workspace = true, default-features = true }
goldmedal opened a new pull request, #10573:
URL: https://github.com/apache/datafusion/pull/10573
## Which issue does this PR close?
Closes #10557
## Rationale for this change
## What changes are included in this PR?
Only implement the default dialect in this PR.
27 matches
Mail list logo
