comphead commented on PR #15029:
URL: https://github.com/apache/datafusion/pull/15029#issuecomment-2704211943
Thanks again @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
comphead merged PR #15029:
URL: https://github.com/apache/datafusion/pull/15029
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
comphead commented on code in PR #15029:
URL: https://github.com/apache/datafusion/pull/15029#discussion_r1982674514
##
datafusion/datasource/src/memory.rs:
##
@@ -425,25 +425,20 @@ impl DataSource for MemorySourceConfig {
}
}
DisplayFo
comphead commented on PR #15029:
URL: https://github.com/apache/datafusion/pull/15029#issuecomment-2702782556
Btw I like this simple approach to calc batch sizes, we can also reuse it in
https://github.com/apache/datafusion/issues/14510 perhaps to sum up all
incoming or outcoming batches.
comphead commented on code in PR #15029:
URL: https://github.com/apache/datafusion/pull/15029#discussion_r1982674514
##
datafusion/datasource/src/memory.rs:
##
@@ -425,25 +425,20 @@ impl DataSource for MemorySourceConfig {
}
}
DisplayFo
alamb commented on code in PR #15029:
URL: https://github.com/apache/datafusion/pull/15029#discussion_r1982398221
##
datafusion/datasource/src/memory.rs:
##
@@ -425,25 +425,20 @@ impl DataSource for MemorySourceConfig {
}
}
DisplayForma
comphead commented on code in PR #15029:
URL: https://github.com/apache/datafusion/pull/15029#discussion_r1982300094
##
datafusion/datasource/src/memory.rs:
##
@@ -425,25 +425,20 @@ impl DataSource for MemorySourceConfig {
}
}
DisplayFo
alamb opened a new pull request, #15029:
URL: https://github.com/apache/datafusion/pull/15029
## Which issue does this PR close?
- part of https://github.com/apache/datafusion/issues/14914
## Rationale for this change
- See https://github.com/apache/datafusion/iss
alamb commented on code in PR #15029:
URL: https://github.com/apache/datafusion/pull/15029#discussion_r1981578280
##
datafusion/datasource-csv/src/source.rs:
##
@@ -617,8 +617,13 @@ impl FileSource for CsvSource {
fn file_type(&self) -> &str {
"csv"
}
-fn
