Re: [PR] Unparse struct to sql [datafusion]

2024-11-21 Thread via GitHub
alamb commented on PR #13493: URL: https://github.com/apache/datafusion/pull/13493#issuecomment-2491288247 🚀 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] Unparse struct to sql [datafusion]

2024-11-21 Thread via GitHub
alamb merged PR #13493: URL: https://github.com/apache/datafusion/pull/13493 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusi

Re: [PR] Unparse struct to sql [datafusion]

2024-11-21 Thread via GitHub
delamarch3 commented on PR #13493: URL: https://github.com/apache/datafusion/pull/13493#issuecomment-2490870641 Thanks for the review @goldmedal -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] Unparse struct to sql [datafusion]

2024-11-21 Thread via GitHub
goldmedal commented on code in PR #13493: URL: https://github.com/apache/datafusion/pull/13493#discussion_r1851732566 ## datafusion/sql/src/unparser/expr.rs: ## @@ -514,6 +516,57 @@ impl Unparser<'_> { }) } +fn named_struct_to_sql(&self, args: &[Expr]) -> Res

Re: [PR] Unparse struct to sql [datafusion]

2024-11-20 Thread via GitHub
delamarch3 commented on PR #13493: URL: https://github.com/apache/datafusion/pull/13493#issuecomment-2489555899 Thanks @jonathanc-n, I've updated the errors -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Unparse struct to sql [datafusion]

2024-11-20 Thread via GitHub
jonathanc-n commented on code in PR #13493: URL: https://github.com/apache/datafusion/pull/13493#discussion_r1850920747 ## datafusion/sql/src/unparser/expr.rs: ## @@ -514,6 +516,52 @@ impl Unparser<'_> { }) } +fn named_struct_to_sql(&self, args: &[Expr]) -> R

[PR] Unparse struct to sql [datafusion]

2024-11-19 Thread via GitHub
delamarch3 opened a new pull request, #13493: URL: https://github.com/apache/datafusion/pull/13493 ## Which issue does this PR close? Closes #13477 ## Rationale for this change ## What changes are included in this PR? Implement expr_to_sql for `named_s