jdye64 commented on code in PR #691:
URL: https://github.com/apache/datafusion-python/pull/691#discussion_r1600134611
##
src/expr.rs:
##
@@ -558,41 +553,9 @@ impl PyExpr {
}
})
}
-
-pub fn column_name(&self, plan: PyLogicalPlan) -> PyResult {
-
andygrove commented on code in PR #691:
URL: https://github.com/apache/datafusion-python/pull/691#discussion_r1600065764
##
src/expr.rs:
##
@@ -558,41 +553,9 @@ impl PyExpr {
}
})
}
-
-pub fn column_name(&self, plan: PyLogicalPlan) -> PyResult {
-
andygrove merged PR #691:
URL: https://github.com/apache/datafusion-python/pull/691
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@d
andygrove commented on code in PR #691:
URL: https://github.com/apache/datafusion-python/pull/691#discussion_r1599254876
##
src/expr.rs:
##
@@ -558,41 +553,9 @@ impl PyExpr {
}
})
}
-
-pub fn column_name(&self, plan: PyLogicalPlan) -> PyResult {
-
Michael-J-Ward commented on code in PR #691:
URL: https://github.com/apache/datafusion-python/pull/691#discussion_r1599170243
##
src/expr.rs:
##
@@ -558,41 +553,9 @@ impl PyExpr {
}
})
}
-
-pub fn column_name(&self, plan: PyLogicalPlan) -> PyResult
Michael-J-Ward commented on code in PR #691:
URL: https://github.com/apache/datafusion-python/pull/691#discussion_r1599133595
##
datafusion/tests/test_dataframe.py:
##
@@ -730,9 +730,9 @@ def test_describe(df):
"max",
"median",
],
-"a":
Michael-J-Ward commented on code in PR #691:
URL: https://github.com/apache/datafusion-python/pull/691#discussion_r1599133595
##
datafusion/tests/test_dataframe.py:
##
@@ -730,9 +730,9 @@ def test_describe(df):
"max",
"median",
],
-"a":
andygrove commented on code in PR #691:
URL: https://github.com/apache/datafusion-python/pull/691#discussion_r1599123000
##
datafusion/tests/test_dataframe.py:
##
@@ -730,9 +730,9 @@ def test_describe(df):
"max",
"median",
],
-"a": [3.0
andygrove commented on code in PR #691:
URL: https://github.com/apache/datafusion-python/pull/691#discussion_r1599122358
##
Cargo.toml:
##
@@ -37,13 +37,13 @@ substrait = ["dep:datafusion-substrait"]
tokio = { version = "1.35", features = ["macros", "rt", "rt-multi-thread",
"s
andygrove commented on code in PR #691:
URL: https://github.com/apache/datafusion-python/pull/691#discussion_r1599120965
##
src/expr.rs:
##
@@ -558,41 +553,9 @@ impl PyExpr {
}
})
}
-
-pub fn column_name(&self, plan: PyLogicalPlan) -> PyResult {
-
Michael-J-Ward opened a new pull request, #691:
URL: https://github.com/apache/datafusion-python/pull/691
# Which issue does this PR close?
Closes #690.
# Are there any user-facing changes?
- `DFField` and related methods were removed
- `PyScalarFunction` and `PyBuilti
11 matches
Mail list logo
