Re: [PR] feat: Add support for RLike [datafusion-comet]

2024-07-18 Thread via GitHub
andygrove closed pull request #469: feat: Add support for RLike URL: https://github.com/apache/datafusion-comet/pull/469 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] feat: Add support for RLike [datafusion-comet]

2024-06-07 Thread via GitHub
andygrove commented on code in PR #469: URL: https://github.com/apache/datafusion-comet/pull/469#discussion_r1631706529 ## core/src/execution/datafusion/expressions/regexp.rs: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more con

Re: [PR] feat: Add support for RLike [datafusion-comet]

2024-06-07 Thread via GitHub
andygrove commented on code in PR #469: URL: https://github.com/apache/datafusion-comet/pull/469#discussion_r1631705684 ## core/src/execution/datafusion/expressions/regexp.rs: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more con

Re: [PR] feat: Add support for RLike [datafusion-comet]

2024-06-07 Thread via GitHub
kazuyukitanimura commented on code in PR #469: URL: https://github.com/apache/datafusion-comet/pull/469#discussion_r1631685596 ## core/src/execution/datafusion/expressions/regexp.rs: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] feat: Add support for RLike [datafusion-comet]

2024-06-07 Thread via GitHub
andygrove commented on code in PR #469: URL: https://github.com/apache/datafusion-comet/pull/469#discussion_r1631661598 ## core/src/execution/datafusion/expressions/regexp.rs: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more con

Re: [PR] feat: Add support for RLike [datafusion-comet]

2024-06-07 Thread via GitHub
andygrove commented on code in PR #469: URL: https://github.com/apache/datafusion-comet/pull/469#discussion_r1631660778 ## core/src/execution/datafusion/expressions/regexp.rs: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more con

Re: [PR] feat: Add support for RLike [datafusion-comet]

2024-06-07 Thread via GitHub
kazuyukitanimura commented on code in PR #469: URL: https://github.com/apache/datafusion-comet/pull/469#discussion_r1631588805 ## core/src/execution/datafusion/expressions/regexp.rs: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or m

Re: [PR] feat: Add support for RLike [datafusion-comet]

2024-06-07 Thread via GitHub
andygrove commented on PR #469: URL: https://github.com/apache/datafusion-comet/pull/469#issuecomment-2155043489 Could I get more feedback on this PR @parthchandra @kazuyukitanimura @huaxingao -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] feat: Add support for RLike [datafusion-comet]

2024-05-24 Thread via GitHub
kazuyukitanimura commented on code in PR #469: URL: https://github.com/apache/datafusion-comet/pull/469#discussion_r1613974875 ## spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala: ## @@ -1094,24 +1094,46 @@ object QueryPlanSerde extends Logging with ShimQueryPla

Re: [PR] feat: Add support for RLike [datafusion-comet]

2024-05-24 Thread via GitHub
andygrove commented on code in PR #469: URL: https://github.com/apache/datafusion-comet/pull/469#discussion_r1613743037 ## spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala: ## @@ -1094,24 +1094,46 @@ object QueryPlanSerde extends Logging with ShimQueryPlanSerde

Re: [PR] feat: Add support for RLike [datafusion-comet]

2024-05-24 Thread via GitHub
viirya commented on code in PR #469: URL: https://github.com/apache/datafusion-comet/pull/469#discussion_r1613739740 ## spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala: ## @@ -1094,24 +1094,46 @@ object QueryPlanSerde extends Logging with ShimQueryPlanSerde wit

[PR] feat: Add support for RLike [datafusion-comet]

2024-05-24 Thread via GitHub
andygrove opened a new pull request, #469: URL: https://github.com/apache/datafusion-comet/pull/469 ## Which issue does this PR close? N/A ## Rationale for this change Regular expression support is usually important in ETL jobs, so we should start adding