Re: [PR] feat: Supporting `SAMPLE` parsing [datafusion-sqlparser-rs]

2025-01-15 Thread via GitHub
seve-martinez closed pull request #1566: feat: Supporting `SAMPLE` parsing URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1566 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] feat: Supporting `SAMPLE` parsing [datafusion-sqlparser-rs]

2025-01-15 Thread via GitHub
seve-martinez commented on PR #1566: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1566#issuecomment-2593395062 > I did not notice this PR when I started working on parsing the SAMPLE option, but since then it was merged: #1580 > > I can share that we used to parse the

Re: [PR] feat: Supporting `SAMPLE` parsing [datafusion-sqlparser-rs]

2025-01-11 Thread via GitHub
yoavcloud commented on PR #1566: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1566#issuecomment-2585610656 I did not notice this PR when I started working on parsing the SAMPLE option, but since then it was merged: https://github.com/apache/datafusion-sqlparser-rs/pull/1580

Re: [PR] feat: Supporting `SAMPLE` parsing [datafusion-sqlparser-rs]

2024-12-06 Thread via GitHub
iffyio commented on PR #1566: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1566#issuecomment-2523247703 Hi @seve-martinez! It sounds like the parsing can be done while parsing the select body instead? Probably [here before looking for a WHERE clause](https://github.com/apach

[PR] feat: Supporting `SAMPLE` parsing [datafusion-sqlparser-rs]

2024-11-27 Thread via GitHub
seve-martinez opened a new pull request, #1566: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1566 Snowflake, Databricks, Postgres, and others all support some from of table sampling. This commonly takes on the form ```sql SELECT ... FROM ... { SAMPLE |