Re: [PR] fix(datafusion-proto): support serializing/deserilizing ArrowFormat tables [datafusion]

2025-07-25 Thread via GitHub
xudong963 merged PR #16875: URL: https://github.com/apache/datafusion/pull/16875 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@data

[PR] fix(datafusion-proto): support serializing/deserilizing ArrowFormat tables [datafusion]

2025-07-23 Thread via GitHub
colinmarc opened a new pull request, #16875: URL: https://github.com/apache/datafusion/pull/16875 ## Which issue does this PR close? - Closes #16874 ## What changes are included in this PR? Added protobuf support for ArrowFormat. ## Are these changes teste

Re: [PR] Fix `datafusion-cli` memory leak by using `snmalloc` [datafusion]

2025-07-22 Thread via GitHub
github-actions[bot] closed pull request #15963: Fix `datafusion-cli` memory leak by using `snmalloc` URL: https://github.com/apache/datafusion/pull/15963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Fix `datafusion-cli` memory leak by using `snmalloc` [datafusion]

2025-07-14 Thread via GitHub
github-actions[bot] commented on PR #15963: URL: https://github.com/apache/datafusion/pull/15963#issuecomment-3071664216 Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or

Re: [PR] Fix: datafusion-sqllogictest 48.0.0 can't be published [datafusion]

2025-06-11 Thread via GitHub
alamb merged PR #16376: URL: https://github.com/apache/datafusion/pull/16376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusi

[PR] Fix: datafusion-sqllogictest 48.0.0 can't be published [datafusion]

2025-06-11 Thread via GitHub
xudong963 opened a new pull request, #16376: URL: https://github.com/apache/datafusion/pull/16376 ## Which issue does this PR close? - Closes https://github.com/apache/datafusion/issues/16375 ## Rationale for this change ## What changes are included in thi

Re: [PR] Fix `datafusion-cli` memory leak by using `snmalloc` [datafusion]

2025-05-07 Thread via GitHub
Dandandan commented on PR #15963: URL: https://github.com/apache/datafusion/pull/15963#issuecomment-2857791560 I think it makes sense to run some benchmarks again since also jemalloc has implemented some optimizations over time. -- This is an automated message from the Apache Git Service.

Re: [PR] Fix `datafusion-cli` memory leak by using `snmalloc` [datafusion]

2025-05-07 Thread via GitHub
2010YOUY01 commented on PR #15963: URL: https://github.com/apache/datafusion/pull/15963#issuecomment-2857706106 > Any reason for snmalloc vs jemalloc? Experiments show `snmalloc` is faster: https://github.com/apache/datafusion/issues/1264 -- This is an automated message from the Ap

Re: [PR] Fix `datafusion-cli` memory leak by using `snmalloc` [datafusion]

2025-05-06 Thread via GitHub
Omega359 commented on PR #15963: URL: https://github.com/apache/datafusion/pull/15963#issuecomment-2855968622 Any reason for snmalloc vs mimalloc or jemalloc? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[PR] Fix `datafusion-cli` memory leak by using `snmalloc` [datafusion]

2025-05-06 Thread via GitHub
2010YOUY01 opened a new pull request, #15963: URL: https://github.com/apache/datafusion/pull/15963 ## Which issue does this PR close? - Closes https://github.com/apache/datafusion/issues/15939 ## Rationale for this change To be more precise: this is not a

Re: [PR] Fix datafusion proto crate `json` feature [datafusion]

2025-03-13 Thread via GitHub
comphead merged PR #15172: URL: https://github.com/apache/datafusion/pull/15172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@dataf

Re: [PR] Fix datafusion proto crate json feature [datafusion]

2025-03-13 Thread via GitHub
alamb commented on PR #15172: URL: https://github.com/apache/datafusion/pull/15172#issuecomment-2721138735 > Thank you @Owen-CH-Leung 🙏 > > Can you please merge up from main now that this PR is merged > > * [Split out `datafusion-substrait` and `datafusion-proto` CI feature che

Re: [PR] Fix datafusion proto crate `json` feature [datafusion]

2025-03-13 Thread via GitHub
Owen-CH-Leung commented on PR #15172: URL: https://github.com/apache/datafusion/pull/15172#issuecomment-2721233214 > > Thank you @Owen-CH-Leung 🙏 > > Can you please merge up from main now that this PR is merged > > > > * [Split out `datafusion-substrait` and `datafusion-proto` CI fe

[PR] Fix datafusion proto crate json feature [datafusion]

2025-03-11 Thread via GitHub
Owen-CH-Leung opened a new pull request, #15172: URL: https://github.com/apache/datafusion/pull/15172 Fixes #15157 This PR fixes the json feature of the datafusion proto crate which is currently broken as main -- This is an automated message from the Apache Git Service. To respond

[PR] fix: [datafusion]

2025-01-11 Thread via GitHub
mesejo opened a new pull request, #14087: URL: https://github.com/apache/datafusion/pull/14087 ## Which issue does this PR close? Closes #14055. ## Rationale for this change N/A ## What changes are included in this PR? N/A ## Are these changes tested? Yes

Re: [PR] fix(datafusion-functions-nested): `arrow-distinct` now work with null rows [datafusion]

2025-01-02 Thread via GitHub
alamb commented on PR #13966: URL: https://github.com/apache/datafusion/pull/13966#issuecomment-2568184243 Thanks again @rluvaton and @getChan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] fix(datafusion-functions-nested): `arrow-distinct` now work with null rows [datafusion]

2025-01-02 Thread via GitHub
alamb merged PR #13966: URL: https://github.com/apache/datafusion/pull/13966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusi

Re: [PR] fix(datafusion-functions-nested): `arrow-distinct` now work with null rows [datafusion]

2025-01-01 Thread via GitHub
alamb commented on code in PR #13966: URL: https://github.com/apache/datafusion/pull/13966#discussion_r1900398739 ## datafusion/functions-nested/src/set_ops.rs: ## @@ -516,11 +516,18 @@ fn general_array_distinct( let mut new_arrays = Vec::with_capacity(array.len()); le

Re: [PR] fix(datafusion-functions-nested): `arrow-distinct` now work with null rows [datafusion]

2025-01-01 Thread via GitHub
getChan commented on code in PR #13966: URL: https://github.com/apache/datafusion/pull/13966#discussion_r1900393942 ## datafusion/sqllogictest/test_files/array.slt: ## @@ -5674,6 +5674,13 @@ select array_distinct([sum(a)]) from t1 where a > 100 group by b; statement ok drop t

Re: [PR] fix: DataFusion panics with "No candidates provided" [datafusion]

2024-09-17 Thread via GitHub
alamb commented on PR #12469: URL: https://github.com/apache/datafusion/pull/12469#issuecomment-2356528806 Technically speaking this PR has an API change as I think the signature of a public function has changed -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] fix: DataFusion panics with "No candidates provided" [datafusion]

2024-09-17 Thread via GitHub
alamb merged PR #12469: URL: https://github.com/apache/datafusion/pull/12469 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusi

Re: [PR] fix: DataFusion panics with "No candidates provided" [datafusion]

2024-09-17 Thread via GitHub
alamb commented on code in PR #12469: URL: https://github.com/apache/datafusion/pull/12469#discussion_r1763633138 ## datafusion/sql/src/expr/function.rs: ## @@ -66,8 +66,8 @@ pub fn suggest_valid_function( } /// Find the closest matching string to the target string in the ca

Re: [PR] fix: DataFusion panics with "No candidates provided" [datafusion]

2024-09-17 Thread via GitHub
alamb commented on PR #12469: URL: https://github.com/apache/datafusion/pull/12469#issuecomment-2356529271 Thanks again @Weijun-H and @comphead -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] fix: DataFusion panics with "No candidates provided" [datafusion]

2024-09-17 Thread via GitHub
alamb commented on code in PR #12469: URL: https://github.com/apache/datafusion/pull/12469#discussion_r1763628050 ## datafusion/sql/src/expr/function.rs: ## @@ -66,8 +66,8 @@ pub fn suggest_valid_function( } /// Find the closest matching string to the target string in the ca

Re: [PR] fix: DataFusion panics with "No candidates provided" [datafusion]

2024-09-15 Thread via GitHub
comphead commented on code in PR #12469: URL: https://github.com/apache/datafusion/pull/12469#discussion_r1760316418 ## datafusion/sql/src/expr/function.rs: ## @@ -66,8 +66,8 @@ pub fn suggest_valid_function( } /// Find the closest matching string to the target string in the

Re: [PR] fix: DataFusion panics with "No candidates provided" [datafusion]

2024-09-15 Thread via GitHub
alamb commented on code in PR #12469: URL: https://github.com/apache/datafusion/pull/12469#discussion_r1760033533 ## datafusion/sql/src/expr/function.rs: ## @@ -77,7 +77,7 @@ fn find_closest_match(candidates: Vec, target: &str) -> String { &target,