Re: [PR] fix: get_struct field is incorrect when struct in array [datafusion-comet]

2025-05-16 Thread via GitHub
comphead merged PR #1687: URL: https://github.com/apache/datafusion-comet/pull/1687 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@d

Re: [PR] fix: get_struct field is incorrect when struct in array [datafusion-comet]

2025-05-16 Thread via GitHub
comphead commented on code in PR #1687: URL: https://github.com/apache/datafusion-comet/pull/1687#discussion_r2093701858 ## native/core/src/parquet/parquet_support.rs: ## @@ -171,7 +178,36 @@ fn cast_array( .with_timezone(Arc::clone(tz)), ))

Re: [PR] fix: get_struct field is incorrect when struct in array [datafusion-comet]

2025-05-16 Thread via GitHub
comphead commented on code in PR #1687: URL: https://github.com/apache/datafusion-comet/pull/1687#discussion_r2093701858 ## native/core/src/parquet/parquet_support.rs: ## @@ -171,7 +178,36 @@ fn cast_array( .with_timezone(Arc::clone(tz)), ))

Re: [PR] fix: get_struct field is incorrect when struct in array [datafusion-comet]

2025-05-16 Thread via GitHub
comphead commented on code in PR #1687: URL: https://github.com/apache/datafusion-comet/pull/1687#discussion_r2093701858 ## native/core/src/parquet/parquet_support.rs: ## @@ -171,7 +178,36 @@ fn cast_array( .with_timezone(Arc::clone(tz)), ))

Re: [PR] fix: get_struct field is incorrect when struct in array [datafusion-comet]

2025-05-16 Thread via GitHub
comphead commented on code in PR #1687: URL: https://github.com/apache/datafusion-comet/pull/1687#discussion_r2093701858 ## native/core/src/parquet/parquet_support.rs: ## @@ -171,7 +178,36 @@ fn cast_array( .with_timezone(Arc::clone(tz)), ))

Re: [PR] fix: get_struct field is incorrect when struct in array [datafusion-comet]

2025-05-16 Thread via GitHub
andygrove commented on code in PR #1687: URL: https://github.com/apache/datafusion-comet/pull/1687#discussion_r2093691011 ## native/core/src/parquet/parquet_support.rs: ## @@ -171,7 +178,36 @@ fn cast_array( .with_timezone(Arc::clone(tz)), ))

Re: [PR] fix: get_struct field is incorrect when struct in array [datafusion-comet]

2025-05-16 Thread via GitHub
andygrove commented on code in PR #1687: URL: https://github.com/apache/datafusion-comet/pull/1687#discussion_r2093690008 ## native/core/src/parquet/parquet_support.rs: ## @@ -171,7 +178,36 @@ fn cast_array( .with_timezone(Arc::clone(tz)), ))

Re: [PR] fix: get_struct field is incorrect when struct in array [datafusion-comet]

2025-05-16 Thread via GitHub
andygrove commented on code in PR #1687: URL: https://github.com/apache/datafusion-comet/pull/1687#discussion_r2093686474 ## native/core/src/parquet/parquet_support.rs: ## @@ -171,7 +178,36 @@ fn cast_array( .with_timezone(Arc::clone(tz)), ))

Re: [PR] fix: get_struct field is incorrect when struct in array [datafusion-comet]

2025-05-16 Thread via GitHub
andygrove commented on code in PR #1687: URL: https://github.com/apache/datafusion-comet/pull/1687#discussion_r2093686930 ## native/core/src/parquet/parquet_support.rs: ## @@ -171,7 +178,36 @@ fn cast_array( .with_timezone(Arc::clone(tz)), ))

Re: [PR] fix: get_struct field is incorrect when struct in array [datafusion-comet]

2025-05-16 Thread via GitHub
andygrove commented on code in PR #1687: URL: https://github.com/apache/datafusion-comet/pull/1687#discussion_r2093684993 ## native/core/src/parquet/parquet_support.rs: ## @@ -171,7 +178,36 @@ fn cast_array( .with_timezone(Arc::clone(tz)), ))

Re: [PR] fix: get_struct field is incorrect when struct in array [datafusion-comet]

2025-05-16 Thread via GitHub
comphead commented on PR #1687: URL: https://github.com/apache/datafusion-comet/pull/1687#issuecomment-2887686100 @andygrove @parthchandra @mbutrovich if you have time to look into it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] fix: get_struct field is incorrect when struct in array [datafusion-comet]

2025-04-28 Thread via GitHub
comphead opened a new pull request, #1687: URL: https://github.com/apache/datafusion-comet/pull/1687 ## Which issue does this PR close? Closes #1681 . ## Rationale for this change ## What changes are included in this PR? ## How are these cha