Re: [PR] fix: implement lazy evaluation in Coalesce function [datafusion-comet]

coderfender commented on code in PR #2270: URL: https://github.com/apache/datafusion-comet/pull/2270#discussion_r2356186530 ## spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala: ## @@ -394,6 +394,20 @@ class CometExpressionSuite extends CometTestBase with Adaptiv

Re: [PR] fix: implement lazy evaluation in Coalesce function [datafusion-comet]

coderfender commented on code in PR #2270: URL: https://github.com/apache/datafusion-comet/pull/2270#discussion_r2356186530 ## spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala: ## @@ -394,6 +394,20 @@ class CometExpressionSuite extends CometTestBase with Adaptiv

Re: [PR] fix: implement lazy evaluation in Coalesce function [datafusion-comet]

parthchandra commented on code in PR #2270: URL: https://github.com/apache/datafusion-comet/pull/2270#discussion_r2345625780 ## spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala: ## @@ -394,6 +394,20 @@ class CometExpressionSuite extends CometTestBase with Adapti

Re: [PR] fix: implement lazy evaluation in Coalesce function [datafusion-comet]

andygrove commented on code in PR #2270: URL: https://github.com/apache/datafusion-comet/pull/2270#discussion_r2319898702 ## spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala: ## @@ -394,6 +394,20 @@ class CometExpressionSuite extends CometTestBase with AdaptiveS

Re: [PR] fix: implement lazy evaluation in Coalesce function [datafusion-comet]

andygrove commented on code in PR #2270: URL: https://github.com/apache/datafusion-comet/pull/2270#discussion_r2319898702 ## spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala: ## @@ -394,6 +394,20 @@ class CometExpressionSuite extends CometTestBase with AdaptiveS

Re: [PR] fix: implement lazy evaluation in Coalesce function [datafusion-comet]

coderfender commented on PR #2270: URL: https://github.com/apache/datafusion-comet/pull/2270#issuecomment-3250936680 Thank you for merging the PR @andygrove . I will rebase ANSI arithmetic changes PR with main branch and update there -- This is an automated message from the Apache Git Se

Re: [PR] fix: implement lazy evaluation in Coalesce function [datafusion-comet]

andygrove merged PR #2270: URL: https://github.com/apache/datafusion-comet/pull/2270 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

Re: [PR] fix: implement lazy evaluation in Coalesce function [datafusion-comet]

andygrove commented on code in PR #2270: URL: https://github.com/apache/datafusion-comet/pull/2270#discussion_r2319898702 ## spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala: ## @@ -394,6 +394,20 @@ class CometExpressionSuite extends CometTestBase with AdaptiveS

Re: [PR] fix: implement lazy evaluation in Coalesce function [datafusion-comet]

andygrove commented on code in PR #2270: URL: https://github.com/apache/datafusion-comet/pull/2270#discussion_r2319956170 ## spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala: ## @@ -394,6 +394,20 @@ class CometExpressionSuite extends CometTestBase with AdaptiveS

Re: [PR] fix: implement lazy evaluation in Coalesce function [datafusion-comet]

andygrove commented on code in PR #2270: URL: https://github.com/apache/datafusion-comet/pull/2270#discussion_r231977 ## spark/src/main/scala/org/apache/comet/serde/conditional.scala: ## @@ -91,3 +91,42 @@ object CometCaseWhen extends CometExpressionSerde[CaseWhen] { }

Re: [PR] fix: implement lazy evaluation in Coalesce function [datafusion-comet]

andygrove commented on code in PR #2270: URL: https://github.com/apache/datafusion-comet/pull/2270#discussion_r2319147632 ## spark/src/main/scala/org/apache/comet/serde/conditional.scala: ## @@ -91,3 +91,48 @@ object CometCaseWhen extends CometExpressionSerde[CaseWhen] { }

Re: [PR] fix: implement lazy evaluation in Coalesce function [datafusion-comet]

andygrove commented on code in PR #2270: URL: https://github.com/apache/datafusion-comet/pull/2270#discussion_r2319134255 ## spark/src/main/scala/org/apache/comet/serde/conditional.scala: ## @@ -91,3 +91,48 @@ object CometCaseWhen extends CometExpressionSerde[CaseWhen] { }

Re: [PR] fix: implement lazy evaluation in Coalesce function [datafusion-comet]

coderfender commented on PR #2270: URL: https://github.com/apache/datafusion-comet/pull/2270#issuecomment-3247410744 Thank you very much @andygrove -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] fix: implement lazy evaluation in Coalesce function [datafusion-comet]

coderfender commented on PR #2270: URL: https://github.com/apache/datafusion-comet/pull/2270#issuecomment-3247300578 @andygrove please take a look whenever you get a chance . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] fix: implement lazy evaluation in Coalesce function [datafusion-comet]

codecov-commenter commented on PR #2270: URL: https://github.com/apache/datafusion-comet/pull/2270#issuecomment-3247154784 ## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/2270?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca

Re: [PR] fix: implement lazy evaluation in Coalesce function [datafusion-comet]

coderfender commented on PR #2270: URL: https://github.com/apache/datafusion-comet/pull/2270#issuecomment-3243260142 Rebased with main branch . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] fix: implement lazy evaluation in Coalesce function [datafusion-comet]

coderfender commented on PR #2270: URL: https://github.com/apache/datafusion-comet/pull/2270#issuecomment-3240463824 @andygrove , Please kick off the CI whenever you get a chance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[PR] fix: implement lazy evaluation in Coalesce function [datafusion-comet]

coderfender opened a new pull request, #2270: URL: https://github.com/apache/datafusion-comet/pull/2270 ## Which issue does this PR close? https://github.com/apache/datafusion-comet/issues/2233 Closes #. ## Rationale for this change Spark performs lazy evaluation w