chenkovsky commented on code in PR #16610:
URL: https://github.com/apache/datafusion/pull/16610#discussion_r2175074960
##
datafusion/sql/tests/cases/plan_to_sql.rs:
##
@@ -2596,3 +2600,36 @@ fn test_not_ilike_filter_with_escape() {
@"SELECT person.first_name FROM person
goldmedal commented on code in PR #16610:
URL: https://github.com/apache/datafusion/pull/16610#discussion_r2174859892
##
datafusion/sql/tests/cases/plan_to_sql.rs:
##
@@ -2596,3 +2600,36 @@ fn test_not_ilike_filter_with_escape() {
@"SELECT person.first_name FROM person
goldmedal commented on PR #16610:
URL: https://github.com/apache/datafusion/pull/16610#issuecomment-3017522994
> Thanks @chenkovsky -- this looks good to me but I am not super familar
with this code
>
> @goldmedal or @phillipleblanc I wonder if either of you have some time (or
can su
alamb commented on code in PR #16610:
URL: https://github.com/apache/datafusion/pull/16610#discussion_r2173737830
##
datafusion/sql/tests/cases/plan_to_sql.rs:
##
@@ -2596,3 +2600,27 @@ fn test_not_ilike_filter_with_escape() {
@"SELECT person.first_name FROM person WHER
chenkovsky opened a new pull request, #16610:
URL: https://github.com/apache/datafusion/pull/16610
## Which issue does this PR close?
- Closes #16607.
## Rationale for this change
unparser for get_field will check the first parameter. currently it only
allows column.
