Re: [I] Use sha2 implementation from datafusion-spark crate [datafusion-comet]

2025-08-06 Thread via GitHub
mbutrovich closed issue #1820: Use sha2 implementation from datafusion-spark crate URL: https://github.com/apache/datafusion-comet/issues/1820 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [I] Use sha2 implementation from datafusion-spark crate [datafusion-comet]

2025-08-01 Thread via GitHub
rishvin commented on issue #1820: URL: https://github.com/apache/datafusion-comet/issues/1820#issuecomment-3146120825 Opened PR https://github.com/apache/datafusion-comet/pull/2063 for using DF SHA2. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [I] Use sha2 implementation from datafusion-spark crate [datafusion-comet]

2025-07-11 Thread via GitHub
rishvin commented on issue #1820: URL: https://github.com/apache/datafusion-comet/issues/1820#issuecomment-3063537883 Should be able to open Comet's PR after https://github.com/apache/datafusion-comet/issues/1993 is closed. -- This is an automated message from the Apache Git Service. To

Re: [I] Use sha2 implementation from datafusion-spark crate [datafusion-comet]

2025-06-25 Thread via GitHub
andygrove commented on issue #1820: URL: https://github.com/apache/datafusion-comet/issues/1820#issuecomment-3006624446 > [@andygrove](https://github.com/andygrove) can I backport [SHA2-fix](https://github.com/apache/datafusion/pull/16350) to branch-48 of datafusion ? I tried updating with

Re: [I] Use sha2 implementation from datafusion-spark crate [datafusion-comet]

2025-06-24 Thread via GitHub
rishvin commented on issue #1820: URL: https://github.com/apache/datafusion-comet/issues/1820#issuecomment-3002947426 > > [@andygrove](https://github.com/andygrove) can I backport [SHA2-fix](https://github.com/apache/datafusion/pull/16350) to branch-48 of datafusion ? I tried updating with

Re: [I] Use sha2 implementation from datafusion-spark crate [datafusion-comet]

2025-06-20 Thread via GitHub
rishvin commented on issue #1820: URL: https://github.com/apache/datafusion-comet/issues/1820#issuecomment-2990142584 > [@andygrove](https://github.com/andygrove) can I backport [SHA2-fix](https://github.com/apache/datafusion/pull/16350) to branch-48 of datafusion ? I tried updating with d

Re: [I] Use sha2 implementation from datafusion-spark crate [datafusion-comet]

2025-06-19 Thread via GitHub
rishvin commented on issue #1820: URL: https://github.com/apache/datafusion-comet/issues/1820#issuecomment-2988838360 @andygrove can I backport [SHA2-fix](https://github.com/apache/datafusion/pull/16350) to branch-48 of datafusion ? I tried updating with datafusion-main branch until my com

Re: [I] Use sha2 implementation from datafusion-spark crate [datafusion-comet]

2025-06-17 Thread via GitHub
rishvin commented on issue #1820: URL: https://github.com/apache/datafusion-comet/issues/1820#issuecomment-2982012440 I should be able to resume working on this later this week. I might have to file another ticket to first upgrade the datafusion dependency before making Comet changes. --

Re: [I] Use sha2 implementation from datafusion-spark crate [datafusion-comet]

2025-06-08 Thread via GitHub
andygrove commented on issue #1820: URL: https://github.com/apache/datafusion-comet/issues/1820#issuecomment-2954102662 Thanks for working on this @rishvin. You are correct that Spark doesn't support UInt32 because it is JVM-based. JVM only has signed ints. The upper-case output seem

Re: [I] Use sha2 implementation from datafusion-spark crate [datafusion-comet]

2025-06-07 Thread via GitHub
rishvin commented on issue #1820: URL: https://github.com/apache/datafusion-comet/issues/1820#issuecomment-2953616585 Hi @andygrove, I tried the following approach and looks like there is some discrepancy in the Datafusion's `SparkSha2` output with Spark. **This is what I attempted**

Re: [I] Use sha2 implementation from datafusion-spark crate [datafusion-comet]

2025-06-05 Thread via GitHub
andygrove commented on issue #1820: URL: https://github.com/apache/datafusion-comet/issues/1820#issuecomment-2945503093 Thanks @rishvin. I assigned the issue to you. Let me know if you have any questions. -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [I] Use sha2 implementation from datafusion-spark crate [datafusion-comet]

2025-06-05 Thread via GitHub
rishvin commented on issue #1820: URL: https://github.com/apache/datafusion-comet/issues/1820#issuecomment-2945492404 @andygrove I can work on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go