Re: [PR] Add foreign table providers [datafusion-python]

2024-11-15 Thread via GitHub
timsaucer merged PR #921: URL: https://github.com/apache/datafusion-python/pull/921 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@d

Re: [PR] Add foreign table providers [datafusion-python]

2024-11-15 Thread via GitHub
timsaucer commented on PR #921: URL: https://github.com/apache/datafusion-python/pull/921#issuecomment-2479351749 Thank you for the reviews! I've added an issue to track those two small requests, but I'd like to get this in now -- This is an automated message from the Apache Git Service.

Re: [PR] Add foreign table providers [datafusion-python]

2024-11-15 Thread via GitHub
ion-elgreco commented on code in PR #921: URL: https://github.com/apache/datafusion-python/pull/921#discussion_r1844117151 ## src/context.rs: ## @@ -566,6 +569,26 @@ impl PySessionContext { Ok(()) } +/// Construct datafusion dataframe from Arrow Table +pu

Re: [PR] Add foreign table providers [datafusion-python]

2024-11-15 Thread via GitHub
ion-elgreco commented on code in PR #921: URL: https://github.com/apache/datafusion-python/pull/921#discussion_r1844113029 ## python/datafusion/context.py: ## @@ -685,6 +685,14 @@ def deregister_table(self, name: str) -> None: """Remove a table from the session."""

Re: [PR] Add foreign table providers [datafusion-python]

2024-11-15 Thread via GitHub
Michael-J-Ward commented on code in PR #921: URL: https://github.com/apache/datafusion-python/pull/921#discussion_r1844098181 ## src/context.rs: ## @@ -566,6 +567,30 @@ impl PySessionContext { Ok(()) } +/// Construct datafusion dataframe from Arrow Table +

Re: [PR] Add foreign table providers [datafusion-python]

2024-11-12 Thread via GitHub
timsaucer commented on code in PR #921: URL: https://github.com/apache/datafusion-python/pull/921#discussion_r1837870705 ## src/context.rs: ## @@ -566,6 +569,26 @@ impl PySessionContext { Ok(()) } +/// Construct datafusion dataframe from Arrow Table +pub

Re: [PR] Add foreign table providers [datafusion-python]

2024-11-12 Thread via GitHub
timsaucer commented on code in PR #921: URL: https://github.com/apache/datafusion-python/pull/921#discussion_r1837853740 ## src/context.rs: ## @@ -566,6 +569,26 @@ impl PySessionContext { Ok(()) } +/// Construct datafusion dataframe from Arrow Table +pub

Re: [PR] Add foreign table providers [datafusion-python]

2024-11-11 Thread via GitHub
timsaucer commented on PR #921: URL: https://github.com/apache/datafusion-python/pull/921#issuecomment-2468109850 Now that 43.0.0 has merged into main, I've rebased and I'll work next on adding example and unit tests. -- This is an automated message from the Apache Git Service. To respon

Re: [PR] Add foreign table providers [datafusion-python]

2024-11-04 Thread via GitHub
ion-elgreco commented on code in PR #921: URL: https://github.com/apache/datafusion-python/pull/921#discussion_r1827536226 ## src/context.rs: ## @@ -566,6 +569,26 @@ impl PySessionContext { Ok(()) } +/// Construct datafusion dataframe from Arrow Table +pu