Re: [PR] BigQuery: Add support for select expr star [datafusion-sqlparser-rs]

2025-01-28 Thread via GitHub
iffyio merged PR #1680: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

Re: [PR] BigQuery: Add support for select expr star [datafusion-sqlparser-rs]

2025-01-27 Thread via GitHub
iffyio commented on code in PR #1680: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1680#discussion_r1930933187 ## tests/sqlparser_common.rs: ## @@ -1050,6 +1053,84 @@ fn parse_column_aliases() { one_statement_parses_to("SELECT a.col + 1 newname FROM foo AS a

Re: [PR] BigQuery: Add support for select expr star [datafusion-sqlparser-rs]

2025-01-27 Thread via GitHub
alamb commented on code in PR #1680: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1680#discussion_r1930896465 ## tests/sqlparser_common.rs: ## @@ -1050,6 +1053,84 @@ fn parse_column_aliases() { one_statement_parses_to("SELECT a.col + 1 newname FROM foo AS a"