Re: [PR] Do not add redundant subquery ordering into plan [datafusion]

2025-04-28 Thread via GitHub
maxburke commented on PR #12003: URL: https://github.com/apache/datafusion/pull/12003#issuecomment-2836969736 I think this change causes this bug: https://github.com/apache/datafusion/issues/15886 -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] Do not add redundant subquery ordering into plan [datafusion]

2024-09-10 Thread via GitHub
alamb commented on PR #12003: URL: https://github.com/apache/datafusion/pull/12003#issuecomment-2341973524 This PR introduced a bug https://github.com/apache/datafusion/issues/12423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] Do not add redundant subquery ordering into plan [datafusion]

2024-08-19 Thread via GitHub
ozankabak merged PR #12003: URL: https://github.com/apache/datafusion/pull/12003 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@data

Re: [PR] Do not add redundant subquery ordering into plan [datafusion]

2024-08-18 Thread via GitHub
ozankabak commented on code in PR #12003: URL: https://github.com/apache/datafusion/pull/12003#discussion_r1720839499 ## datafusion/sqllogictest/test_files/joins.slt: ## @@ -3898,6 +3898,7 @@ SELECT * FROM ( ) as lhs RIGHT JOIN ( SELECT * from right_table_no_nulls ORD

Re: [PR] Do not add redundant subquery ordering into plan [datafusion]

2024-08-17 Thread via GitHub
ozankabak commented on code in PR #12003: URL: https://github.com/apache/datafusion/pull/12003#discussion_r1720839499 ## datafusion/sqllogictest/test_files/joins.slt: ## @@ -3898,6 +3898,7 @@ SELECT * FROM ( ) as lhs RIGHT JOIN ( SELECT * from right_table_no_nulls ORD

Re: [PR] Do not add redundant subquery ordering into plan [datafusion]

2024-08-17 Thread via GitHub
ozankabak commented on code in PR #12003: URL: https://github.com/apache/datafusion/pull/12003#discussion_r1720839499 ## datafusion/sqllogictest/test_files/joins.slt: ## @@ -3898,6 +3898,7 @@ SELECT * FROM ( ) as lhs RIGHT JOIN ( SELECT * from right_table_no_nulls ORD

Re: [PR] Do not add redundant subquery ordering into plan [datafusion]

2024-08-16 Thread via GitHub
alamb commented on code in PR #12003: URL: https://github.com/apache/datafusion/pull/12003#discussion_r1720135221 ## datafusion/sqllogictest/test_files/joins.slt: ## @@ -3898,6 +3898,7 @@ SELECT * FROM ( ) as lhs RIGHT JOIN ( SELECT * from right_table_no_nulls ORDER B

Re: [PR] Do not add redundant subquery ordering into plan [datafusion]

2024-08-15 Thread via GitHub
alamb commented on PR #12003: URL: https://github.com/apache/datafusion/pull/12003#issuecomment-2291103035 I plan to review this PR later today or tomorrow -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above