pepijnve commented on PR #16455:
URL: https://github.com/apache/datafusion/pull/16455#issuecomment-2991261702
Take 2 in #16476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
pepijnve commented on PR #16455:
URL: https://github.com/apache/datafusion/pull/16455#issuecomment-2990302693
Ok, thanks for your opinion. Little developer quality of life improvements
like this are worth it imo. I'll make a PR that contains the necessary code
changes and a little bash scri
AdamGS commented on PR #16455:
URL: https://github.com/apache/datafusion/pull/16455#issuecomment-2990259096
I'm not a maintainer but I feel your pain always to do that small mental
jump when looking for a specific query. I think that's a fine solution.
--
This is an automated message from
pepijnve commented on PR #16455:
URL: https://github.com/apache/datafusion/pull/16455#issuecomment-2990187740
@AdamGS would a PR that splits queries.sql into a file per query be
acceptable? There's precedent for that in some of the other benchmarks, and
that seems to be a reasonable comprom
pepijnve closed pull request #16455: Make clickbench query IDs 1-based
URL: https://github.com/apache/datafusion/pull/16455
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
pepijnve commented on PR #16455:
URL: https://github.com/apache/datafusion/pull/16455#issuecomment-2988864943
Ok, that’s probably a stronger argument for keeping things as is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
AdamGS commented on PR #16455:
URL: https://github.com/apache/datafusion/pull/16455#issuecomment-2988832498
But Clickbench treats/displays them as 0-based
https://github.com/user-attachments/assets/64742df1-dd95-4004-b1ed-a8218e68cdc7";
/>
--
This is an automated message from the A
