Re: [PR] Snowflake create database [datafusion-sqlparser-rs]

2025-08-01 Thread via GitHub
iffyio merged PR #1939: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1939 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

Re: [PR] Snowflake create database [datafusion-sqlparser-rs]

2025-08-01 Thread via GitHub
osipovartem commented on code in PR #1939: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1939#discussion_r2247700593 ## src/parser/mod.rs: ## @@ -9756,6 +9771,15 @@ impl<'a> Parser<'a> { } } +/// Parse a boolean string +pub fn parse_boolean

Re: [PR] Snowflake create database [datafusion-sqlparser-rs]

2025-08-01 Thread via GitHub
osipovartem commented on code in PR #1939: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1939#discussion_r2247700210 ## src/parser/mod.rs: ## @@ -9756,6 +9771,15 @@ impl<'a> Parser<'a> { } } +/// Parse a boolean string +pub fn parse_boolean

Re: [PR] Snowflake create database [datafusion-sqlparser-rs]

2025-07-31 Thread via GitHub
iffyio commented on code in PR #1939: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1939#discussion_r2244743813 ## src/parser/mod.rs: ## @@ -9756,6 +9771,15 @@ impl<'a> Parser<'a> { } } +/// Parse a boolean string +pub fn parse_boolean_stri

Re: [PR] Snowflake create database [datafusion-sqlparser-rs]

2025-07-30 Thread via GitHub
osipovartem commented on code in PR #1939: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1939#discussion_r2242612244 ## src/parser/mod.rs: ## @@ -9756,6 +9771,15 @@ impl<'a> Parser<'a> { } } +/// Parse a boolean string +pub fn parse_boolean

Re: [PR] Snowflake create database [datafusion-sqlparser-rs]

2025-07-30 Thread via GitHub
iffyio commented on code in PR #1939: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1939#discussion_r2242330663 ## src/parser/mod.rs: ## @@ -9756,6 +9771,15 @@ impl<'a> Parser<'a> { } } +/// Parse a boolean string +pub fn parse_boolean_stri

Re: [PR] Snowflake create database [datafusion-sqlparser-rs]

2025-07-30 Thread via GitHub
osipovartem commented on PR #1939: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1939#issuecomment-3135391621 @iffyio please take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] Snowflake create database [datafusion-sqlparser-rs]

2025-07-17 Thread via GitHub
iffyio commented on code in PR #1939: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1939#discussion_r2212632085 ## src/ast/mod.rs: ## @@ -9524,6 +9550,29 @@ impl Display for Tag { } } +/// Snowflake `WITH CONTACT ( purpose = contact [ , purpose = contact .

Re: [PR] Snowflake create database [datafusion-sqlparser-rs]

2025-07-15 Thread via GitHub
osipovartem commented on code in PR #1939: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1939#discussion_r2207128546 ## src/ast/mod.rs: ## @@ -9524,6 +9550,29 @@ impl Display for Tag { } } +/// Snowflake `WITH CONTACT ( purpose = contact [ , purpose = cont

Re: [PR] Snowflake create database [datafusion-sqlparser-rs]

2025-07-15 Thread via GitHub
osipovartem commented on code in PR #1939: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1939#discussion_r2207107374 ## src/ast/mod.rs: ## @@ -9524,6 +9550,29 @@ impl Display for Tag { } } +/// Snowflake `WITH CONTACT ( purpose = contact [ , purpose = cont

Re: [PR] Snowflake create database [datafusion-sqlparser-rs]

2025-07-15 Thread via GitHub
iffyio commented on code in PR #1939: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1939#discussion_r2206923615 ## src/dialect/snowflake.rs: ## @@ -731,6 +734,115 @@ pub fn parse_create_table( Ok(builder.build()) } +/// Parse snowflake create database stat