goldmedal commented on PR #13418:
URL: https://github.com/apache/datafusion/pull/13418#issuecomment-2482053239
Thanks @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
alamb merged PR #13418:
URL: https://github.com/apache/datafusion/pull/13418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #13418:
URL: https://github.com/apache/datafusion/pull/13418#issuecomment-2481174103
Thanks again @goldmedal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
alamb commented on code in PR #13418:
URL: https://github.com/apache/datafusion/pull/13418#discussion_r1844320853
##
datafusion/sql/tests/cases/plan_to_sql.rs:
##
@@ -182,6 +184,11 @@ fn roundtrip_statement() -> Result<()> {
SUM(id) OVER (ROWS BETWEEN UNBOUNDED PREC
goldmedal commented on code in PR #13418:
URL: https://github.com/apache/datafusion/pull/13418#discussion_r1842568392
##
datafusion/sql/src/unparser/expr.rs:
##
@@ -476,6 +476,19 @@ impl Unparser<'_> {
&self,
func_name: &str,
args: &[Expr],
+) -> R