Adez017 closed pull request #15832: Update extending-operators.md
URL: https://github.com/apache/datafusion/pull/15832
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
Adez017 commented on PR #15832:
URL: https://github.com/apache/datafusion/pull/15832#issuecomment-3101253592
> Thanks @Adez017
>
> Thank you for your patience.
>
> I think there are a few outstanding issues we should to resolve prior to
merging this:
>
> 1. Remove the (n
Adez017 commented on PR #15832:
URL: https://github.com/apache/datafusion/pull/15832#issuecomment-3091662660
hi @alamb please have a look on this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
github-actions[bot] commented on PR #15832:
URL: https://github.com/apache/datafusion/pull/15832#issuecomment-3091393278
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or comment or
Adez017 commented on PR #15832:
URL: https://github.com/apache/datafusion/pull/15832#issuecomment-2890667621
hey @alamb @xudong963 since your last visit I had made some changes .
please take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, p
Adez017 commented on PR #15832:
URL: https://github.com/apache/datafusion/pull/15832#issuecomment-2888345095
@alamb cc: @xudong963 check it now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
alamb commented on code in PR #15832:
URL: https://github.com/apache/datafusion/pull/15832#discussion_r2082547957
##
docs/source/library-user-guide/extending-operators.md:
##
@@ -19,4 +19,448 @@
# Extending DataFusion's operators: custom LogicalPlan and Execution Plans
-Com
Adez017 commented on PR #15832:
URL: https://github.com/apache/datafusion/pull/15832#issuecomment-2863750241
> > > hey @xudong963 , i think there might be something that I am missing I
had done imports but it cause failing again and again , could you please help
out ?
> >
> >
> >
Adez017 commented on PR #15832:
URL: https://github.com/apache/datafusion/pull/15832#issuecomment-2855288524
> > hey @xudong963 , i think there might be something that I am missing I
had done imports but it cause failing again and again , could you please help
out ?
>
> Here is a wri
alamb commented on PR #15832:
URL: https://github.com/apache/datafusion/pull/15832#issuecomment-2852026880
> hey @xudong963 , i think there might be something that I am missing I had
done imports but it cause failing again and again , could you please help out ?
Here is a writeup that
Adez017 commented on PR #15832:
URL: https://github.com/apache/datafusion/pull/15832#issuecomment-2850617420
hey @xudong963 , i think there might be something that I am missing I had
done imports but it cause failing again and again , could you please help out ?
--
This is an automat
xudong963 commented on PR #15832:
URL: https://github.com/apache/datafusion/pull/15832#issuecomment-2849865580
> Thanks, mate, but I think it shows for the `lib.rs` file, and we didn't
make any changes there. Does this mean that we need to change over there?
If you take a look at the
Adez017 commented on PR #15832:
URL: https://github.com/apache/datafusion/pull/15832#issuecomment-2849308705
> Could you please refer to the error lints in CI? Such as
>
> ```
> error[E0433]: failed to resolve: use of undeclared type `Statistics`
> --> datafusion/core/src/lib.r
xudong963 commented on PR #15832:
URL: https://github.com/apache/datafusion/pull/15832#issuecomment-2849259474
Could you please refer to the error lints in CI? Such as
```
error[E0433]: failed to resolve: use of undeclared type `Statistics`
--> datafusion/core/src/lib.rs:1365:12
Adez017 commented on PR #15832:
URL: https://github.com/apache/datafusion/pull/15832#issuecomment-2848744801
could anyone please help here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
Adez017 commented on PR #15832:
URL: https://github.com/apache/datafusion/pull/15832#issuecomment-2848457356
@alamb , please take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
Adez017 commented on PR #15832:
URL: https://github.com/apache/datafusion/pull/15832#issuecomment-2846154397
i Think ww need @alamb help now . could you help ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
xudong963 commented on PR #15832:
URL: https://github.com/apache/datafusion/pull/15832#issuecomment-2844855985
> > > > You can rebase with main
> > >
> > >
> > > doe this solve the issue ?
> >
> >
> > You can open the failed CI and see what's wrong:
> > ```
> > err
Adez017 commented on PR #15832:
URL: https://github.com/apache/datafusion/pull/15832#issuecomment-2844762089
> > > You can rebase with main
> >
> >
> > doe this solve the issue ?
>
> You can open the failed CI and see what's wrong:
>
> ```
> error[E0599]: no method
xudong963 commented on PR #15832:
URL: https://github.com/apache/datafusion/pull/15832#issuecomment-2835290751
> > You can rebase with main
>
> doe this solve the issue ?
You can open the failed CI and see what's wrong:
```
error[E0599]: no method named `unwrap` found for
Adez017 commented on PR #15832:
URL: https://github.com/apache/datafusion/pull/15832#issuecomment-2833455331
> You can rebase with main
doe this solve the issue ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
xudong963 commented on PR #15832:
URL: https://github.com/apache/datafusion/pull/15832#issuecomment-2833377199
Would anyone happen to know how to preview the HTML format for the PR
changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
xudong963 commented on PR #15832:
URL: https://github.com/apache/datafusion/pull/15832#issuecomment-2833376316
You can rebase with main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
Adez017 commented on PR #15832:
URL: https://github.com/apache/datafusion/pull/15832#issuecomment-2829859562
hey @xudong963 , check it out now .
also could you help in the failing check in workflow?
--
This is an automated message from the Apache Git Service.
To respond to the message,
Adez017 commented on PR #15832:
URL: https://github.com/apache/datafusion/pull/15832#issuecomment-2829373011
Hi @xudong963 , i think it is ready , give it a check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
xudong963 commented on PR #15832:
URL: https://github.com/apache/datafusion/pull/15832#issuecomment-2829380416
You can refer to the doc:
https://datafusion.apache.org/library-user-guide/custom-table-providers.html.
It should contain the real code
https://github.com/apache/datafusion/
Adez017 commented on PR #15832:
URL: https://github.com/apache/datafusion/pull/15832#issuecomment-2826457369
> > > > i want to ask that did we had to rewrite the part of code
https://github.com/apache/datafusion/blob/main/datafusion/core/tests/user_defined/user_defined_plan.rs#L18-L24
after
xudong963 commented on PR #15832:
URL: https://github.com/apache/datafusion/pull/15832#issuecomment-2826449563
> > > i want to ask that did we had to rewrite the part of code
https://github.com/apache/datafusion/blob/main/datafusion/core/tests/user_defined/user_defined_plan.rs#L18-L24
after
Adez017 commented on PR #15832:
URL: https://github.com/apache/datafusion/pull/15832#issuecomment-2826434082
> > i want to ask that did we had to rewrite the part of code
https://github.com/apache/datafusion/blob/main/datafusion/core/tests/user_defined/user_defined_plan.rs#L18-L24
afterward
xudong963 commented on PR #15832:
URL: https://github.com/apache/datafusion/pull/15832#issuecomment-2826402327
> i want to ask that did we had to rewrite the part of code
https://github.com/apache/datafusion/blob/main/datafusion/core/tests/user_defined/user_defined_plan.rs#L18-L24
afterward
Adez017 commented on PR #15832:
URL: https://github.com/apache/datafusion/pull/15832#issuecomment-2824970974
hi @xudong963 , i want to ask that did we had to rewrite the part of code
https://github.com/apache/datafusion/blob/main/datafusion/core/tests/user_defined/user_defined_plan.rs#L18-L2
31 matches
Mail list logo
