Re: [PR] WIP: Upgrade to Datafusion 43 [datafusion-python]

2024-11-10 Thread via GitHub
Michael-J-Ward commented on PR #905: URL: https://github.com/apache/datafusion-python/pull/905#issuecomment-2466796689 @timsaucer - thanks for finishing this up! I think it's good to go. Especially since this 1st upgrade PR is primarily for the dependencies. -- This is an auto

Re: [PR] WIP: Upgrade to Datafusion 43 [datafusion-python]

2024-11-09 Thread via GitHub
timsaucer commented on PR #905: URL: https://github.com/apache/datafusion-python/pull/905#issuecomment-2466440798 Ok, I think this is ready to merge. @Michael-J-Ward do you want to look over the changes I added in to account for the new string views? -- This is an automated message from

Re: [PR] WIP: Upgrade to Datafusion 43 [datafusion-python]

2024-10-28 Thread via GitHub
Michael-J-Ward commented on PR #905: URL: https://github.com/apache/datafusion-python/pull/905#issuecomment-2442696429 @timsaucer - yes, if you wouldn't mind. Here's where I'm at. `MulticolumnWindowUDF::partition_evaluator` gets called with the correct arguments ```cons

Re: [PR] WIP: Upgrade to Datafusion 43 [datafusion-python]

2024-10-28 Thread via GitHub
timsaucer commented on PR #905: URL: https://github.com/apache/datafusion-python/pull/905#issuecomment-2442678960 Do you need help troubleshooting the test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] WIP: Upgrade to Datafusion 43 [datafusion-python]

2024-10-28 Thread via GitHub
Michael-J-Ward commented on PR #905: URL: https://github.com/apache/datafusion-python/pull/905#issuecomment-2442642237 For context on the `SmoothTwoColumn` test. On this branch, the `values` argument passed into `SmoothTwoColumn.evaluate_all` ```python > /home/mike/worksp