kosiew merged PR #16835:
URL: https://github.com/apache/datafusion/pull/16835
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafus
kosiew closed issue #16801: Schema adapter Integration tests are not being run
URL: https://github.com/apache/datafusion/issues/16801
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
kosiew commented on PR #16835:
URL: https://github.com/apache/datafusion/pull/16835#issuecomment-3124405876
Thanks @alamb , @findepi for your reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
berkaysynnada closed issue #16736: Filtering and counting afterwards causes
overflow panic in interval arithmetics
URL: https://github.com/apache/datafusion/issues/16736
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
berkaysynnada merged PR #16745:
URL: https://github.com/apache/datafusion/pull/16745
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
petern48 commented on code in PR #16780:
URL: https://github.com/apache/datafusion/pull/16780#discussion_r2234069016
##
datafusion/sqllogictest/test_files/spark/datetime/next_day.slt:
##
@@ -23,5 +23,65 @@
## Original Query: SELECT next_day('2015-01-14', 'TU');
## PySpark 3.
waynexia commented on PR #16877:
URL: https://github.com/apache/datafusion/pull/16877#issuecomment-3124163124
I do find revert the null checking logic on non-ascii branch will eliminate
regression on those two cases, but it would slow down other cases in the same
time. Still not sure why th
kosiew commented on code in PR #16926:
URL: https://github.com/apache/datafusion/pull/16926#discussion_r2233803439
##
datafusion/execution/src/memory_pool/memory_report.rs:
##
@@ -0,0 +1,118 @@
+use super::{human_readable_size, MemoryReservation};
+use crate::memory_pool::pool::
kosiew opened a new pull request, #1192:
URL: https://github.com/apache/datafusion-python/pull/1192
## Which issue does this PR close?
- Closes #1190
## Rationale for this change
This PR updates the `MyAccumulator` implementation in the Python UDAF
example to properly ha
UBarney commented on PR #16889:
URL: https://github.com/apache/datafusion/pull/16889#issuecomment-3124214924
> > I didn't expect this PR to have such a big performance improvement. Like
#16443, I still don't understand why there is a performance improvement.
>
> I’m aware of two key d
kosiew commented on code in PR #16835:
URL: https://github.com/apache/datafusion/pull/16835#discussion_r2233876909
##
datafusion/core/tests/parquet/schema_adapter.rs:
##
@@ -370,3 +378,321 @@ async fn
test_custom_schema_adapter_and_custom_expression_adapter() {
];
ass
acking-you opened a new pull request, #16930:
URL: https://github.com/apache/datafusion/pull/16930
## Which issue does this PR close?
- Closes #16928.
## Rationale for this change
## What changes are included in this PR?
## Are these changes
Standing-Man commented on code in PR #16780:
URL: https://github.com/apache/datafusion/pull/16780#discussion_r2233882699
##
datafusion/sqllogictest/test_files/spark/datetime/next_day.slt:
##
@@ -23,5 +23,65 @@
## Original Query: SELECT next_day('2015-01-14', 'TU');
## PySpar
berkaysynnada merged PR #16911:
URL: https://github.com/apache/datafusion/pull/16911
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
berkaysynnada merged PR #16881:
URL: https://github.com/apache/datafusion/pull/16881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
alamb commented on issue #16235:
URL: https://github.com/apache/datafusion/issues/16235#issuecomment-3124297578
Thank you very much @xudong963 and everyone else who helped
I hope to publish the blog tomorrow:
- https://github.com/apache/datafusion-site/pull/91
--
This is an autom
alamb closed issue #16235: Release DataFusion `49.0.0` (July 2025)
URL: https://github.com/apache/datafusion/issues/16235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
alamb opened a new issue, #16235:
URL: https://github.com/apache/datafusion/issues/16235
### Is your feature request related to a problem or challenge?
Tracking ticket for next release, also a place to track desired inclusions
Previous release will be https://crates.io/crates/d
alamb commented on PR #91:
URL: https://github.com/apache/datafusion-site/pull/91#issuecomment-3124298083
I plan to publish this tomorrow (Monday July 28 2025)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
alamb commented on issue #9256:
URL: https://github.com/apache/datafusion/issues/9256#issuecomment-3124310781
> this need re-opening as same issue arise with now liblzma crate
Thanks @rphlo -- can you please open a new ticket with a description of
what problem you are seeing / sympto
codecov-commenter commented on PR #2041:
URL:
https://github.com/apache/datafusion-comet/pull/2041#issuecomment-3124423518
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/2041?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
andygrove commented on PR #2040:
URL:
https://github.com/apache/datafusion-comet/pull/2040#issuecomment-3124756658
I ran TPC-H benchmarks locally and saw no difference in performance compared
to main branch
--
This is an automated message from the Apache Git Service.
To respond to the me
ding-young commented on code in PR #16814:
URL: https://github.com/apache/datafusion/pull/16814#discussion_r2234815857
##
benchmarks/src/bin/mem_profile.rs:
##
@@ -0,0 +1,360 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreem
ding-young commented on code in PR #16814:
URL: https://github.com/apache/datafusion/pull/16814#discussion_r2234818349
##
benchmarks/src/bin/mem_profile.rs:
##
@@ -0,0 +1,360 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreem
ding-young commented on code in PR #16814:
URL: https://github.com/apache/datafusion/pull/16814#discussion_r2234803528
##
benchmarks/src/bin/mem_profile.rs:
##
@@ -0,0 +1,360 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreem
berkaysynnada commented on PR #16893:
URL: https://github.com/apache/datafusion/pull/16893#issuecomment-3125679943
@comphead @xudong963 do you have any time to review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
Standing-Man opened a new pull request, #16936:
URL: https://github.com/apache/datafusion/pull/16936
## Which issue does this PR close?
- Closes #16932.
- Part of #15914.
## Rationale for this change
## What changes are included in this PR?
xudong963 merged PR #16929:
URL: https://github.com/apache/datafusion/pull/16929
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@data
xudong963 commented on PR #16929:
URL: https://github.com/apache/datafusion/pull/16929#issuecomment-3124429502
> Thank you @xudong963 -- is there any chance you can add me (and @andygrove
) as owners of the new `datafusion-pruning` crate as well?
Done, let me if you receive the invita
UBarney commented on code in PR #16889:
URL: https://github.com/apache/datafusion/pull/16889#discussion_r2234007180
##
datafusion/physical-plan/src/joins/nlj.rs:
##
@@ -0,0 +1,803 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license a
UBarney commented on code in PR #16889:
URL: https://github.com/apache/datafusion/pull/16889#discussion_r2234007180
##
datafusion/physical-plan/src/joins/nlj.rs:
##
@@ -0,0 +1,803 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license a
codecov-commenter commented on PR #2042:
URL:
https://github.com/apache/datafusion-comet/pull/2042#issuecomment-3125288427
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/2042?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
Adez017 commented on issue #16935:
URL: https://github.com/apache/datafusion/issues/16935#issuecomment-3125316585
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
zhuqi-lucas commented on issue #16888:
URL: https://github.com/apache/datafusion/issues/16888#issuecomment-3125608299
Thank you @crepererum I can't reproduce this, it may cause "ODER BY k,
time;" this is a typo, need to change to ORDER BY k, time;
Here is the result, it's right.
zhuqi-lucas commented on PR #16925:
URL: https://github.com/apache/datafusion/pull/16925#issuecomment-3124474027
Follow-up, we need to support more sliding distinct Accumulator:
Currently, this PR only support it for count.
--
This is an automated message from the Apache Git Service
alamb merged PR #16878:
URL: https://github.com/apache/datafusion/pull/16878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #16878:
URL: https://github.com/apache/datafusion/pull/16878#issuecomment-3124296643
Thanks again @waynexia
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
alamb commented on PR #16892:
URL: https://github.com/apache/datafusion/pull/16892#issuecomment-3124296290
> is it okay to be merged or we waiting for the test ?
It is ok in my opinion, but let's wait to see if @berkaysynnada has any
thoughts
--
This is an automated message from t
alamb opened a new issue, #16931:
URL: https://github.com/apache/datafusion/issues/16931
### Is your feature request related to a problem or challenge?
- Part of https://github.com/apache/datafusion/issues/14836
### Describe the solution you'd like
Let's tell the world wh
alamb commented on PR #16835:
URL: https://github.com/apache/datafusion/pull/16835#issuecomment-3124414244
Thank you for sticking with this @kosiew
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
alamb commented on PR #16853:
URL: https://github.com/apache/datafusion/pull/16853#issuecomment-3124316731
> Note: I encountered a breaking change in `TableParquetOptions` that I
didn't see mentioned in the upgrade doc. This release added the 'crypto' field.
Added a note
in[aad53a0](
xitep opened a new pull request, #1979:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1979
* Optional support for `:name` as a parameters in queries; initially
requested through #291
* The naming convention chosen here is based on the java persistence api
spec
(https://ja
alamb commented on PR #16790:
URL: https://github.com/apache/datafusion/pull/16790#issuecomment-3124295698
Issue filed
- https://github.com/apache/datafusion/issues/16894
Thanks @adriangb and @akoshchiy
--
This is an automated message from the Apache Git Service.
To respond to t
alamb merged PR #16790:
URL: https://github.com/apache/datafusion/pull/16790
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb closed issue #16695: Unnested fields are not filterable when using
subqueries.
URL: https://github.com/apache/datafusion/issues/16695
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
kazantsev-maksim opened a new pull request, #2041:
URL: https://github.com/apache/datafusion-comet/pull/2041
## Which issue does this PR close?
Part of https://github.com/apache/datafusion-comet/issues/1819
## Rationale for this change
See https://github.com/apache/datafu
alamb commented on code in PR #16835:
URL: https://github.com/apache/datafusion/pull/16835#discussion_r2233904145
##
datafusion/core/tests/schema_adapter_integration.rs:
##
@@ -0,0 +1,21 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
I thin
andygrove opened a new pull request, #2042:
URL: https://github.com/apache/datafusion-comet/pull/2042
## Which issue does this PR close?
Following on from https://github.com/apache/datafusion-comet/pull/2025, this
PR adds scripts for running the TPC-DS benchmarks.
## Ra
niebayes opened a new issue, #16935:
URL: https://github.com/apache/datafusion/issues/16935
I recently found that DataFusion supports the Recursive CTE feature in
standard SQL. But it lacks of docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
gabotechs commented on PR #16793:
URL: https://github.com/apache/datafusion/pull/16793#issuecomment-3125658277
> or is
https://github.com/apache/datafusion/pull/16793#pullrequestreview-3032328344
suggesting changes for a future PR?
I think those changes will need to happen either in
berkaysynnada commented on code in PR #16905:
URL: https://github.com/apache/datafusion/pull/16905#discussion_r2234793079
##
datafusion/core/src/physical_planner.rs:
##
@@ -886,6 +887,26 @@ impl DefaultPhysicalPlanner {
"SortExec requires at least one so
berkaysynnada merged PR #16892:
URL: https://github.com/apache/datafusion/pull/16892
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
berkaysynnada commented on PR #16892:
URL: https://github.com/apache/datafusion/pull/16892#issuecomment-3125673259
We don't want to risk discovering a feature breakage later in downstream
projects but let's merge this now. Once I'm able to reproduce the case, I'll
open a follow-up PR with t
Standing-Man opened a new issue, #16932:
URL: https://github.com/apache/datafusion/issues/16932
### Is your feature request related to a problem or challenge?
Is your feature request related to a problem or challenge?
Part of #15914.
Given the importance of [Apache
Spark](https:
Standing-Man commented on issue #16932:
URL: https://github.com/apache/datafusion/issues/16932#issuecomment-3124353831
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
akupchinskiy commented on code in PR #2037:
URL: https://github.com/apache/datafusion-comet/pull/2037#discussion_r2234113921
##
spark/src/main/scala/org/apache/comet/serde/nondetermenistic.scala:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
akupchinskiy commented on issue #2036:
URL:
https://github.com/apache/datafusion-comet/issues/2036#issuecomment-3124694956
Btw, [this
test](https://github.com/apache/datafusion-comet/blob/main/spark/src/test/scala/org/apache/comet/CometArrayExpressionSuite.scala#L358C1)
is supposed to chec
0xPoe commented on issue #15873:
URL: https://github.com/apache/datafusion/issues/15873#issuecomment-3124700368
I'm working on the HashJoinExec one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
xudong963 commented on issue #15873:
URL: https://github.com/apache/datafusion/issues/15873#issuecomment-3124917655
> I'm working on the HashJoinExec one.
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
github-actions[bot] closed pull request #1842: fix: allow arbitrary operators
with ANY and ALL on Postgres
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1842
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
ding-young commented on code in PR #16814:
URL: https://github.com/apache/datafusion/pull/16814#discussion_r2234397012
##
benchmarks/src/util/memory.rs:
##
@@ -0,0 +1,54 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
ding-young commented on code in PR #16814:
URL: https://github.com/apache/datafusion/pull/16814#discussion_r2234398080
##
benchmarks/README.md:
##
@@ -321,6 +322,64 @@ FLAGS:
...
```
+# Profiling Memory Stats for each benchmark query
+The `mem_profile` program wraps benchmar
alamb commented on PR #16853:
URL: https://github.com/apache/datafusion/pull/16853#issuecomment-3124415720
Thanks everyone -- I merged this one in now that we hare released 49.0.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
alamb commented on PR #16925:
URL: https://github.com/apache/datafusion/pull/16925#issuecomment-3124416630
FYI @crepererum
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
alamb merged PR #16853:
URL: https://github.com/apache/datafusion/pull/16853
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
Adez017 commented on issue #16931:
URL: https://github.com/apache/datafusion/issues/16931#issuecomment-3124418257
hey @alamb i can do pair with you or someone , it will be great pleasure
working on it
--
This is an automated message from the Apache Git Service.
To respond to the message,
alamb commented on PR #16924:
URL: https://github.com/apache/datafusion/pull/16924#issuecomment-3124419443
Thank you for driving this @chenkovsky
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
haohuaijin opened a new pull request, #16933:
URL: https://github.com/apache/datafusion/pull/16933
## Which issue does this PR close?
Closes #15485
## Rationale for this change
see https://github.com/apache/datafusion/issues/15485, support `qualify` can
filter wi
delamarch3 opened a new pull request, #16934:
URL: https://github.com/apache/datafusion/pull/16934
## Which issue does this PR close?
- Closes #.
## Rationale for this change
## What changes are included in this PR?
## Are these changes test
69 matches
Mail list logo
