Re: [Github-comments] [geany/geany] Show zoom level in document tab label. (#1697)

2017-11-23 Thread elextr
I don't mind it being a status bar option which would be in core, not a plugin, but don't want any more tab space used, tabs don't fit already. So if it continues to modify the tabs then its gotta be in a plugin. > how can a plugin get the zoom notification?

Re: [Github-comments] [geany/geany] Show zoom level in document tab label. (#1697)

2017-11-23 Thread LarsGit223
Well, I think it is not that intrusive as it only would be displayed temporarily and disappears as soon as the zoom level gets back to normal size. Two questions: - @codebrainz @elextr @b4n Do you all agree to better put it in a plugin? - how can a plugin get the zoom notification? -- You are

Re: [Github-comments] [geany/geany] Question: what are the zoom callback functions? (#1696)

2017-11-23 Thread LarsGit223
@elextr @b4n Thanks for the answers (Anyway strange that the dialog did not pop up when using keybindings). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1696#issuecomment-346750492

Re: [Github-comments] [geany/geany-plugins] [geanylua] geany.scintilla() does not work with SCI_SETLEXER (#646)

2017-11-23 Thread Skif-off
@codebrainz maybe you'll make a PR? As part of the development team :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/646#issuecomment-346721257

Re: [Github-comments] [geany/geany] Show zoom level in document tab label. (#1697)

2017-11-23 Thread Colomban Wendling
b4n requested changes on this pull request. I agree with @codebrainz and @elextr that the info should probably be somewhere less intrusive than the tab label, and would also think first thing about the status bar. > @@ -322,6 +322,10 @@ void sci_zoom_off(ScintillaObject *sci) SSM(sci,

Re: [Github-comments] [geany/geany] Question: what are the zoom callback functions? (#1696)

2017-11-23 Thread Colomban Wendling
Closed #1696. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1696#event-1356433173

Re: [Github-comments] [geany/geany] Show zoom level in document tab label. (#1697)

2017-11-23 Thread Matthew Brush
I'm personally not a big fan of having this extra information in the precious tab space. It probably wouldn't be as bad in the status bar (it sort of fits with that information) and it could be turned on/off by the user customizing the statusbar template. This could also be implemented in a

Re: [Github-comments] [geany/geany] Theme improvements (#1382)

2017-11-23 Thread LarsGit223
I guess the milestone should be upped here (and for various other open 1.31 PRs). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1382#issuecomment-346700958

[Github-comments] [geany/geany] Show zoom level in document tab label. (#1697)

2017-11-23 Thread LarsGit223
Display the zoom level in percent in the document tab label. If the zoom level is changed back to normal size then it will not be shown. If a user just quickly wants to zoom in and back out then showing the zoom level helps to go back to the normal size without the need of using a keybinding or

Re: [Github-comments] [geany/geany] Question: what are the zoom callback functions? (#1696)

2017-11-23 Thread LarsGit223
I guess it will be handled by a scintilla keybinding maybe. Anyway, I searched for a place to catch "zoom events" and the best place seems to be ```on_editor_notify```, at [this line](https://github.com/geany/geany/blob/master/src/editor.c#L1189). -- You are receiving this because you are

Re: [Github-comments] [geany/geany] Question: what are the zoom callback functions? (#1696)

2017-11-23 Thread LarsGit223
@elextr: Are you sure about the keybindings? I also thought it is going to be handled there. But I changed my zoom functions like this for testing: ``` /* zoom out from menu bar and popup menu */ void on_zoom_out1_activate(GtkMenuItem *menuitem, gpointer user_data) { GeanyDocument *doc =

Re: [Github-comments] [geany/geany-plugins] [geanylua] geany.scintilla() does not work with SCI_SETLEXER (#646)

2017-11-23 Thread Matthew Brush
Something like this: ```diff diff --git a/configure.ac b/configure.ac index 7fb7d402..fa3bf5a2 100644 --- a/configure.ac +++ b/configure.ac @@ -9,6 +9,7 @@ AC_CONFIG_SRCDIR([po/POTFILES.in]) AC_CONFIG_HEADERS([config.h]) AC_CONFIG_MACRO_DIR([build/cache]) +AC_USE_SYSTEM_EXTENSIONS AC_PROG_CC

Re: [Github-comments] [geany/geany-plugins] [geanylua] geany.scintilla() does not work with SCI_SETLEXER (#646)

2017-11-23 Thread Matthew Brush
@Skif-off yeah, I saw that warning, but it's just a deprecation warning. Proper fix would be for GeanyLua to use build system to check for `stat()`/`lstat()` and let autotools handle defining such macros as needed for the proper versions, IMO. -- You are receiving this because you are

Re: [Github-comments] [geany/geany-plugins] [geanylua] geany.scintilla() does not work with SCI_SETLEXER (#646)

2017-11-23 Thread Skif-off
@codebrainz Yes, both variant works fine. Only one warning: ``` CC libgeanylua_la-glspi_app.lo In file included from /usr/include/x86_64-linux-gnu/sys/stat.h:25:0, from glspi_app.c:8: /usr/include/features.h:183:3: warning: #warning "_BSD_SOURCE and _SVID_SOURCE are

Re: [Github-comments] [geany/geany-plugins] [geanylua] geany.scintilla() does not work with SCI_SETLEXER (#646)

2017-11-23 Thread Matthew Brush
This also works: ```diff diff --git a/geanylua/glspi_app.c b/geanylua/glspi_app.c index ed82d5eb..23818170 100644 --- a/geanylua/glspi_app.c +++ b/geanylua/glspi_app.c @@ -418,11 +418,11 @@ static gint glspi_launch(lua_State* L) gchar **argv=NULL; gboolean rv; GError

Re: [Github-comments] [geany/geany-plugins] [geanylua] geany.scintilla() does not work with SCI_SETLEXER (#646)

2017-11-23 Thread Matthew Brush
@Skif-off try this: ```c argv=g_malloc0_n(argc + 1u, sizeof(gchar *)); ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/646#issuecomment-346596722

Re: [Github-comments] [geany/geany] Add AutoIt (*.au3) Lexer to Geany (#967)

2017-11-23 Thread Skif-off
AutoIt parser was added to Сtags, PR [#1017](https://github.com/geany/geany/pull/1017) was updated. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/967#issuecomment-346593576

Re: [Github-comments] [geany/geany] Add AutoIt syntax highlighting (#1017)

2017-11-23 Thread Skif-off
It seems I did everything I could - highlighting, autocompletion and Symbols tab, - big thanks to everyone who helped to understanded and do it :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany-plugins] [geanylua] geany.scintilla() does not work with SCI_SETLEXER (#646)

2017-11-23 Thread elextr
or set option `-Wno-alloc-size-larger-than` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/646#issuecomment-346592130

Re: [Github-comments] [geany/geany-plugins] [geanylua] geany.scintilla() does not work with SCI_SETLEXER (#646)

2017-11-23 Thread Skif-off
Maybe I'd better use gcc-6 (6.4.0) or gcc-5 (5.5.0)? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/646#issuecomment-346591446

Re: [Github-comments] [geany/geany-plugins] [geanylua] geany.scintilla() does not work with SCI_SETLEXER (#646)

2017-11-23 Thread Skif-off
I tried ```argv = g_malloc0_n(argc+1, sizeof(gchar*));``` and I have: ``` glspi_app.c: In function ‘glspi_launch’: glspi_app.c:425:7: warning: argument 1 range [18446744071562067969, 18446744073709551615] exceeds maximum object size 9223372036854775807 [-Walloc-size-larger-than=] argv =