Re: [Github-comments] [geany/geany] README.rst:grammer fix (missing word) (#2047)

2019-01-14 Thread elextr
Merged #2047 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2047#event-2073847386

Re: [Github-comments] [geany/geany] README.rst:grammer fix (missing word) (#2047)

2019-01-14 Thread elextr
@b4n what I mean is that even if it did run we can't see the manual, I guess it does check rst2html doesn't object too much, but we have no way of checking it looks right from CI. IIUC Travis artefact uploading isn't available on PR builds, so we have to wait until after merge when the nightly

Re: [Github-comments] [geany/geany] README.rst:grammer fix (missing word) (#2047)

2019-01-14 Thread Colomban Wendling
@elextr I guess if Travis didn't run it's because of the `[skip ci]` annotations in the commit messages ;) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2047#issuecomment-454284566

Re: [Github-comments] [geany/geany] README.rst:grammer fix (missing word) (#2047)

2019-01-14 Thread Colomban Wendling
b4n approved this pull request. LGBI. Could use squashing when merging. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2047#pullrequestreview-192503049

Re: [Github-comments] [geany/geany] Sync ctags with upstream so that most parsers can be copied from uctags (#2018)

2019-01-14 Thread elextr
> @elextr Since you like finding all the possible cases where the current C > parser fails, would you give it a try? @techee ahh, no, not until this gets committed, _then_ you can make a PR to use the new C++ parser instead of the one in c.c. After all once this is committed we will need

Re: [Github-comments] [geany/geany] Sync ctags with upstream so that most parsers can be copied from uctags (#2018)

2019-01-14 Thread Jiří Techet
@b4n I hope I addressed all the minor problems (apart from the missing parsers) - let me know if I forgot about something. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany] Sync ctags with upstream so that most parsers can be copied from uctags (#2018)

2019-01-14 Thread Jiří Techet
techee commented on this pull request. > @@ -1,124 +0,0 @@ -/* I didn't know either of them, I just searched for "ABC language" and this one appeared. The parser is now back together with a unit test. -- You are receiving this because you are subscribed to this thread. Reply to this email

Re: [Github-comments] [geany/geany] README.rst:grammer fix (missing word) (#2047)

2019-01-14 Thread elextr
LGBI, sadly Travis doesn't build the manuals AFAICK. I guess as soon as @b4n indicates he still approves it can be merged and the nightly [manual build](https://www.geany.org/manual/dev/index.html) will check it. -- You are receiving this because you are subscribed to this thread. Reply to

Re: [Github-comments] [geany/geany] README.rst:grammer fix (missing word) (#2047)

2019-01-14 Thread Andy Alt
@andy5995 pushed 1 commit. 88c38c594dba902b1973a18202f0836c510f1db7 combine sentences -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [Github-comments] [geany/geany] request feature : be able to change visualisation of tab for currently opened file (#2046)

2019-01-14 Thread elextr
And the information I requested will tell you if you are using GTK2 or GTK3. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2046#issuecomment-454167143

Re: [Github-comments] [geany/geany] README.rst:grammer fix (missing word) (#2047)

2019-01-14 Thread elextr
@b4n, ok, I missed the "are" that wasn't there (its "are a few" not "is a few" because the "are" refers to the multiple "few", not the singular "a", damn English) :grin: I was checking if @andy5995 left something out because this doesn't sound right, "several" implies a low number. Now that

Re: [Github-comments] [geany/geany] README.rst:grammer fix (missing word) (#2047)

2019-01-14 Thread Colomban Wendling
@elextr The sentence was *"There a few command line options."*. I'd agree with @andy5995 that there's at least a missing *is*, and that the reformulation is better as well. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany] Problem with installing compiled geany (#2044)

2019-01-14 Thread elextr
@CheckB I said show __the command you used__, checkinstall has many options, its important to know what you actually ran. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany] README.rst:grammer fix (missing word) (#2047)

2019-01-14 Thread elextr
@andy5995 but what word did you find missing? Your committ only makes a change, did you miss something? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2047#issuecomment-454145228

Re: [Github-comments] [geany/geany] Sync ctags with upstream so that most parsers can be copied from uctags (#2018)

2019-01-14 Thread elextr
> > Hehe smile I gave COBOL a little try, but it now it seems a lot more of a > > nightmare to do it right (from what I gathered, not only the official > > syntax uses a pretty random notation, but it also seem close to impossible > > to parse without knowing every single bit of it -- e.g. it's

Re: [Github-comments] [geany/geany] Sync ctags with upstream so that most parsers can be copied from uctags (#2018)

2019-01-14 Thread Jiří Techet
> Hehe  I gave COBOL a little try, but it now it seems a lot more of a > nightmare to do it right (from what I gathered, not only the official syntax > uses a pretty random notation, but it also seem close to impossible to parse > without knowing every single bit of it -- e.g. it's not easy to

Re: [Github-comments] [geany/geany] on OpenBSD 6.4, "don't know how to make geany.desktop" (#2049)

2019-01-14 Thread Colomban Wendling
Looks like the Intltool rule for generating Desktop files is not portable across Make implementations, it seems to be using GNU make `%` rules… @andy5995 did you run autogen.sh, or did you use a tarball with a pre-generated configure? If you didn't run autogen, maybe try it as I could hope

Re: [Github-comments] [geany/geany] README.rst:grammer fix (missing word) (#2047)

2019-01-14 Thread Colomban Wendling
b4n approved this pull request. LGTM -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2047#pullrequestreview-192320221

Re: [Github-comments] [geany/geany] Sync ctags with upstream so that most parsers can be copied from uctags (#2018)

2019-01-14 Thread Colomban Wendling
> @b4n you said something like it would be fun rewriting those - I would really > hate myself for stealing the fun from you :-) Hehe :smile: I gave COBOL a little try, but it now it seems a lot more of a nightmare to do it right (from what I gathered, not only the official syntax uses a pretty

Re: [Github-comments] [geany/geany] Sync ctags with upstream so that most parsers can be copied from uctags (#2018)

2019-01-14 Thread Jiří Techet
> So can't we just make it a shallow shim over glib instead of including the > ctags one? Probably we could make some wrapper around it but there are minor semantic differences between the APIs which are easy to miss and which we probably won't notice in the future when something in upstream

Re: [Github-comments] [geany/geany] request feature : be able to change visualisation of tab for currently opened file (#2046)

2019-01-14 Thread Colomban Wendling
@piscvau https://www.geany.org/manual/#customizing-geany-s-appearance-using-gtk-3-css should help you, you can define yourself how they should look. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany] Sync ctags with upstream so that most parsers can be copied from uctags (#2018)

2019-01-14 Thread Colomban Wendling
b4n commented on this pull request. > @@ -1,124 +0,0 @@ -/* Oh, I didn't know that other one :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2018#discussion_r247617289

Re: [Github-comments] [geany/geany] Sync ctags with upstream so that most parsers can be copied from uctags (#2018)

2019-01-14 Thread Colomban Wendling
b4n commented on this pull request. > { - const kindOption *kindOpt; - - if (hasRegexKind (language, kind)) - return isRegexKindEnabled (language, kind); - else if (hasXcmdKind (language, kind)) - return isXcmdKindEnabled (language, kind); Ah OK

Re: [Github-comments] [geany/geany] Sync ctags with upstream so that most parsers can be copied from uctags (#2018)

2019-01-14 Thread Colomban Wendling
b4n commented on this pull request. > @@ -2742,8 +2793,12 @@ extern void anonGenerate (vString *buffer, const char > *prefix, int kind) vStringCopyS(buffer, prefix); - unsigned int uHash = anonHash((const unsigned char *)getInputFileName()); -

Re: [Github-comments] [geany/geany] Sync ctags with upstream so that most parsers can be copied from uctags (#2018)

2019-01-14 Thread Jiří Techet
techee commented on this pull request. > { - const kindOption *kindOpt; - - if (hasRegexKind (language, kind)) - return isRegexKindEnabled (language, kind); - else if (hasXcmdKind (language, kind)) - return isXcmdKindEnabled (language, kind); The

Re: [Github-comments] [geany/geany] Sync ctags with upstream so that most parsers can be copied from uctags (#2018)

2019-01-14 Thread Jiří Techet
techee commented on this pull request. > @@ -2742,8 +2793,12 @@ extern void anonGenerate (vString *buffer, const char > *prefix, int kind) vStringCopyS(buffer, prefix); - unsigned int uHash = anonHash((const unsigned char *)getInputFileName()); -

Re: [Github-comments] [geany/geany] Sync ctags with upstream so that most parsers can be copied from uctags (#2018)

2019-01-14 Thread Jiří Techet
techee commented on this pull request. > @@ -1,124 +0,0 @@ -/* Oh, that ABC! I thought it was [this ABC](https://en.wikipedia.org/wiki/ABC_(programming_language)) and looking for "T" at the beginning of a line made absolutely no sense. So yeah, it's a pretty esoteric language and the parser

Re: [Github-comments] [geany/geany] Problem with installing compiled geany (#2044)

2019-01-14 Thread CheckB
@elextr Compile using checkinstall. checkinstall builds .deb and installs it. Accordingly, after installation, the message appears... Although all packages are installed -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany] On OpenBSD 6.4, rst2html not detected when running configure (#2048)

2019-01-14 Thread Andy Alt
Closed #2048. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2048#event-2071881846

Re: [Github-comments] [geany/geany] On OpenBSD 6.4, rst2html not detected when running configure (#2048)

2019-01-14 Thread Andy Alt
False report. I didn't install the docutils package properly. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2048#issuecomment-454020241

[Github-comments] [geany/geany] on OpenBSD 6.4, "don't know how to make geany.desktop" (#2049)

2019-01-14 Thread Andy Alt
config.log attached ``` andy:18$ make make all-recursive Making all in ctags Making all in scintilla Making all in include Making all in src Making all in tagmanager Making all in plugins Making all in icons Making all in 16x16 Making all in 24x24 Making all in 32x32 Making all in

[Github-comments] [geany/geany] On OpenBSD 6.4, rst2html not detected when running configure (#2048)

2019-01-14 Thread Andy Alt
I installed py-docutils and py3-docutils but on OpenBSD 6.4, rst2html not detected when running configure -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2048

[Github-comments] [geany/geany] README.rst:grammer fix (missing word) (#2047)

2019-01-14 Thread Andy Alt
I replaced a missing word and suggested a minor change [skip ci] You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/2047 -- Commit Summary -- * README.rst:grammer fix (missing word) -- File Changes -- M README (2) -- Patch Links --

Re: [Github-comments] [geany/geany] Replacing two spaces with single space in document makes geany stop responding (#1964)

2019-01-14 Thread Andy Alt
I couldn't reproduce either, using Geany 1.35 (git >= 4452b365) (built on 2019-01-02 with GTK 2.24.31, GLib 2.50.3) (Debian Stretch) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany] request feature : be able to change visualisation of tab for currently opened file (#2046)

2019-01-14 Thread elextr
Need more info, please post the first three lines of `Menu->Help->Debug Messages` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2046#issuecomment-453960951

Re: [Github-comments] [geany/geany] Problem with installing compiled geany (#2044)

2019-01-14 Thread CheckB
@LarsGit223 The problem is the same. geany still requires: `` ` dpkg: dependency configuration of geany: geany depends on glib2; however: Package glib2 is not installed. geany depends on gtk2; however: Package gtk2 is not installed. geany depends on pango; however: Package pango is