Re: [Github-comments] [geany/geany] Wrong cursor position when selecting text (#1442)

2019-06-29 Thread elextr
Ok, Geany still uses the LTS branch, so it will get picked up after that happens. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1442#issuecomment-507005015

Re: [Github-comments] [geany/geany] Wrong cursor position when selecting text (#1442)

2019-06-29 Thread Zufu Liu
@elextr not at the moment, but I think I will backported later. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1442#issuecomment-507003406

Re: [Github-comments] [geany/geany] Wrong cursor position when selecting text (#1442)

2019-06-29 Thread elextr
@zufuliu was it backported to the long term 3 branch? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1442#issuecomment-507001870

Re: [Github-comments] [geany/geany] Wrong cursor position when selecting text (#1442)

2019-06-29 Thread Zufu Liu
https://sourceforge.net/p/scintilla/bugs/1924/ was fixed in Scintilla 4.1.8. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1442#issuecomment-507001503

Re: [Github-comments] [geany/geany] Native Emacs style caret moving keybindings (#2193)

2019-06-29 Thread Iván Ávalos
Well, now I think this is irrelevant. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2193#issuecomment-506990474

Re: [Github-comments] [geany/geany] Native Emacs style caret moving keybindings (#2193)

2019-06-29 Thread Iván Ávalos
Closed #2193. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2193#event-2449139894

Re: [Github-comments] [geany/www.geany.org] Add Geany-Themes page with theme preview (#8)

2019-06-29 Thread Matthew Brush
codebrainz approved this pull request. LGTM -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/www.geany.org/pull/8#pullrequestreview-256043108

Re: [Github-comments] [geany/geany-themes] Change thumbnail size in the index to 128x128 pixels (#32)

2019-06-29 Thread Matthew Brush
Merged #32 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-themes/pull/32#event-2449010903

Re: [Github-comments] [geany/geany-plugins] spellcheck - use 2 languages at the same time (#876)

2019-06-29 Thread toxpal
Thanks for the input. Yeah, I somehow had a bad feeling it might be very complex :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/876#issuecomment-506961695

Re: [Github-comments] [geany/geany] Plugin Manager: Help button not working on gtk3 (#2151)

2019-06-29 Thread LarsGit223
Seemed to be a local problem, closing this. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2151#issuecomment-506958451

Re: [Github-comments] [geany/geany] Plugin Manager: Help button not working on gtk3 (#2151)

2019-06-29 Thread LarsGit223
Closed #2151. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2151#event-2448943253

[Github-comments] [geany/geany] File with newline in name cannot be opened (#2207)

2019-06-29 Thread
When I create a file with a newline character and open it with geany, it splits the file name with this character as delimiter and tries to open the files with these substrings. For example, create the l\nl file: ```bash touch $'l\nl' ``` Then open it with geany and see two open files with name

Re: [Github-comments] [geany/geany-plugins] lineoperations: fixed -Werror=aggregate-return (#517)

2019-06-29 Thread LarsGit223
LGBI -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/517#issuecomment-506953085

Re: [Github-comments] [geany/geany-plugins] spellcheck - use 2 languages at the same time (#876)

2019-06-29 Thread Enrico Tröger
Nice feature. But it would require quite a lot refactoring of the code and implementing the logic to query two dictionaries and merge the results (Claws actually does this). I won't work on this myself. I guess implementing this would be rather a rewrite of the existing plugin. -- You are

Re: [Github-comments] [geany/www.geany.org] Add "CC BY-SA" notice to footer (#12)

2019-06-29 Thread elextr
LGTM -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/www.geany.org/pull/12#issuecomment-506949838

Re: [Github-comments] [geany/www.geany.org] License (#6)

2019-06-29 Thread Enrico Tröger
Yeah, I used just "the Geany contributors" as we did in Geany itself. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/www.geany.org/issues/6#issuecomment-506949731

Re: [Github-comments] [geany/www.geany.org] Add "CC BY-SA" notice to footer (#12)

2019-06-29 Thread Enrico Tröger
@eht16 pushed 1 commit. 05e217608e9a5f895b2cbd4610744124a87b9dd9 Footer: Replace "development team" by "contributors" and change order -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [Github-comments] [geany/www.geany.org] License (#6)

2019-06-29 Thread elextr
Well, I personally would have put the license after the copyright holders `Contents copyright 2019, the Geany development team, Licensed under CC-BY-SA` since the license doesn't hold the copyright. And that brings up the point that it should be `Geany development team and contributors` if the

Re: [Github-comments] [geany/geany] NSIS upgrade to 3.x (#2181)

2019-06-29 Thread Enrico Tröger
eht16 commented on this pull request. > +set -e + +TOKENS_CPP_FILE="/tmp/nsis_tokens.cpp" +TOKENS_CPP_URL="https://raw.githubusercontent.com/kichik/nsis/master/Source/tokens.cpp; +BUILD_CPP_FILE="/tmp/nsis_build.cpp"

Re: [Github-comments] [geany/geany] NSIS upgrade to 3.x (#2181)

2019-06-29 Thread Enrico Tröger
@eht16 pushed 1 commit. 81c370e83b77fb4e45609569731dc1a5e6125033 Combine 'tr' transformations into one command -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [Github-comments] [geany/www.geany.org] License (#6)

2019-06-29 Thread Enrico Tröger
Like this? https://github.com/geany/www.geany.org/pull/12 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/www.geany.org/issues/6#issuecomment-506948807

[Github-comments] [geany/www.geany.org] Add "CC BY-SA" notice to footer (#12)

2019-06-29 Thread Enrico Tröger
![website_license](https://user-images.githubusercontent.com/617017/60383212-a3aa6500-9a5d-11e9-8a63-7763ca1e67f6.png) Closes #6. You can view, comment on, or merge this pull request online at: https://github.com/geany/www.geany.org/pull/12 -- Commit Summary -- * Add "CC BY-SA" notice to

Re: [Github-comments] [geany/www.geany.org] About Geany page recommends people to contact team@ (#10)

2019-06-29 Thread Enrico Tröger
Closed #10 via 0b724996c1898c83e36ab4d15b582668b0ac25b7. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/www.geany.org/issues/10#event-2448876505

Re: [Github-comments] [geany/www.geany.org] templates/home.html:correct spelling of "hobbyists" (#11)

2019-06-29 Thread Enrico Tröger
Merged #11 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/www.geany.org/pull/11#event-2448871842

Re: [Github-comments] [geany/www.geany.org] templates/home.html:correct spelling of "hobbyists" (#11)

2019-06-29 Thread Enrico Tröger
Thanks. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/www.geany.org/pull/11#issuecomment-506946857

Re: [Github-comments] [geany/geany-themes] Add preview to the screenshot folder (for #29) (#30)

2019-06-29 Thread Enrico Tröger
I completely agree. The preview page on the website and the preview in the README here do not compete at all. It's perfectly fine to have both. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/www.geany.org] Update to Bootstrap 4 (#9)

2019-06-29 Thread Enrico Tröger
Closed #9. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/www.geany.org/issues/9#event-2448870762

Re: [Github-comments] [geany/www.geany.org] Update to Bootstrap 4 (#9)

2019-06-29 Thread Enrico Tröger
Pull requests are welcome. Otherwise this is not a priority. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/www.geany.org/issues/9#issuecomment-506946649

Re: [Github-comments] [geany/geany-themes] Change thumbnail size in the index to 128x128 pixels (#32)

2019-06-29 Thread Enrico Tröger
eht16 approved this pull request. Great! The preview page on the website looks much nicer with the larger thumbnails. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/www.geany.org] Add Geany-Themes page with theme preview (#8)

2019-06-29 Thread Enrico Tröger
> @eht16 there's also a link to Geany-Themes Github repo under "Easily > Customizable" section on the home page which I guess should probably link > instead to the new themes page. Link updated, thanks for the pointer. And here is a screenshot with the larger thumbnails of

Re: [Github-comments] [geany/www.geany.org] Add Geany-Themes page with theme preview (#8)

2019-06-29 Thread Enrico Tröger
eht16 commented on this pull request. > +class ThemesView(StaticDocsView): +""" +Fetch the Geany-Themes index from https://github.com/geany/geany-themes/tree/master/index +""" + +template_name = "pages/download/themes.html" + +#

Re: [Github-comments] [geany/www.geany.org] Add Geany-Themes page with theme preview (#8)

2019-06-29 Thread Enrico Tröger
@eht16 pushed 1 commit. c6f4436ca108ebc32b87a028efe690d49bda7f5b Homepage: Change themes link to the preview page -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [Github-comments] [geany/www.geany.org] Add Geany-Themes page with theme preview (#8)

2019-06-29 Thread Enrico Tröger
@eht16 pushed 2 commits. c5a12415d902bdcb5d66538a885e1ca90ea52d88 Theme preview: Refetch theme index only if MD5 hash has changed 6a0317bba2727d909c84f25f9da74d251168c224 Log request duration of Github API calls -- You are receiving this because you are subscribed to this thread. View it