> unless we give it higher priority, which we probably shouldn't as it wouldn't
> be semantic.
Depends how you look at it, it's not like it's just Geany trying to force
application default styles on a user, rather it's providing the _USER_ a GUI to
_OVERRIDE_ the theme font, so priority higher
It can probably be closed. GTK+3 build is the default in most major distros and
since @b4n fixed it, it's also the default on any system that doesn't have
GTK+2 development headers installed. The only place it's not default is on
non-Linux or olden Linux.
--
You are receiving this because you
@b4n I suppose that if the _user_ has the css file then yeah, its reasonable to
assume they intended it and know how to put Geany specific overrides in that.
But its confusing if the GUI selection works if there is no user GTK override
and not in other cases.
Perhaps the GUI selection should
@LarsGit223 The thing is that *~/.config/gtk-3.0/gtk.css* has the highest
priority possible -- user priority. It's actually pretty much the right thing
to do to let this win.
In our specific case where it's a user setting, it could be arguable that we
should give it user priority, and then it
Nobody else seems to have tested it yet.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2178#issuecomment-513952420
@elextr: I agree, but the sentence _"This function is not useful in the context
of CSS-based rendering."_ sounds critical to me. If I find the time I will do
some tests with applying a CSS style instaed of calling
```gtk_widget_modify_font()```.
--
You are receiving this because you are
Not until @b4n makes GTK3 the default :grin:
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/452#issuecomment-513951039
@LarsGit223 deprecation shouldn't mean it doesn't work, unless GTK have
forgotten their promise to not break stuff until the NEXT release.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
I have read the documentation of ```gtk_widget_modify_font()``` which is used
in ```ui_widget_modify_font_from_string()```. The function is deprecated and
the gtk documentation suggest to use ```gtk_widget_override_font()```. But that
also has a deprecation remark:
> gtk_widget_override_font
@elextr, @codebrainz, @b4n: can this be closed?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/452#issuecomment-513916121
ntrel commented on this pull request.
> @@ -383,6 +381,10 @@ GeanyDocument *document_get_current(void)
void document_init_doclist(void)
{
documents_array = g_ptr_array_new();
+#ifdef GEANY_DEBUG
+ // add a dummy invalid document to catch naive iteration
+
ntrel commented on this pull request.
> @@ -383,6 +381,10 @@ GeanyDocument *document_get_current(void)
void document_init_doclist(void)
{
documents_array = g_ptr_array_new();
+#ifdef GEANY_DEBUG
+ // add a dummy invalid document to catch naive iteration
+
I plan to merge this unless there's a good reason not to - see my comments.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2178#issuecomment-513759472
Merged #2176 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2176#event-2499546575
Merged #2186 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2186#event-2499544173
Closed #1581 via #2186.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1581#event-2499544180
Closed #1499 via #2167.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1499#event-2499542443
Closed #1921 via #2167.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1921#event-2499542438
Merged #2167 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2167#event-2499542431
19 matches
Mail list logo
