Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

2019-10-06 Thread Thomas Martitz
@b4n your review is still pending. Please have a look again. I would like to merge this early in the cycle. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1813#issuecomment-538851090

Re: [Github-comments] [geany/geany] Objective-C files always detected as Matlab/Octave (#2341)

2019-10-06 Thread elextr
Because a user can manually set a filetype nothing will change it whilst the file is part of a session otherwise it would overwrite the user setting. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/g

Re: [Github-comments] [geany/geany] Objective-C files always detected as Matlab/Octave (#2341)

2019-10-06 Thread Will Brokenbourgh
Closed #2341. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2341#event-2690535618

Re: [Github-comments] [geany/geany] Objective-C files always detected as Matlab/Octave (#2341)

2019-10-06 Thread Will Brokenbourgh
I did do 'File->Reload' but that didn't fix it. I did try closing it right now, then reopening it, and it did detect it properly. Thanks for the help! 👍 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/g

Re: [Github-comments] [geany/geany] Objective-C files always detected as Matlab/Octave (#2341)

2019-10-06 Thread elextr
Did you close the files and re-open them? Filetypes are only detected when the file is first opened. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2341#issuecomment-538842689

[Github-comments] [geany/geany] Objective-C files always detected as Matlab/Octave (#2341)

2019-10-06 Thread Will Brokenbourgh
I have copied the system `filetype_extensions.conf` to the `~/.config/geany` directory and changed Matlab/Octave's file extension definition to `*.matlab` from `*.m` but Geany is still detecting `*.m` files as Matlab/Octave. I did the 'Reload configuration' menu item and even quit Geany, then l

Re: [Github-comments] [geany/geany-plugins] Overview: initialize color variables (#916)

2019-10-06 Thread Matthew Brush
> it's actually technically correct to say the value may not be initialized > because of those checks Depending on whether they're actually enabled, of course. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.

Re: [Github-comments] [geany/geany-plugins] debugger (#758)

2019-10-06 Thread elextr
WFM, Linux Mint 19.1 == Ubuntu 18.04 LTS IIRC. Geany 1.37 (git >= 82590af4), en_AU.UTF-8 GTK 3.22.30, GLib 2.56.4 and Geany-plugins at https://github.com/geany/geany-plugins/commit/c156641259643ef4e32d067dd0b346e558a1a973. @Nefor111 we are not responsible for the Arch packaging, ask there. For

Re: [Github-comments] [geany/geany-plugins] Overview: initialize color variables (#916)

2019-10-06 Thread Colomban Wendling
> 2. and if it did, the return_ifs can shortcut return and leave it > uninitialised. @elextr got a point, it's actually technically correct to say the value may not be initialized because of those checks, and it seem impossible for a tool to infer that those checks will succeed, even if we know

Re: [Github-comments] [geany/geany] Show zoom in status bar (use specifier %z). (#2339)

2019-10-06 Thread Colomban Wendling
Ideally you'd push again to the original `showzoom` branch so that we have the canonical PR as @codebrainz said, but I'm OK either way so long as we get the wonderful docs back :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on Git

Re: [Github-comments] [geany/geany] Show zoom in status bar (use specifier %z). (#2339)

2019-10-06 Thread Colomban Wendling
b4n requested changes on this pull request. You lost the documentation changes in the rebase. I rebased myself and it gave me 2f0d6220d36cf2a533b78010bd6071e6bdcf6944 that you can find on branch https://github.com/b4n/geany/commits/showzoom -- You are receiving this because you are subscribe

Re: [Github-comments] [geany/geany-plugins] debugger (#758)

2019-10-06 Thread Manas Talukdar
Debugger plugin also not available on Windows 10 with Geany 1.36. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/758#issuecomment-538786968

Re: [Github-comments] [geany/geany-plugins] Overview: initialize color variables (#916)

2019-10-06 Thread Matthew Brush
It looks like maybe it was fixed in danmar/cppcheck#2167, but I haven't tested it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/916#issuecomment-538777276

Re: [Github-comments] [geany/geany] Replace Deprecated `gtk_color_selection_dialog_new` with `gtk_color_chooser_dialog_new` (#2340)

2019-10-06 Thread Devyn Collier Johnson
@DevynCJohnson pushed 1 commit. 7931a5d3ba8240a5dc2d3f598754cf2aa3f8965b Update tools.c -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany/pull/2340/files/fdf741f5d6ee8bd4f13e49fa54534dc27365422e..7931a5d3ba8240a5dc2d3f598754c

Re: [Github-comments] [geany/geany] Replace Deprecated `gtk_color_selection_dialog_new` with `gtk_color_chooser_dialog_new` (#2340)

2019-10-06 Thread Devyn Collier Johnson
@DevynCJohnson pushed 1 commit. fdf741f5d6ee8bd4f13e49fa54534dc27365422e Update tools.c -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany/pull/2340/files/917f742304911eec176d916a0f9b31b333a862e9..fdf741f5d6ee8bd4f13e49fa54534

Re: [Github-comments] [geany/geany] Save main and project configuration whenever documents are opened/closed (#2114)

2019-10-06 Thread Enrico Tröger
Merged #2114 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2114#event-2690022642

Re: [Github-comments] [geany/geany-plugins] Overview: initialize color variables (#916)

2019-10-06 Thread LarsGit223
> In any case, I'm fine with this PR if it shuts up cppcheck; this isn't > performance critical in anyway, and it doesn't affect readability. I agree to this and vote for merging it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on

Re: [Github-comments] [geany/geany-plugins] Overview: initialize color variables (#916)

2019-10-06 Thread Enrico Tröger
I don't mind much. If you think it's a false-positive in `cppcheck`, then you should report it (or comment on https://trac.cppcheck.net/ticket/9347, it looks close to our case). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub

Re: [Github-comments] [geany/geany] Dont send the complete "string" with "contextual action" (#2338)

2019-10-06 Thread Andrés Zotelo
thanxs elext, on monday in work, I test your suggestion & reply if it is ok... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2338#issuecomment-538750196

Re: [Github-comments] [geany/geany-plugins] Disable menu general menu item in case of unsupported file type (#922)

2019-10-06 Thread LarsGit223
@frlan: it would be nice if you could prefix the commit message with ```tableconvert: ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/922#issuecomment-538747334

Re: [Github-comments] [geany/geany-plugins] Disable menu general menu item in case of unsupported file type (#922)

2019-10-06 Thread LarsGit223
LarsGit223 requested changes on this pull request. > @@ -338,6 +351,31 @@ void cb_table_convert_type(G_GNUC_UNUSED GtkMenuItem > *menuitem, G_GNUC_UNUSED gp convert_to_table(TRUE, GPOINTER_TO_INT(gdata)); } +void cb_table_convert_change_document(G_GNUC_UNUSED GtkMenuItem *menuitem,

Re: [Github-comments] [geany/geany] Replace Deprecated `gtk_color_selection_dialog_new` with `gtk_color_chooser_dialog_new` (#2340)

2019-10-06 Thread LarsGit223
LarsGit223 requested changes on this pull request. The gtk version checks are not correct. This will break on systems between gtk version 3.0 and 3.4. > @@ -828,20 +842,27 @@ void tools_color_chooser(const gchar *color) if (ui_widgets.open_colorsel == NULL) { +#if (gtk_major_ve

Re: [Github-comments] [geany/geany] Replace Deprecated `gtk_color_selection_dialog_new` with `gtk_color_chooser_dialog_new` (#2340)

2019-10-06 Thread Devyn Collier Johnson
@DevynCJohnson pushed 1 commit. 917f742304911eec176d916a0f9b31b333a862e9 Update tools.c -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany/pull/2340/files/1f2de446e671224b197d73a15f8ba56054325306..917f742304911eec176d916a0f9b3

Re: [Github-comments] [geany/geany] Replace Deprecated `gtk_color_selection_dialog_new` with `gtk_color_chooser_dialog_new` (#2340)

2019-10-06 Thread Devyn Collier Johnson
@DevynCJohnson pushed 1 commit. 1f2de446e671224b197d73a15f8ba56054325306 Update tools.c -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany/pull/2340/files/626f37913f2b21ce3ecd05928d11ac0174b524d0..1f2de446e671224b197d73a15f8ba

[Github-comments] [geany/geany] Replace Deprecated `gtk_color_selection_dialog_new` with `gtk_color_chooser_dialog_new` (#2340)

2019-10-06 Thread Devyn Collier Johnson
Replaced the deprecated GTK color-selector (`gtk_color_selection_dialog_new`) with the GTK color-chooser (`gtk_color_chooser_dialog_new`). You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/2340 -- Commit Summary -- * Update tools.c -- File

[Github-comments] [geany/geany-plugins] Improved the color-calltip macros (#923)

2019-10-06 Thread Devyn Collier Johnson
I improved the color-calltip macros and described its use in the "README" file. Someday, I hope to add adjustable settings for this that are accessible in the autogen.sh file. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/923 -- C

[Github-comments] [geany/geany-plugins] Disable menu general menu item in case of unsupported file type (#922)

2019-10-06 Thread Frank Lanitz
This PR will fix #915 You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/922 -- Commit Summary -- * Disable menu general menu item in case of unsupported file type -- File Changes -- M tableconvert/src/tableconvert.c (42) M

Re: [Github-comments] [geany/geany-plugins] projectorganizer: Add a keybinding for for focusing the sidebar (#920)

2019-10-06 Thread Frank Lanitz
Merged #920 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/920#event-2689759992

Re: [Github-comments] [geany/geany-plugins] projectorganizer: re-read base path when updating project (#921)

2019-10-06 Thread Frank Lanitz
Merged #921 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/921#event-2689759062

Re: [Github-comments] [geany/geany-plugins] Project Organizer: Refresh should re-check base path (#901)

2019-10-06 Thread Frank Lanitz
Closed #901 via #921. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/901#event-2689759063

Re: [Github-comments] [geany/geany-plugins] Project Organizer: Refresh should re-check base path (#901)

2019-10-06 Thread Jiří Techet
Good catch. I've introduced this regression when I added support for external directories. It should actually not be needed to refresh the project manually after confirming the project settings dialog - it should be reloaded automatically for you. #921 should fix this bug. -- You are receiving

[Github-comments] [geany/geany-plugins] projectorganizer: re-read base path when updating project (#921)

2019-10-06 Thread Jiří Techet
Since the base path can change when the project dialog is open, we must re-read the base path, otherwise it doesn't get updated. Fixes #901 You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/921 -- Commit Summary -- * projectorganize