Re: [Github-comments] [geany/geany-plugins] Tableconvert: Disable menu general menu item in case of unsupported file type (#922)

2019-10-07 Thread Frank Lanitz
frlan commented on this pull request. > @@ -338,6 +351,31 @@ void cb_table_convert_type(G_GNUC_UNUSED GtkMenuItem > *menuitem, G_GNUC_UNUSED gp convert_to_table(TRUE, GPOINTER_TO_INT(gdata)); } +void cb_table_convert_change_document(G_GNUC_UNUSED GtkMenuItem *menuitem,

Re: [Github-comments] [geany/geany-plugins] Tableconvert: Disable menu general menu item in case of unsupported file type (#922)

2019-10-07 Thread LarsGit223
LarsGit223 commented on this pull request. > @@ -338,6 +351,31 @@ void cb_table_convert_type(G_GNUC_UNUSED GtkMenuItem > *menuitem, G_GNUC_UNUSED gp convert_to_table(TRUE, GPOINTER_TO_INT(gdata)); } +void cb_table_convert_change_document(G_GNUC_UNUSED GtkMenuItem *menuitem,

Re: [Github-comments] [geany/geany-plugins] better lines deleting (#782)

2019-10-07 Thread elextr
@techee not sure what you mean, the EOLs are definitely in the Scintilla buffer like all the other characters. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany] GeanyNumberedBookmarks works well **except** when working in Projects. (#2343)

2019-10-07 Thread elextr
Transferred from Geany to Geany plugins since thats where numbered bookmarks lives. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2343#issuecomment-539230086

[Github-comments] [geany/geany-plugins] GeanyNumberedBookmarks works well **except** when working in Projects. (#924)

2019-10-07 Thread JanAxelsson
GeanyNumberedBookmarks works well **except** when working in Projects. It would be a great feature if it worked always. I understood that one issue was that if a file had changed externally, the folding would be unreliable. You asked for suggestions somewhere in this forum

Re: [Github-comments] [geany/geany] Messages tab: Show Find Usage matches in bold (#2342)

2019-10-07 Thread elextr
Havn't looked at the code yet, but like the idea, and choosing just to bold is a good way of avoiding the theme and colour problems other highlighting would have. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany] Feature Request: Remember made code-foldings (#1587)

2019-10-07 Thread JanAxelsson
GeanyNumberedBookmarks works well **except** when working in Projects. It would be a great feature if it worked always. I understood that one issue was that if a file had changed externally, the folding would be unreliable. You asked for suggestions somewhere in this forum

Re: [Github-comments] [geany/geany-plugins] Tableconvert: Disable menu general menu item in case of unsupported file type (#922)

2019-10-07 Thread Frank Lanitz
frlan commented on this pull request. > @@ -338,6 +351,31 @@ void cb_table_convert_type(G_GNUC_UNUSED GtkMenuItem > *menuitem, G_GNUC_UNUSED gp convert_to_table(TRUE, GPOINTER_TO_INT(gdata)); } +void cb_table_convert_change_document(G_GNUC_UNUSED GtkMenuItem *menuitem,

Re: [Github-comments] [geany/geany-plugins] Tableconvert: Disable menu general menu item in case of unsupported file type (#922)

2019-10-07 Thread LarsGit223
LarsGit223 commented on this pull request. > @@ -338,6 +351,31 @@ void cb_table_convert_type(G_GNUC_UNUSED GtkMenuItem > *menuitem, G_GNUC_UNUSED gp convert_to_table(TRUE, GPOINTER_TO_INT(gdata)); } +void cb_table_convert_change_document(G_GNUC_UNUSED GtkMenuItem *menuitem,

Re: [Github-comments] [geany/geany-plugins] Tableconvert: Disable menu general menu item in case of unsupported file type (#922)

2019-10-07 Thread Frank Lanitz
frlan commented on this pull request. > @@ -338,6 +351,31 @@ void cb_table_convert_type(G_GNUC_UNUSED GtkMenuItem > *menuitem, G_GNUC_UNUSED gp convert_to_table(TRUE, GPOINTER_TO_INT(gdata)); } +void cb_table_convert_change_document(G_GNUC_UNUSED GtkMenuItem *menuitem,

Re: [Github-comments] [geany/geany] Color Chooser Inserts and Replaces Text - Purpose of Tool is Misleading (#2204)

2019-10-07 Thread LarsGit223
@allanwmacdonald: We added a section to the manual describing the Color Chooser. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2204#issuecomment-539110711

Re: [Github-comments] [geany/geany] doc: added documentation for the Color Chooser (#2337)

2019-10-07 Thread Nick Treleaven
Merged #2337 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2337#event-2692598177

Re: [Github-comments] [geany/geany] Messages tab: Show Find Usage matches in bold (#2342)

2019-10-07 Thread Nick Treleaven
@ntrel pushed 2 commits. 79709057247deb19feeb67418f189dfc5a7acdf2 Use italic filename & line, not underline eda7d6a173d51bfe2318d314a46fa840a74b8b4b Re-use GStringChunk instead of allocating strings in a loop -- You are receiving this because you are subscribed to this thread. View it on

Re: [Github-comments] [geany/geany] Messages tab: Show Find Usage matches in bold (#2342)

2019-10-07 Thread Nick Treleaven
I think italic filename & line looks less visually noisy than underlined: ![image](https://user-images.githubusercontent.com/1107820/66331082-ad2f4d00-e929-11e9-8e77-ebde23466184.png) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it

Re: [Github-comments] [geany/geany-plugins] better lines deleting (#782)

2019-10-07 Thread Jiří Techet
This is unfortunately one of the hard-to-fix problems because of how the source code editing component (Scintilla) works compared to vim. In vim EOL behaves like a normal character at the end of line while in Scintilla just breaks the line but the EOL character isn't at the end of the line. --

Re: [Github-comments] [geany/geany-plugins] projectorganizer : add shortcut to focus sidebar project tab (#904)

2019-10-07 Thread Jiří Techet
Meh, just now I noticed this wasn't a bug report but actually a pull request - could have saved me some work. In my patch I just avoided assigning tab number which is probably better because the number can get wrong when some plugins add/remove new tabs to/from the sidebar. -- You are

Re: [Github-comments] [geany/geany-plugins] projectorganizer : add shortcut to focus sidebar project tab (#904)

2019-10-07 Thread Jiří Techet
Closed #904. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/904#event-2692171916

Re: [Github-comments] [geany/geany-plugins] vimode: Don't use word navigation from Scintilla (#919)

2019-10-07 Thread Jiří Techet
Should be fixed now. I've also rewritten the patch to make it more maintainable and moved the code to a separate file. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[Github-comments] [geany/geany] Messages tab: Show Find Usage matches in bold (#2342)

2019-10-07 Thread Nick Treleaven
* Add function msgwin_msg_add_markup() * Underline Find Usage filename and line Screenshot of regex match: ![image](https://user-images.githubusercontent.com/1107820/66309938-cffa3b00-e902-11e9-864b-2f8e7c73788d.png) You can view, comment on, or merge this pull request online at:

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

2019-10-07 Thread Thomas Martitz
@b4n your review is still pending. Please have a look again. I would like to merge this early in the cycle. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1813#issuecomment-538851090