Merged #925 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/925#event-2697765583
Small nitpick, not a blocker. Nice change.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2345#issuecomment-539846864
kugel- approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2345#pullrequestreview-299184188
kugel- commented on this pull request.
> @@ -232,21 +232,18 @@ void sidebar_update_tag_list(GeanyDocument *doc,
> gboolean update)
gtk_widget_show(doc->priv->tag_tree);
g_object_ref((gpointer)doc->priv->tag_tree);/* to
hold it after removing
Error msg:
Could not read the contents of Desktop
Error opening directory '/Users/myusernme/Desktop': Operation not permitted
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2344#issuecom
Thanks for the heads up and review!
> To be honest if this works well I don't know why we need the other 2 options
> besides Show Tree.
Once I used "show tree" I never went back to the other methods. It's really
great IMO, especially since it allows to easily close all files within a
directory
> I never use the notebook popup menu, mainly because I always have many files
> open so I always have to scroll.
ditto because I have the tabs turned off
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/g
sidebar tree #1813 implements the "in folder part" through the side bar, i.e.
when you close a folder (via popup menu or middle mouse click) then all files
below that folder will be closed. The other use case could probably also be
implemented there. Do you think it makes this PR obsolete?
I ne
@kugel- pushed 1 commit.
f15336e0ef057947ba6d1d74d78d7d87952b8e06 typo and doc fixes
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/geany/geany/pull/1813/files/1d28d2a7833c7a858ab4c00aed345d3d8c1abbb3..f15336e0ef057947ba6d1d74d78d7d87
Not sure if it matters, but I believe this will iterate back-to-front for users
with RTL UI.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2347#issuecomment-539761808
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/925
-- Commit Summary --
* Turkish translations updated
-- File Changes --
M po/tr.po (1400)
-- Patch Links --
https://github.com/geany/geany-plugins/pull/925.patch
https://gi
codebrainz commented on this pull request.
> @@ -857,7 +857,6 @@ static void on_openfiles_document_action(GtkMenuItem
> *menuitem, gpointer user_da
while (i >= 0 && gtk_tree_model_iter_nth_child(model,
&child, &iter, i))
{
codebrainz commented on this pull request.
> @@ -455,60 +456,104 @@ static void
> on_close_documents_right_activate(GtkMenuItem *menuitem, GeanyDocume
}
+// simple implementation (vs. close all which doesn't close documents if
cancelled)
+static void close_folder_action(GeanyDocument *cur
@codebrainz true, but I think what @ntrel is saying is that this one is
_actually_ capturing variables with the attendant risks.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2345#issuec
Looks like a nice cleanup.
Kind of pedantic but using the adjective "unhygienic" relating to C macros is
superfluous since they all are :)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/
> But geany displays immediately an error dialog ...
... which says ...
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2344#issuecomment-539754091
Could be useful at times, quick looks ok, havn't tested.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2346#issuecomment-539710975
elextr commented on this pull request.
> + if (cur_doc == NULL)
+ cur_doc = document_get_current();
+ if (!cur_doc->real_path)
+ return;
+
+ gchar *dir = g_dirname(cur_doc->real_path);
+
+ for (gint i = 0; i <
gtk_notebook_get_n_pages(GTK_NOTEBO
ntrel commented on this pull request.
Haven't tested, but the idea seems great. (To be honest if this works well I
don't know why we need the other 2 options besides *Show Tree*).
I've reviewed the doc changes and made suggestions, not a blocker. If I have
time maybe I'll fix those.
> @@ -530,
ntrel commented on this pull request.
> + return i;
+}
+
+
+typedef struct TreeForeachData {
+ gchar *needle;
+ gsize best_len;
+ gsize needle_len;
+ GtkTreeIter best_iter;
+ enum {
+ TREE_CASE_NONE,
+ TREE_CASE_EQUALS,
+
@vmkononenko: please have a look.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/914#issuecomment-539587374
@LarsGit223 The existing code iterates documents_array sequentially. It's
better for the user to iterate in notebook tab order, because tabs can be
reordered. The user will notice the difference when there are unsaved documents
to close.
--
You are receiving this because you are subscribed to
What is this PR doing or better said what is the advantage compared to the
current code?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2347#issuecomment-539585330
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/2347
-- Commit Summary --
* Iterate in tab order for *Close Other Documents*
-- File Changes --
M src/callbacks.c (11)
M src/sidebar.c (1)
-- Patch Links --
https://github.com/gea
@ntrel pushed 1 commit.
e2a098a4e15a93c744b228fdd4a2eb3a25ea3a3a Iterate in tab order for close folder
items
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/geany/geany/pull/2346/files/55f71893e978100da5dea87d6f0fbb205a31caf4..e2a098a
ntrel commented on this pull request.
> + if (cur_doc == NULL)
+ cur_doc = document_get_current();
+ if (!cur_doc->real_path)
+ return;
+
+ gchar *dir = g_dirname(cur_doc->real_path);
+
+ for (gint i = 0; i <
gtk_notebook_get_n_pages(GTK_NOTEBOO
Also fixes iterating docs for *Close other Documents* in notebook tab order.
I'd like to add a folder item for *Open in New Window* too.
Screenshot:
You can view, comment on, or merge thi
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/2345
-- Commit Summary --
* sidebar.c: Replace CHANGE_TREE macro with function
-- File Changes --
M src/sidebar.c (37)
-- Patch Links --
https://github.com/geany/geany/pull/2345.patch
Hi elextr, Mathew,,
this is a "final" report of the issue,
I use it in this way : **foo.bat "%s"** , so, on the "recieving app" I have to
trim the initial and final quotes and thats all!!!
Thanxs for the help
Hugs from Andrés
--
You are receiving this because you are subscribed to th
Oops, thanks.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2329#issuecomment-539513506
Merged #2269 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2269#event-2695388860
#919 looks good to me, thanks for your help.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/909#issuecomment-539469822
Seems good to me, thanks for doing this by the way.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/919#issuecomment-539469526
additional info:
If other application try to access these folders the OS recognizes this and the
user is asked for an exemption. But geany displays immediately an error dialog
...
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on Git
Hi,
in macos catalina the folders Desktop und Documents are normally locked by the
operating system.
If i add geany to the "Full Disk Access" list, the access to these folders ist
still not possible ...
Is macos catalina buggy or geany ?
;-)
thx
--
You are receiving this because you are subsc
35 matches
Mail list logo
