The custom file types ability is somewhat confusing. Does this completely
override a normal language file or does it use a normal language file and then
apply the changes listed on top?
Also, the documentation says that custom file types are more limited and
doesn't list [keywords] and [styling
To be clear, the reason it doesn't seem worth too much effort is:
1. its a function of the rather esoteric language lawyer ordering of the
translation phases and I doubt ctags emulates them at all
2. @codebrainz has indicated a perfectly reasonable workaround that works for
humans too
--
You
Technically the macro is correct as is, translation phase 2 (removal of
backslash newline pairs) and translation phase 3 (replacement of comments with
a single space) are run before translation phase 3 (the preprocessor) which
therefore will see the `#define` on one line as is required.
So its
Escaping the newlines within the multi-line comment also seems to fix it.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2349#issuecomment-540291126
I haven't tried this yet in practice, but it seems like a good improvement.
> This will be the most common choice for anyone who disables notebook tabs.
If they disable notebook tabs, why does it matter? Isn't the menu only shown
for people who keep tabs enabled?
> This also groups the commands
codebrainz commented on this pull request.
> void notebook_init(void)
{
+ GtkWidget *btn = gtk_button_new_with_label("☰");
I think I've seen in some GNOME apps they use icon button with an icon like
`view-list` or `view-more` or maybe some more semantically correct name for
same icon.
You can create a [custom
filetype](https://www.geany.org/manual/current/index.html#custom-filetypes)
with armish instruction lists similar to the AVR one on the
[wiki](https://wiki.geany.org/config/avr_asm).
--
You are receiving this because you are subscribed to this thread.
Reply to this ema
Ah, I'm reading my emails in chronological order, hadn't seen the UI issues are
already being discussed/addressed in a separate PR #2348.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/23
Currently there's very mild support for "asm" as a language type, but [the
definition
file](https://github.com/geany/geany/blob/master/data/filedefs/filetypes.asm)
seems to just be partial support for Intel assembly.
I'd like to have better support for ARM assembly, but I'm not sure if people
codebrainz commented on this pull request.
> @@ -857,7 +857,6 @@ static void on_openfiles_document_action(GtkMenuItem
> *menuitem, gpointer user_da
while (i >= 0 && gtk_tree_model_iter_nth_child(model,
&child, &iter, i))
{
codebrainz commented on this pull request.
> @@ -857,7 +857,6 @@ static void on_openfiles_document_action(GtkMenuItem
> *menuitem, gpointer user_da
while (i >= 0 && gtk_tree_model_iter_nth_child(model,
&child, &iter, i))
{
> I don't think this matters much, at least the order is still simple for the
> user to understand.
Agree.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2347#issuecomment-540260122
I do use the tab menu a lot, but I'm not a big fan of the UI of this PR. Even
before, I thought there were too many "close" options in the menu, and this
adds another. My inclination would be too put them all in a submenu, but while
it de-clutters the menu, it makes them more annoying to use. Al
LarsGit223 commented on this pull request.
> @@ -27,7 +27,7 @@
#include
#include
-
+#include
This is not required. I removed it and can still build Geany-Plugins. Also it
makes the Travis-CI build fail for some reason (but I don't know why).
--
You are receiving this because you are s
LarsGit223 requested changes on this pull request.
Fine for me, except that ```cb_table_convert_change_document``` should also be
a static function.
> @@ -35,6 +35,19 @@ PLUGIN_SET_TRANSLATABLE_INFO(
GeanyPlugin*geany_plugin;
GeanyData *geany_data;
+
+PluginCallback
The multi-line comment within a macro means that `int y` (and all code
following it) doesn't get parsed by ctags:
```c
int x;
#define CHANGE_TREE(new_child) \
G_STMT_START { \
/* only change the tag tree if it's actually not the
same (to avoid flic
> It doesn't do it recursively
True, I'm not sure whether this pull should or not. (Recursive closing does
make sense for your sidebar tree PR).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany
ntrel commented on this pull request.
> + if (cur_doc == NULL)
+ cur_doc = document_get_current();
+ if (!cur_doc->real_path)
+ return;
+
+ gchar *dir = g_dirname(cur_doc->real_path);
+
+ for (gint i = 0; i <
gtk_notebook_get_n_pages(GTK_NOTEBOO
ntrel commented on this pull request.
> + if (cur_doc == NULL)
+ cur_doc = document_get_current();
+ if (!cur_doc->real_path)
+ return;
+
+ gchar *dir = g_dirname(cur_doc->real_path);
+
+ for (gint i = 0; i <
gtk_notebook_get_n_pages(GTK_NOTEBOO
The existing popup menu lists all the notebook tabs first then shows command
items below. This means the command items are harder to access (user has to
move mouse further). They can also get pushed off screen when there are many
tabs open (see
https://github.com/geany/geany/pull/2346#issuecomm
@frlan pushed 1 commit.
b3cb294f589d7cd6651f6faaf58f0d7964c2df4b Tableconvert: Disable menu general
menu item in case of unsupported file type
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/geany/geany-plugins/pull/922/files/e82c24cb
Closed #507.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/507#event-2699019904
I changed project organizer to point to the online documentation quite a while
ago so this issue isn't present any more.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/507#issue
Okay, your call.
> Actually the sidebar 'Show Paths' option already supports closing all
> docs in a folder.
It doesn't do it recursively because each sub-(sub-) directory gets a top-level
node just below the root.
--
You are receiving this because you are subscribed to this thread.
Repl
ntrel commented on this pull request.
> @@ -455,60 +456,104 @@ static void
> on_close_documents_right_activate(GtkMenuItem *menuitem, GeanyDocume
}
+// simple implementation (vs. close all which doesn't close documents if
cancelled)
+static void close_folder_action(GeanyDocument *cur_doc,
> #1813 implements the "in folder part" through the side bar
Actually the sidebar 'Show Paths' option already supports closing all docs in a
folder.
> The other use case could probably also be implemented there. Do you think it
> makes this PR obsolete?
I think this pull makes the feature more
@ntrel pushed 1 commit.
07bdb07af839a3f93426fc1a08fb22e55391a469 Revert whitespace change
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/geany/geany/pull/2346/files/b33d7a81e1e4e6f9b0dfd4cc894400f8142a2907..07bdb07af839a3f93426fc1a08f
@ntrel pushed 1 commit.
b33d7a81e1e4e6f9b0dfd4cc894400f8142a2907 g_dirname is deprecated
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/geany/geany/pull/2346/files/e2a098a4e15a93c744b228fdd4a2eb3a25ea3a3a..b33d7a81e1e4e6f9b0dfd4cc8944
> I believe this will iterate back-to-front for users with RTL UI
OK, looks like *Close All* has this same issue though:
https://github.com/geany/geany/blob/master/src/document.c#L3372-L3380
I don't think this matters much, at least the order is still simple for the
user to understand.
--
You
Any news about this pull request? Is this patch working?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2161#issuecomment-539970761
Looks like a Catalina speific issue. Should be move to geany-osx project.
@techee Any opinion about cause?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2344#issuecomment-539961861
Yes, but you cannot put cursor on the EOL character (which is possible in Vim)
- the cursor is just in front of the EOL character and this is why copying a
line is off-by-1 and excludes the EOL character in the plugin.
--
You are receiving this because you are subscribed to this thread.
Reply t
Let me clarify myself, since I obviously made this sound more like a numbered
bookmark feature, than a general Geany feature.
There has been several feature requests to include remembered code-folding in
Geany, and from the post I linked, there were also a question from the
developers on how t
33 matches
Mail list logo
