Re: [Github-comments] [geany/geany-plugins] treebrowser: fix icons in the tree and the toolbar (#927)

2019-10-13 Thread LarsGit223
LarsGit223 commented on this pull request. > ctype = g_content_type_guess(path, NULL, 0, NULL); icon = g_content_type_get_icon(ctype); g_free(ctype); if (icon != NULL) { - gtk_icon_size_lookup(GTK_ICON_SIZE_MENU, , NULL); -

Re: [Github-comments] [geany/infrastructure] Error on latest log link on Geany IRC backlogs (#6)

2019-10-13 Thread elextr
> I don't find "latest log link" but assume you mean > https://irc.geany.org/logs/current.php? Sorry "live" not latest, and yeah it goes to "current.php" > Based on the issue create date(short after midnight UTC) and the fact that > the link is working right now, I guess the logfile was

Re: [Github-comments] [geany/infrastructure] Error on latest log link on Geany IRC backlogs (#6)

2019-10-13 Thread Enrico Tröger
What exact link did you open? I don't find "latest log link" but assume you mean https://irc.geany.org/logs/current.php? Based on the issue create date(short after midnight UTC) and the fact that the link is working right now, I guess the logfile was already rotated but the new one not yet

Re: [Github-comments] [geany/geany-plugins] treebrowser: fix icons in the tree and the toolbar (#927)

2019-10-13 Thread Jiří Techet
@techee pushed 3 commits. e6c1df585ec5c38aa02db2f3b0796707476f1f32 treebrowser: Use GIcon instead of pixbuf for tree icons 99ef6527ed6a93c6b799ea6a6b110b445963f63d treebrowser: Use better icons ab1172ac79e369a5e450eaf8b93bb99eec765a72 treebrowser: introduce a helper function and eliminate

Re: [Github-comments] [geany/geany-plugins] treebrowser: fix icons in the tree and the toolbar (#927)

2019-10-13 Thread Jiří Techet
techee commented on this pull request. > - GtkIconSet *icon_set; - - icon_set = gtk_icon_factory_lookup_default(stock_id); - - if (icon_set) - return gtk_icon_set_render_icon(icon_set, gtk_widget_get_default_style(), -

Re: [Github-comments] [geany/geany-plugins] treebrowser: fix icons in the tree and the toolbar (#927)

2019-10-13 Thread Jiří Techet
techee commented on this pull request. > ctype = g_content_type_guess(path, NULL, 0, NULL); icon = g_content_type_get_icon(ctype); g_free(ctype); if (icon != NULL) { - gtk_icon_size_lookup(GTK_ICON_SIZE_MENU, , NULL); -

Re: [Github-comments] [geany/geany] Multi-line "Find in Files" searching (#2322)

2019-10-13 Thread Chris Graham
> I think you could already set pcregrep as the grep tool in Preferences. Then > in the other options entry [of find in files] you can add any necessary flags > for multi-line matching. Thanks, I wasn't aware of the option. It almost works, but I had to tweak the code:

Re: [Github-comments] [geany/geany] Open dialog: Enhance file filters (#2356)

2019-10-13 Thread Nick Treleaven
@ntrel pushed 1 commit. 0e7a2fe3476d0bd0d436e68a5d080bb0c5dd33b3 Re-use project file patterns tooltip in Find in Files dialog -- You are receiving this because you are subscribed to this thread. View it on GitHub:

[Github-comments] [geany/geany] Open dialog: Enhance file filters (#2356)

2019-10-13 Thread Nick Treleaven
Depends on #2355 for docs. * Add *Project patterns* to open dialog file filters * Re-use File patterns string in Find in Files dialog vs Files for clarity * Show ungrouped filetypes first in open dialog file filter (fixes #2296 - see [this comment in

[Github-comments] [geany/geany] docs: Document Open dialog options (#2355)

2019-10-13 Thread Nick Treleaven
You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/2355 -- Commit Summary -- * docs: Document Open dialog options -- File Changes -- M doc/geany.txt (22) -- Patch Links -- https://github.com/geany/geany/pull/2355.patch

Re: [Github-comments] [geany/geany] macos - catalina - Full Disk Access not working (Documents, Desktop, ...) (#2344)

2019-10-13 Thread pforpond
> Yeah, I know what's going on - basically Geany is launched by a bash script > which sets the environment variables needed by GTK and Geany. So for macOS, > it's /bin/bash which needs to get the full disk access privileges - see e.g. > this answer for more details: > >

Re: [Github-comments] [geany/geany-plugins] treebrowser: fix icons in the tree and the toolbar (#927)

2019-10-13 Thread LarsGit223
LarsGit223 requested changes on this pull request. Apart from the two little remarks, it looks good to me. > - GtkIconSet *icon_set; - - icon_set = gtk_icon_factory_lookup_default(stock_id); - - if (icon_set) - return gtk_icon_set_render_icon(icon_set,