Re: [Github-comments] [geany/geany] Update C++ compiler check to require C++17 (#2862)

2021-08-17 Thread elextr
I suggest using this, @kugel- has already made a PR for Scintilla 5 and who knows what that needs. Of course its not _just_ the compiler, but also the standard library (which is where string_view lives) that needs to be modern enough, but the compiler is possibly a proxy for that ... maybe.

Re: [Github-comments] [geany/geany] Update C++ compiler check to require C++17 (#2862)

2021-08-17 Thread Matthew Brush
Yeah, as @elextr mentioned, the reason for the check is for an early failure with a message explaining the compiler isn't supported. Another way to do it would be to do a compile-test for only `std::string_view` to also support non-C++17 compilers which might have already supported

[Github-comments] [geany/geany-plugins] vimode: Ignore special command handling in insert mode (#1100)

2021-08-17 Thread Jiří Techet
This special command handling is not related to insert mode and causes problems in insert mode for dummies. Fixes #1075. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1100 -- Commit Summary -- * vimode: Ignore special command

Re: [Github-comments] [geany/geany-plugins] Vimode: Can't exit insert mode if 'g' was the last entered character. (#1075)

2021-08-17 Thread Jiří Techet
> EDIT: I have "Insert Mode for Dummies" on. When I turned that off, it works > now. The bug is in "Insert Mode for Dummies". Ah, OK, I can reproduce it now. Will investigate. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on

Re: [Github-comments] [geany/geany-plugins] Vimode: Can't exit insert mode if 'g' was the last entered character. (#1075)

2021-08-17 Thread natopwns
It's still happening for me. I just open Geany, type `i`, type `g`, and press ``, which does nothing. As soon as I type any other character, `` sends me back to command mode. I'm using Geany from the Arch repos, maybe it has to do with that. I'll try to build from source and see if it stills

Re: [Github-comments] [geany/geany-plugins] yank paste incorrect behaviour (#1060)

2021-08-17 Thread Jiří Techet
> while you understood the vim functions but you ask what "delete line number > means" or yank paste should not be a bug if it is known how it is done. No, I'm asking what _you_ mean by "delete line number" because you didn't explain it and "delete line number" is a bad description. What you

Re: [Github-comments] [geany/geany] Update C++ compiler check to require C++17 (#2862)

2021-08-17 Thread elextr
This should be a failure in configure, hopefully with a message, instead of a compile failure half way through make. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[Github-comments] [geany/geany] Update to Scintilla5 (#2867)

2021-08-17 Thread Thomas Martitz
Update to scintilla, incl. lexilla split-off. Closes #2824 You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/2867 -- Commit Summary -- * Update Scintilla to version 5.1.1 * Update scintilla_changes.patch * Update update-scintilla.sh --

Re: [Github-comments] [geany/geany] Update C++ compiler check to require C++17 (#2862)

2021-08-17 Thread Thomas Martitz
Doesn't a check only really useful if there is a fallback? If we fail hard either way, why add a check? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2862#issuecomment-900047305