@elextr commented on this pull request.
> +Generating tags files using ctags
+*
+Geany supports loading tag files generated using the ``ctags`` command-line
+tool from the universal-ctags project
(https://github.com/universal-ctags/ctags).
+Even though Geany
> based on my preference
For thermes everyone does, so no problem. (Its also why there is so much
discussion on themes)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3063#issuecomment-1763203451
You are receiving this because you are subscribed
If this PR is going to get merged, I'd just suggest also applying the following
patch on top of the theme.
https://github.com/geany/geany-osx/blob/master/prof_gnome_windows_changes.patch
It changes text colors to #00 instead of the slightly gray which is native
for macOS, and also reduces
Closed #35.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-osx/pull/35#event-10655784846
You are receiving this because you are subscribed to this thread.
Message ID:
I NAK'd the theme but I don't want to block any Adwaita-replacement so please
go for it.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3129#issuecomment-1763146890
You are receiving this because you are subscribed to this thread.
Message ID:
I don't have enough time and motivation to play with themes on windows anytime
soon. Go with whatever you agreed.
While I NAK'd #3129 on based on my preference (so biased) I was also clear that
I won't block it (or any other theme) as long as we swap out Adwaita.
So I'm in favor of merging
@kugel- commented on this pull request.
> @@ -23,6 +23,7 @@ s/^\(#define VER_FILEVERSION_STR *\)[^ ].*$/\1"'"$VER"'"/
' -i geany_private.rc
sed -e 's/^\(AC_INIT([^,]*, *\[\)[^]]*\(\],\)/\1'"$VER"'\2/' -i configure.ac
+sed -e 's/^\( *version: *\)[^,]*\(,\)/\1'"\'$VER\'"'\2/' -i meson.build
@kugel- approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3599#pullrequestreview-1678401360
You are receiving this because you are subscribed to this thread.
Message ID:
> How "slow" is it in reality? After all tags are only read once, even seconds
> is likely to be acceptable.
I just tested it and it's actually about the same both with and without
`scope:`. Roughly 1 million tags per second.
So while I still think the patch is worth applying, it can wait
@techee commented on this pull request.
> +Generating tags files using ctags
+*
+Geany supports loading tag files generated using the ``ctags`` command-line
+tool from the universal-ctags project
(https://github.com/universal-ctags/ctags).
+Even though Geany
just to be same as original (poedit complain)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3595#issuecomment-1762820654
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n approved this pull request.
You gotta do what you gotta do I guess
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3600#pullrequestreview-1678012613
You are receiving this because you are subscribed to this thread.
Message ID:
Closing in favor to #3597.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3578#issuecomment-1762816343
You are receiving this because you are subscribed to this thread.
Message ID:
Closed #3578.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3578#event-10653093939
You are receiving this because you are subscribed to this thread.
Message ID:
Closed #3424 as completed via #3597.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3424#event-10653091225
You are receiving this because you are subscribed to this thread.
Message ID:
Merged #3597 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3597#event-10653091149
You are receiving this because you are subscribed to this thread.
Message ID:
Excellent! Thank you very much :)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3358#issuecomment-1762784057
You are receiving this because you are subscribed to this thread.
Message ID:
> I need to understand how to integrate the parsing function with the rest of
> ctags
I think the only thing you have to do is to overwrite the existing regex-based
parser with the code of this parser. And then have a look at the unit tests to
see what fails.
> I'd consider at least pulling
I had a look at the code and it appears to do the right thing. The changes seem
simple enough that they shouldn't cause any problems - so even though we are
close to release, I'm merging this.
Thanks!
--
Reply to this email directly or view it on GitHub:
Merged #3358 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3358#event-10652554773
You are receiving this because you are subscribed to this thread.
Message ID:
@ntrel @elextr
I tested and it works great.
Apart from the little remark on the docs, I'm fine with this.
About the section comment in the docs, this is no big deal, we can also leave
as it is.
--
Reply to this email directly or view it on GitHub:
Yesterday I noticed that the GeanyLua plugin also uses Scintilla 5.x API and so
the version requirement bump is more than justified I think.
Adding conditionals in mutiple plugins only for a hypothetical backwards
compability seems not very reasonable.
--
Reply to this email directly or view
FTR: the used theme on the screenshot is Inkpot.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1281#issuecomment-1762742754
You are receiving this because you are subscribed to this thread.
Message ID:
@elextr just for you, the classic last minute Windows fix.
This was removed as part of https://github.com/geany/geany/pull/3465 a few
months ago. I was very sure I tested this properly but it turned out that the
explicit link to `libiconv` is necessary for building on Windows. However it is
This was removed in e465a2b456e7c0aba6aefc1c4b406b8089386d1a erroneously but it
still needed on Windows/mingw64 builds.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3600
-- Commit Summary --
* Link to libiconv explicitly for
@eht16 approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3597#pullrequestreview-1677927392
You are receiving this because you are subscribed to this thread.
Message ID:
+1 let's merge.
Successfully tested on native Windows with Git installed and without, with
`.git` vailable and without.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3597#issuecomment-1762740662
You are receiving this because you are subscribed to
We missed to update `scripts/version-bump` for Meson and so `meson.build` still
thought we are about to release Geany 1.38 :smile:.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/3599
-- Commit Summary --
* Update meson.build also on
28 matches
Mail list logo
