[Github-comments] Re: [geany/geany] DOC_VALID() usage correctness (Issue #3872)

2024-05-11 Thread elextr via Github-comments
Sigh, welcome to asynchronous programming and state changing beneath you. > if the pointer to the doc was freed in the meantime, DOC_VALID() usage would > lead to memory access over invalid pointer. Document objects are never freed, so you will never get an invalid pointer, so thats one less wo

[Github-comments] [geany/geany] DOC_VALID() usage correctness (Issue #3872)

2024-05-11 Thread Jiří Techet via Github-comments
While looking at some Geany code, I noticed that `DOC_VALID()` is used in some callbacks where it's supposed to check whether the document was closed in the meantime: https://github.com/geany/geany/blob/11b4a00a3020b1c9ace3d3ae65aa5ec7d5ff84e0/src/document.c#L1282-L1292 Unless I'm missing somet

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-05-11 Thread Jiří Techet via Github-comments
@techee pushed 2 commits. eaa76c7e6eef919509857b9776e5338fa53c11ce Create lsp_utils_doc_is_valid() helper function 731a0f3060837a26afc183e57da1897dff366795 Perform expensive operations in idle callback after some timeout -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1331/

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-05-11 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. 884c520b0781945d67603a036215e62f7c3d3c21 Fix cppcheck warnings -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1331/files/a0e0fded5093e77d9b73cce0f304e91b2fc30f34..884c520b0781945d67603a036215e62f7c3d3c21 You are receiving this because you are subscrib

[Github-comments] [geany/geany] Please just add a -i in the geany.desktop for not stuck in "other use socket" improperly. (Issue #3871)

2024-05-11 Thread Sergio Abreu A. via Github-comments
It is very borring to click on a textfile and Geany gives an Erro Window: You accessed with the socket of other user. Avoid this JUST ADDING A "-i" in the geany.desktop (/usr/share/applications) in linux at the "Exec line" Now on Line 142: Exec geany %F Better usability is:

[Github-comments] Re: [geany/geany-plugins] vimode: line operations cause scrolling and escape doesn't work when numlock enabled (Issue #1136)

2024-05-11 Thread Jiří Techet via Github-comments
Closed #1136 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1136#event-12776604957 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] vimode is Broken in Ubuntu 22.04 (Issue #1174)

2024-05-11 Thread Jiří Techet via Github-comments
Closed #1174 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1174#event-12776603532 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Add "document-before-save-as" signal (PR #3572)

2024-05-11 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. 0dfd4655a98778c74ba2f3c2de135627acb84e01 Add "document-before-save-as" signal -- View it on GitHub: https://github.com/geany/geany/pull/3572/files/eab9cc19ab8280f2eef24675c621fe78352595af..0dfd4655a98778c74ba2f3c2de135627acb84e01 You are receiving this because you are s

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-05-11 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. a0e0fded5093e77d9b73cce0f304e91b2fc30f34 Drop the usage of session-opening signal -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1331/files/749ac83c76459735f6d75efb3da53472f0e28c7c..a0e0fded5093e77d9b73cce0f304e91b2fc30f34 You are receiving this beca

[Github-comments] Re: [geany/geany] Add "session-opening" signal emitted when session opening starts/stops (PR #3707)

2024-05-11 Thread Jiří Techet via Github-comments
Closing in favor of https://github.com/geany/geany/pull/3870. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3707#issuecomment-2105840059 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Add "session-opening" signal emitted when session opening starts/stops (PR #3707)

2024-05-11 Thread Jiří Techet via Github-comments
Closed #3707. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3707#event-12776567981 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Fix emission of document-activate signal and various related GUI glitches (PR #3870)

2024-05-11 Thread Jiří Techet via Github-comments
@kugel- Does the patch look OK to you? I restored the signal emission inside the `document_show_tab_idle()` callback which is the function that gets called when opening session files where this behavior is desired. -- Reply to this email directly or view it on GitHub: https://github.com/geany/g

[Github-comments] [geany/geany] Fix emission of document-activate signal and various related GUI glitches (PR #3870)

2024-05-11 Thread Jiří Techet via Github-comments
PR https://github.com/geany/geany/pull/3267 removed the special handling of the situation when no tab change happens after setting an active document after session load. This happens in the situation where 1. There's just a single document 2. Depending on the tab opening logic, the active tab sa