[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

2024-05-15 Thread Colomban Wendling via Github-comments
I rebased against master to have a fixed CI, plus added @eht16 Windows bundle fixes -- hopefully this will help testing and finding out what's wrong :) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1342#issuecomment-2113570447 You are

[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

2024-05-15 Thread Colomban Wendling via Github-comments
@b4n pushed 7 commits. e7f19b79f4b9e200b3e23d645e3cf62c8a7ca7c9 geniuspaste: Port to libsoup3 bb4513ca7e2a7540461d07acbd4a365ce14be802 geniuspaste: Remove use of deprecated GTK API 80607621e5b1569737f3d2da8f3de6d830c9f706 geniuspaste: Enable HTTPS for paste.debian.net

[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

2024-05-15 Thread Colomban Wendling via Github-comments
> Then, I got a compiler warning which might or might not be new but still > worth to look at: > > […] It's actually not an issue (the buffer is taken the line before), but probably worth silencing. > When trying to paste some file, Geany crashes for me when it is executed > natively. I

[Github-comments] Re: [geany/geany-plugins] Vimode: fix cursor position after using undo (PR #1328)

2024-05-15 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > + +void start_undo(CmdContext *c) +{ + c->undo_pos = -1; +} + +void update_undo(CmdContext *c, gint pos) +{ + c->undo_pos = pos; +} + +gboolean end_undo(CmdContext *c) +{ + ScintillaObject *sci = c->sci; + + if (c->undo_pos !=

[Github-comments] Re: [geany/geany-plugins] Vimode: fix cursor position after using undo (PR #1328)

2024-05-15 Thread Jiří Techet via Github-comments
@techee requested changes on this pull request. Looks good to me apart from the few formal comments above and the possible `goto_nonempty()` use. Would you incorporate those changes into this PR? > @@ -162,14 +163,14 @@ void cmd_del_word_left(CmdContext *c, CmdParams *p) void