[Github-comments] Re: [geany/geany-plugins] First commit of Greek translation, 5% done (PR #1512)

2025-09-17 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany-plugins#1512) You should try anes rebase your changes on top of current master, because there are conflicts and your branch is 1200+ commits behind. There doesn't seem to be any valuable translations in current master though, so reusing your file as-is might be O

[Github-comments] Re: [geany/geany] Messages Window - Change name (Issue #4432)

2025-09-10 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany#4432) I agree the current name is probably not very helpful for most people, that just end up getting used to the name rather that really understanding it. As to a replacement I don't really know what would be a good fit, especially considering I believe it can be

[Github-comments] Re: [geany/geany] Add a setting on sort order of autocomplete list (Discussion #4424)

2025-08-29 Thread Colomban Wendling via Github-comments
It currently isn't, but I'm wondering: doesn't accepting the prefix then continuing on typing the suffixes work for you? Maybe lower the minimal amount of characters to type before the completion list shows up. I'm afraid reversing the list will usually break this possibility of completing prefi

[Github-comments] Re: [geany/geany] Vertical selection messes with jumping to symbol defintion, regardless of how I (try to) configure Geany (Discussion #4416)

2025-08-22 Thread Colomban Wendling via Github-comments
It's better to give people some time to answer, especially in the middle of August. If there's something to fix, we'll need to known about it, and give us some time -- we're all volunteers with limited amount of spare time unfortunately. -- Reply to this email directly or view it on GitHub: ht

[Github-comments] Re: [geany/geany] Update Greek translation to 100% (PR #4418)

2025-08-21 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany#4418) @mmisirlis don't do anything :) We can re-run the checks if we want, but I didn't see the point to waste computer time on this given it was already green. If @frlan wants to, he can easily re-run them to see whether they succeed again. -- Reply to this

[Github-comments] Re: [geany/geany] Update Greek translation to 100% (PR #4418)

2025-08-21 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany#4418) (Checks were OK but i accidentally hit the button to restart all jobs) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/4418#issuecomment-3210290601 You are receiving this because you are subscribed to this thread. M

[Github-comments] Re: [geany/geany] Getters are not listed in the Symbols list for JavaScript files (Issue #4419)

2025-08-21 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany#4419) These probably just need to be mapped to something there: https://github.com/geany/geany/blob/master/src/tagmanager/tm_parser.c#L534 The question is then how they should be categorized (like a property or a method? Adding a new category it trickier), and a

[Github-comments] Re: [geany/geany] [request] oils-for-unix filedef (Issue #4396)

2025-08-13 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany#4396) > Thanks for the encouragement and suggestions :) After all, once one as > manually set the file type to “Shell,” writing YSH is already reasonably > handy. I will address syntax highlighting later if I succeed; for now, I am > just trying to get Geany to r

[Github-comments] Re: [geany/geany] Setting to choose the minimum amount of lines a file will contain (Issue #4379)

2025-08-12 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany#4379) I still think it's better as a plugin. However, if it was implemented similar to [virtual space](https://www.geany.org/manual/current/index.html#virtual-spaces) I could see this as an option, but this probably would have to go to [Scintilla](https://scinti

[Github-comments] Re: [geany/geany-plugins] commander: settings dialog, project files, symbols, icons (PR #1498)

2025-08-08 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany-plugins#1498) I probably won't have time to review in coming week, but I'll try to look at this, thanks. One thing that'll I surely ask is whether it could be split into smaller commits, one for each feature. If you don't know how to do that, either learn :) or

[Github-comments] Re: [geany/geany] wierd white line in the middle of the screen (Issue #4395)

2025-08-05 Thread Colomban Wendling via Github-comments
Closed #4395 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/4395#event-18985915750 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] wierd white line in the middle of the screen (Issue #4395)

2025-08-05 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany#4395) This is the [long line marker](https://www.geany.org/manual/current/index.html#long-line-marker) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/4395#issuecomment-3154011000 You are receiving this because you are

[Github-comments] Re: [geany/geany-plugins] spellcheck: Fix wordchars restoration (PR #1495)

2025-08-04 Thread Colomban Wendling via Github-comments
Merged #1495 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1495#event-18977751270 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Spell Check plugin alters Geany behaviour with forwards/backwards word delete after being activated (Issue #1492)

2025-08-04 Thread Colomban Wendling via Github-comments
Closed #1492 as completed via ac7bb99605e282c58e9cd9c1b09582a5cf1523f7. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1492#event-18977751546 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Hiding menubar, one more attempt (PR #4279)

2025-08-04 Thread Colomban Wendling via Github-comments
@b4n approved this pull request. LGTM now -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/4279#pullrequestreview-3084125145 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Switch Windows installer signing from test to release (2107bbd)

2025-08-04 Thread Colomban Wendling via Github-comments
@giuspen ideally I think we should have the same workflow, but have the signature part only run if triggered by a tag (or potentially manually). -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/commit/2107bbdf69266987a79a661a49bc8d9ecc48c57d#commitcomm

[Github-comments] Re: [geany/geany-plugins] Switch Windows installer signing from test to release (2107bbd)

2025-08-04 Thread Colomban Wendling via Github-comments
We should merge the 2.1 branch, yes -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/commit/2107bbdf69266987a79a661a49bc8d9ecc48c57d#commitcomment-163368376 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] [geany/geany-plugins] spellcheck: Fix wordchars restoration (PR #1495)

2025-07-27 Thread Colomban Wendling via Github-comments
See #1492. The second commit can be removed if wanted, it's not currently necessary. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1495 -- Commit Summary -- * spellcheck: Restore whitespace characters * spellcheck: Also restore

[Github-comments] Re: [geany/geany-plugins] from test to release signing workflow (PR #1494)

2025-07-27 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany-plugins#1494) Oops, pushed the wrong branch, and I can't seem to push anything here anymore, nor reopen the PR, sorry. Anyway, it's all merged in 2.1 -- all I wanted was for this PR to show as merged, which unfortunately it won't anymore. No biggie though. --

[Github-comments] Re: [geany/geany-plugins] from test to release signing workflow (PR #1494)

2025-07-27 Thread Colomban Wendling via Github-comments
Closed #1494. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1494#event-18841634732 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] from test to release signing workflow (PR #1494)

2025-07-27 Thread Colomban Wendling via Github-comments
@b4n pushed 0 commits. -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1494/files/07d3a925784d8e5cdb166d95abcb674ba05e0711..9f49affab02a078270e84c5911902131eb5414be You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] from test to release signing workflow (PR #1494)

2025-07-27 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany-plugins#1494) All looks green, merging! @giuspen @techee could you verify all is good? I don't see why it wouldn't as all that changed from the previous test is the release certificate, but well @frlan could you GPG sign the signed artifact from https://github.c

[Github-comments] Re: [geany/geany-plugins] Spell Check plugin alters Geany behaviour with forwards/backwards word delete after being activated (Issue #1492)

2025-07-27 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany-plugins#1492) Confirmed. I never noticed, but indeed if the speller has run on the document, the word boundaries behavior are changed from the default as mentioned (e.g. with `|` representing the caret, hitting Ctrl+Backspace on `|` results in `https://github.co

[Github-comments] Re: [geany/geany-plugins] from test to release signing workflow (PR #1494)

2025-07-27 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany-plugins#1494) Not sure how it ended up like that, but the non-merge commit has everything from the base one, so it's a bit weird. Anyway, I merged + rebased to get rid of the weirdness, and I triggered a run: https://github.com/geany/geany-plugins/actions/runs/1

[Github-comments] Re: [geany/geany] Remember "fold" status for open files (#793)

2025-07-27 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany#793) I think there's a plugin that doors this, maybe it is numbered bookmarks or something -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/793#issuecomment-3124166520 You are receiving this because you are subscribed to

[Github-comments] Re: [geany/geany] Ada keyword "is" error (Issue #4384)

2025-07-24 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany#4384) See https://github.com/universal-ctags/ctags/issues/4284 and https://github.com/universal-ctags/ctags/pull/4285. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/4384#issuecomment-3115226959 You are receiving this

[Github-comments] Re: [geany/geany] Hiding menubar, one more attempt (PR #4279)

2025-07-24 Thread Colomban Wendling via Github-comments
@b4n requested changes on this pull request. Works as advertised, I don't see a problem with it. Though, if @eht16 still likes it better, we could indeed have the menubar item always visible if it has a keybinding set. I don't have a strong opinion on this, and I am fine with the current situa

[Github-comments] Re: [geany/geany-plugins] Add COPYING file for all included plugins (PR #1488)

2025-07-23 Thread Colomban Wendling via Github-comments
Merged #1488 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1488#event-18782548786 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] How do I change the display language? (Discussion #4383)

2025-07-23 Thread Colomban Wendling via Github-comments
There is no setting in the UI, but see https://www.geany.org/documentation/faq/#how-can-i-change-the-language-of-the-user-interface -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/discussions/4383#discussioncomment-13861142 You are receiving this because you

[Github-comments] Re: [geany/geany] Color scheme questions (Discussion #4381)

2025-07-22 Thread Colomban Wendling via Github-comments
> My hypothesis that geany will interact differently with different DEs is > apparently confirmed. Good to know. This is a bit worrysome though, as we're not aware. Which Geany version do you use, and which distribution? (I'd bet on Geany 2.0 on Mint based on one hint, but I could be wrong) -

[Github-comments] Re: [geany/geany] Color scheme questions (Discussion #4381)

2025-07-22 Thread Colomban Wendling via Github-comments
> I'll try to do something reasonable for the style, which will occur whenever > someone is typing a string Yes, this is an important point, don't make it too obnoxious. I use italics myself for this in the scheme I use, as a sufficiently visible yet not aggressive solution. -- Reply to this

[Github-comments] Re: [geany/geany-plugins] Add COPYING file for all included plugins (PR #1488)

2025-07-22 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > All code inside the ``peg-markdown/peg-0.1.9`` directory is under the MIT license (see the ``peg-markdown/LICENSE`` file) and all contributions to this code *will* remain under this license. This will make it easier to -integrate improvements to Discount

[Github-comments] Re: [geany/geany-plugins] Add COPYING file for all included plugins (PR #1488)

2025-07-22 Thread Colomban Wendling via Github-comments
@b4n pushed 1 commit. 89320c633024815920f0cd60fc5038785e916a2d markdown: Make licensing information more accurate -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1488/files/e4dc8eaf44e1261f65c0af55eaa7179272378ee2..89320c633024815920f0cd60fc5038785e916a2d You are receiving th

[Github-comments] Re: [geany/geany] Color scheme questions (Discussion #4381)

2025-07-22 Thread Colomban Wendling via Github-comments
> 1. […] call_tips are entirely unaffected by whatever I put in the call_tips > line. WFM, with `call_tips=#c00;yellow;true;true` I get this: https://github.com/user-attachments/assets/ab782a29-66e4-4fee-b19d-abedd1ce8cc9"; /> Which is admittedly ugly, but definitely not my DE's theme :) > 2\.

[Github-comments] Re: [geany/geany] Find result indicators - Show find result indicators in the vertical scroll bar (Discussion #4008)

2025-07-22 Thread Colomban Wendling via Github-comments
My Firefox does as well. Anyway, it seems to just work by drawing over it: Sample Python code ```python import math import gi gi.require_version('Gtk', '3.0') # noqa from gi.repository import Gtk # Interesting piece class MyScrollbar(Gtk.Scrollbar): def do_draw(self, cr): Gtk.Scrol

[Github-comments] Re: [geany/geany] Color scheme questions (Discussion #4381)

2025-07-21 Thread Colomban Wendling via Github-comments
> * call tips: those are the little popups that appear with the function > signature or similar e.g. when typing the opening parenthesis after the > function name. Just do add: for example try typing `printf(` in a C source file: you'll get the cllatip to show. However, it seems the colors are

[Github-comments] Re: [geany/geany] Color scheme questions (Discussion #4381)

2025-07-21 Thread Colomban Wendling via Github-comments
* call tips: those are the little popups that appear with the function signature or similar e.g. when typing the opening parenthesis after the function name. * `string_eol`: this is the style for strings that are unterminated. For languages where a string cannot extend past EOL, this name kind o

[Github-comments] Re: [geany/geany] Setting to choose the minimum amount of lines a file will contain (Issue #4379)

2025-07-21 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany#4379) Sounds like something that could be done by a plugin, but not something that we'd add to Geany itself. It could also help motivate others to help if they'd understand the use case, which I don't. -- Reply to this email directly or view it on GitHub: https

[Github-comments] Re: [geany/geany-plugins] Add COPYING file for all included plugins (PR #1488)

2025-07-20 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > All code inside the ``peg-markdown/peg-0.1.9`` directory is under the MIT license (see the ``peg-markdown/LICENSE`` file) and all contributions to this code *will* remain under this license. This will make it easier to -integrate improvements to Discount

[Github-comments] Re: [geany/geany] windows instaler signing test->release (PR #4371)

2025-07-20 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany#4371) > ~I hoped the COPYING.md will be rendered as Markdown but it either does not > work for me or at all or because it's still a branch?~ More important is the > content :). Even better, it [seems to work](https://github.com/geany/geany-plugins/blob/54fc64064

[Github-comments] Re: [geany/geany-plugins] Add COPYING file for all included plugins (PR #1488)

2025-07-20 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > @@ -157,12 +157,12 @@ version 2. For the full text of the license, please > visit http://www.gnu.org/licenses/gpl-2.0.html. The GPL license covers all code and files *not* in the ``discount`` directory. -All code inside the ``discount`` directory is un

[Github-comments] Re: [geany/geany-plugins] autogen.sh fails with multiple "possibly undefined macro" errors (Issue #1485)

2025-07-16 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany-plugins#1485) Installing pkg-config should solve this -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1485#issuecomment-3078363786 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] windows instaler signing test->release (PR #4371)

2025-07-15 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany#4371) Regarding GP licensing, I made a couple tests (https://github.com/b4n/test-multi-license) and it doesn't make GitHub show which licenses are used right away, but it makes it easy to reach them. So the best is probably so have a root LICENSE or COPYING file,

[Github-comments] Re: [geany/geany] Improve CodeQL workflow (PR #4208)

2025-07-15 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. LGTM, not that I know anything about this -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/4208#pullrequestreview-3019045310 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/www.geany.org] Add code signing to releases page (PR #56)

2025-07-14 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/www.geany.org#56) > About Colomban point I remember you discussed to release also the unsigned at > the beginning, personally I found the experience with them quite professional Good, and I don't doubt it. > and I thought it's not in their interest to compromise their

[Github-comments] Re: [geany/geany] Improve CodeQL workflow (PR #4208)

2025-07-14 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany#4208) > excludes a Ctags test case which has invalid syntax Shouldn't we exclude all test cases? It's not code that gets compiled or run, so I doubt its adds much value, and some issues in those might not be fixable (e.g. ones verifying handling of some buggy ca

[Github-comments] Re: [geany/geany] Add navigation back and forward using mouse buttons (PR #4294)

2025-07-14 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany#4294) Fine with me, we're at the start of a cycle so we got time to test it out, and as said before apart from the numbers being hard-coded they look OK from what I could find. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/

[Github-comments] Re: [geany/www.geany.org] Add code signing to releases page (PR #56)

2025-07-14 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/www.geany.org#56) > removed the "unsigned" installer variants. What about https://github.com/geany/geany/pull/4238#issuecomment-2955371423? I'm fine in trusting this, but the concern might still apply. Though,, I don't know how to convey this on the page without saying

[Github-comments] Re: [geany/geany] Run Windows installer workflow on new tags (PR #4372)

2025-07-13 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany#4372) @eht16 we can also use your pattern if you prefer -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/4372#issuecomment-3066698843 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] lsp: Fix build with GLib 2.58 (PR #1476)

2025-07-12 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany-plugins#1476) > > So I don't see anything else I could do, but add a explicit dependency on > > GLib 2.66, although it's moot because the libsoup3 one ought to bring it. > > But then geany-plugins as a whole should depend on glib 2.66, right? No, genuispate will

[Github-comments] Re: [geany/geany-plugins] lsp: Fix build with GLib 2.58 (PR #1476)

2025-07-11 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany-plugins#1476) > I left `g_uri_to_string_partial()` to you :-P. Hum, actually this looks fine. Let me explain: * the whole [`GUri` API](https://docs.gtk.org/glib/struct.Uri.html) is new in 2.66, not just this function * libsoup3's [soup_message_get_uri()](https:/

[Github-comments] Re: [geany/geany-plugins] lsp: Fix build with GLib 2.58 (PR #1476)

2025-07-11 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany-plugins#1476) > I kind of hoped to define `-DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_56` > globally for all plugins and Geany because it would be useful but this > produces warnings for functions provided by newer glib versions even if they > are guarded by the c

[Github-comments] Re: [geany/geany-plugins] lsp: Ensure glib 2.56 compatibility (PR #1479)

2025-07-11 Thread Colomban Wendling via Github-comments
@b4n approved this pull request. LGTM -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1479#pullrequestreview-3011925264 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] lsp: Ensure glib 2.56 compatibility (PR #1479)

2025-07-11 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > @@ -38,6 +38,10 @@ #include #include +#ifndef G_GNUC_FALLTHROUGH +# define G_GNUC_FALLTHROUGH /* GLib < 2.60 */ +#endif I meant what you mentioned in https://github.com/geany/geany-plugins/pull/1476#issuecomment-3063207264 (although I didn't see t

[Github-comments] Re: [geany/geany] windows instaler signing test->release (PR #4371)

2025-07-11 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany#4371) @eht16 I have downloaded the installer and have a signature, but given you used to sign this maybe you should do it -- or at least update the GPG key on the download page. What do you think? -- Reply to this email directly or view it on GitHub: https://gi

[Github-comments] [geany/geany] Run Windows installer workflow on new tags (PR #4372)

2025-07-11 Thread Colomban Wendling via Github-comments
Not sure how to test that without making an actual release, but should work according to https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions and https://github.com/orgs/community/discussions/25302 You can view, comment on, or merge this pull request online at: http

[Github-comments] Re: [geany/geany] windows instaler signing test->release (PR #4371)

2025-07-11 Thread Colomban Wendling via Github-comments
Merged #4371 into 2.1. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/4371#event-18593663903 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] windows instaler signing test->release (PR #4371)

2025-07-11 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany#4371) Cool! Was that the artifact from the build above? If so I can sign an upload that I guess (or @eht16 will do) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/4371#issuecomment-3063669651 You are receiving this bec

[Github-comments] Re: [geany/geany] windows instaler signing test->release (PR #4371)

2025-07-11 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany#4371) …and pushed to a branch on the main repo, and triggered a build there: https://github.com/geany/geany/actions/runs/16226945343 -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/4371#issuecomment-3063283381 You are rec

[Github-comments] Re: [geany/geany] windows instaler signing test->release (PR #4371)

2025-07-11 Thread Colomban Wendling via Github-comments
@b4n pushed 1 commit. 415804d98e1c8c7a274faddfe0654856ab89b7a8 windows instaler signing test->release -- View it on GitHub: https://github.com/geany/geany/pull/4371/files/edeab18fb32b4eddb9c5f8ac8509f120aa2c1f58..415804d98e1c8c7a274faddfe0654856ab89b7a8 You are receiving this because you are su

[Github-comments] Re: [geany/geany] windows instaler signing test->release (PR #4371)

2025-07-11 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany#4371) Wait, I didn't mean revert, just rebase :sweat_smile: I'll do what I meant, but that'll changed the committer. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/4371#issuecomment-3063271342 You are receiving this beca

[Github-comments] Re: [geany/geany-plugins] lsp: Ensure glib 2.56 compatibility (PR #1479)

2025-07-11 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > @@ -38,6 +38,10 @@ #include #include +#ifndef G_GNUC_FALLTHROUGH +# define G_GNUC_FALLTHROUGH /* GLib < 2.60 */ +#endif If you do it like that you could prevent the warning with `MAX_ALLOWED` by undefining the GLib one. Not that it's necessarily pe

[Github-comments] Re: [geany/geany] windows instaler signing test->release (PR #4371)

2025-07-11 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany#4371) @giuspen I just created branch 2.1, and changed the target of this PR to it. Could you re-push your changes on that base (e.g. just rebase and drop the version bump commit from the PR)? -- Reply to this email directly or view it on GitHub: https://github.

[Github-comments] Re: [geany/geany] windows instaler signing test->release (PR #4371)

2025-07-11 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany#4371) Re GP license: him, yeah… ideally we'd have a license summary in the repo root. I'm not sure if github can show multiple licenses, but at least we could help humans. It should be mostly GPL2+, but there probably are others, yet it would be a bug if not ever

[Github-comments] Re: [geany/geany] windows instaler signing test->release (PR #4371)

2025-07-11 Thread Colomban Wendling via Github-comments
@b4n approved this pull request. LGTM. Ideally we'd merge to a 2.1 branch then to master. I can't unfortunately create the right branch from the web interface so it'll have to wait either for somebody else do it or that I get back to my computer (probably tonight). -- Reply to this email dir

[Github-comments] Re: [geany/geany] Geany Nightly: add ZIP/7Z archives for Windows (Issue #4355)

2025-07-09 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany#4355) yes, we probably should -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/4355#issuecomment-3053845423 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Geany Nightly: add ZIP/7Z archives for Windows (Issue #4355)

2025-07-09 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany#4355) @techee https://github.com/geany/geany/issues/3644#issuecomment-3041831321 If it causes issues, it can be changed back. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/4355#issuecomment-3053825652 You are receiving

[Github-comments] Re: [geany/geany] Geany Nightly: add ZIP/7Z archives for Windows (Issue #4355)

2025-07-09 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany#4355) @techee to be fair, you mentioned the installer name including the `setup` piece, so that's fairly explicit -- robots are taking over, but they still are robots ATM 🤖 -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issu

[Github-comments] Re: [geany/geany-plugins] lsp: Fix build with GLib 2.58 (PR #1476)

2025-07-09 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany-plugins#1476) > I'm not sure if we have the same thing in mind - I thought about adding > `-DG_GNUC_FALLTHROUGH` to gcc arguments on glib < 2.60 so the macro would get > defined and it wouldn't require source code modification. Oh, my bad. Still untested, but so

[Github-comments] Re: [geany/geany-plugins] lsp: Fix build with GLib 2.58 (PR #1476)

2025-07-09 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > @@ -315,6 +315,51 @@ LspAutocompleteSymbol *find_symbol(GeanyDocument *doc, > const gchar *text) } +#if ! GLIB_CHECK_VERSION (2, 68, 0) +static guint lsp_g_string_replace(GString *string, const gchar *find, const gchar *replace, guint limit) Indeed,

[Github-comments] Re: [geany/geany-plugins] lsp: Fix build with GLib 2.58 (PR #1476)

2025-07-09 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany-plugins#1476) > Out of curiosity - is it something you noticed by yourself or did someone > else report this issue? Isn't there some compile-time glib macro we could use > to always report issues like this? I've made this mistake several times > already and I sus

[Github-comments] Re: [geany/geany-plugins] lsp: Fix build with GLib 2.58 (PR #1476)

2025-07-09 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > @@ -315,6 +315,51 @@ LspAutocompleteSymbol *find_symbol(GeanyDocument *doc, > const gchar *text) } +#if ! GLIB_CHECK_VERSION (2, 68, 0) +static guint lsp_g_string_replace(GString *string, const gchar *find, const gchar *replace, guint limit) Yes, I

[Github-comments] [geany/geany-plugins] lsp: Fix build with GLib 2.58 (PR #1476)

2025-07-09 Thread Colomban Wendling via Github-comments
@techee First 2.1 issue breakage :) Current LSP doesn't build on GLib 2.58 (GP only depend on 2.56 through Geany 2.1). We have 2 options: * Make LSP depend on 2.68 (for `g_string_replace()`) * Do something similar to this PR to support 2.56 (I don't have any 2.56 so I can't verify for sure, but

[Github-comments] Re: [geany/geany] Normalise key events when creating/processing keybindings (#1633)

2025-07-09 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany#1633) Ah right, thanks -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1633#issuecomment-3051696277 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Normalise key events when creating/processing keybindings (#1633)

2025-07-08 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany#1633) @techee are you closing this because it's 7 years old, or because you don't think it's a good idea anymore? On paper it sounds great, should we try and revive it? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/16

[Github-comments] Re: [geany/geany-plugins] Geany Plugins Test Signing Workflow (PR #1474)

2025-07-07 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany-plugins#1474) https://github.com/geany/geany-plugins/actions/runs/16128602618 looks :green_circle: to me :slightly_smiling_face: -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1474#issuecomment-3046640305 You ar

[Github-comments] Re: [geany/geany-plugins] Geany Plugins Test Signing Workflow (PR #1474)

2025-07-07 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany-plugins#1474) > I fixed my part and we are ready to kick another test-build @b4n but I > noticed the artifact contains v2.2 now, this is not good if we want to > release the signed version of v2.1 we need to keep v2.1 and no changes for a > couple more days, is t

[Github-comments] Re: [geany/geany-plugins] Geany Plugins Test Signing Workflow (PR #1474)

2025-07-07 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany-plugins#1474) @giuspen ACK -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1474#issuecomment-3046583039 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Geany Plugins Test Signing Workflow (PR #1474)

2025-07-07 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany-plugins#1474) @giuspen it's already installed for the organization, and for both Geany and GP repositories -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1474#issuecomment-3046576521 You are receiving this becaus

[Github-comments] [geany/geany-plugins] Add target for signing release tarballs (PR #1475)

2025-07-07 Thread Colomban Wendling via Github-comments
Fixes #1472. --- This is pretty straightforward, similar to Geany's but in a more dist-type agnostic (using `DIST_ARCHIVES` instead of manually listing some expected archives filenames). You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pu

[Github-comments] Re: [geany/geany-plugins] Geany Plugins Test Signing Workflow (PR #1474)

2025-07-07 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany-plugins#1474) https://github.com/geany/geany-plugins/actions/runs/16127977977 -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1474#issuecomment-3046534417 You are receiving this because you are subscribed to this t

[Github-comments] Re: [geany/geany-plugins] Geany Plugins Test Signing Workflow (PR #1474)

2025-07-07 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany-plugins#1474) @giuspen variable and secrets added -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1474#issuecomment-3046523173 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] New IncDec plugin for Geany (PR #1351)

2025-07-07 Thread Colomban Wendling via Github-comments
@b4n requested changes on this pull request. > +#define HEXA_NONE -1 /* hexadecimal number not found */ +#define HEXA_MAYBE 0 /* in progress, need scan more characters */ +#define HEXA_REQUIRE_x 1 /* need character x/X */ +#define HEXA_REQUIR

[Github-comments] Re: [geany/geany-plugins] Update NEWS for 2.1 (PR #1468)

2025-07-06 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany-plugins#1468) @techee once available, don't hesitate uploading them also to the GitHub release: https://github.com/geany/geany/releases/tag/2.1.0 -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1468#issuecomment-3

[Github-comments] Re: [geany/geany] 2.0.0: inconsistency in versioning (Issue #3644)

2025-07-06 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany#3644) I just started 2.2.0 (1ee413b5612b9a2772a1648c7d209ff6c5806733) remembering your request. Hopefully that'll work :) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3644#issuecomment-3041831321 You are receiving t

[Github-comments] Re: [geany/geany] New release ? (Issue #4305)

2025-07-06 Thread Colomban Wendling via Github-comments
Closed #4305 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/4305#event-18492099751 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] New release ? (Issue #4305)

2025-07-06 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany#4305) And here you go: https://github.com/geany/geany/releases/tag/2.1.0 -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/4305#issuecomment-3041838570 You are receiving this because you are subscribed to this thread. Mes

[Github-comments] Re: [geany/geany] 2.0.0: inconsistency in versioning (Issue #3644)

2025-07-06 Thread Colomban Wendling via Github-comments
Closed #3644 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3644#event-18492092704 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] [geany/geany] Release 2.1.0 - Geany 2.1

2025-07-06 Thread Colomban Wendling via Github-comments
## General * Include themes from geany-themes ([Issue#4035](https://github.com/geany/geany/issues/4035), [PR#4044](https://github.com/geany/geany/pull/4044), [Issue#4340](https://github.com/geany/geany/issues/4340), [PR#4354](https://github.com/geany/geany/pull/4354)). * Fix silently truncating

[Github-comments] Re: [geany/geany] Set release date (PR #4368)

2025-07-06 Thread Colomban Wendling via Github-comments
Closed #4368. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/4368#event-18491714619 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Set release date (PR #4368)

2025-07-06 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany#4368) Merged in master as cb5ff3cf0b63971010e60ea2feedd1a0181c1ace -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/4368#issuecomment-3041526351 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Update NEWS for 2.1 (PR #1468)

2025-07-06 Thread Colomban Wendling via Github-comments
Merged #1468 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1468#event-18491552826 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Update NEWS for 2.1 (PR #1468)

2025-07-06 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany-plugins#1468) @frlan should I merge squash and merge this one or do you have other things to add? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1468#issuecomment-3041420692 You are receiving this because you are

[Github-comments] Re: [geany/geany] Prepare NEWS for 2.1 (PR #4315)

2025-07-06 Thread Colomban Wendling via Github-comments
Merged #4315 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/4315#event-18491472571 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Update screenshots for Geany 2.1 documentation (PR #4365)

2025-07-06 Thread Colomban Wendling via Github-comments
Merged #4365 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/4365#event-18491398344 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] prefs: Show indentation warning without a project (PR #4366)

2025-07-06 Thread Colomban Wendling via Github-comments
b4n left a comment (geany/geany#4366) @techee no sweat, it happens and nobody noticed until I compared the screenshots ^^ -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/4366#issuecomment-3041396384 You are receiving this because you are subscribed to t

[Github-comments] Re: [geany/geany] prefs: Show indentation warning without a project (PR #4366)

2025-07-06 Thread Colomban Wendling via Github-comments
Merged #4366 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/4366#event-18491388309 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Update screenshots for Geany 2.1 documentation (PR #4365)

2025-07-06 Thread Colomban Wendling via Github-comments
@b4n approved this pull request. LGTM -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/4365#pullrequestreview-2991217132 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Update screenshots for Geany 2.1 documentation (PR #4365)

2025-07-06 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. On doc/images/pref_dialog_edit_indentation.png: I do, thanks (and I laughed at the commit message :smile: ) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/4365#discussion_r2188221138 You are receiving this because

[Github-comments] Re: [geany/geany] Update screenshots for Geany 2.1 documentation (PR #4365)

2025-07-06 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. On doc/images/pref_dialog_edit_indentation.png: I'm gonna be annoying but… could you re-do it with the focus on the tab as you have it before? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/4365#discussion_r21882

  1   2   3   4   5   6   7   8   9   10   >