@rodrigo1406: no, it's not merged yet. See #2339.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1697#issuecomment-616619190
@Ehlarm:
Did you try to re-install lib-vte with ```sudo apt-get install
libvte-2.91-dev```? Did VTE installation work well - no error messages or so?
I re-checked compiling Geany and Geany-Plugins 1.36 on my Ubuntu machine. Works
fine. All plugins depending on VTE are build, e.g. debugger and
@Ehlarm:
Was your output from Geany-Plugins truncated on copying it into this issue?
There should be something like this on the end:
```
Features:
GeanyVC GtkSpell support: no
Markdown library: peg-markdown
Utility library: yes
Utility library VTE
For completeness please also report the gtk and glib version, you can find them
in Geany's about dialog.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@Ehlarm: please open a new issue and report your details there as this issue is
about a different operating system so the problem fixes might differ and should
not be mixed up.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on
LGBI and build passed, fine for me.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/956#issuecomment-590104073
@grubernd: could you provide an example file and search string so that we can
reproduce the problem?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/593#issuecomment-585355440
I don't see a good solution for this. The gtk people keep on deprecating stuff.
At the moment I will not continue work on this - I more tend to wait until gtk2
support is dropped and only one version needs to be supported.
--
You are receiving this because you are subscribed to this thread.
Did you run ```./autogen.sh``` first?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2403#issuecomment-557703911
Do you have any plugins enabled? Does the problem disappear if you disable all
plugins?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2401#issuecomment-557156169
IMHO the documentation at
https://geany.org/manual/dev/hacking.html#gtk-versions-api-documentation sounds
like GTK2 is the default.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Not much to say, simply the same as Close Documents to the Right -
only to the left.
Also see #2282.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/2365
-- Commit Summary --
* Add Close Documents to the Left feature
-- File Changes --
> Bah, forget it. This is dead now. Move on.
Ok, will wait for #2339 to be merged.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1697#issuecomment-542516427
@vmkononenko: please have a look.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/926#issuecomment-542318297
LarsGit223 approved this pull request.
I have re-tested and now it seems to work fine. Goto and Select work as
expected, also on elements which start at the beginning of the document.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view
> Most likely it's done that since you created a second PR with the same
> branch. You could try and close the second one and I suspect the "Re-open"
> option will become active again for this PR.
The second/other PR is from another branch ```showzoom2```. But I already
pushed again to
I pushed to showzoom again and I hopefully have restored the branch but I do
not see it here since it's already closed.
How can I re-open this PR? Github only let's me create a new PR from
```LarsGit223:showzoom```. Would that re-open this one?
--
You are receiving this because you
@LarsGit223 pushed 1 commit.
c7113a70234c78267209cbb43cafb429d50ec947 added missing docs
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/geany/geany/pull/2339/files/e07c43e0b0048f29f8685cd86d599c851da7dedf
LarsGit223 requested changes on this pull request.
I re-tested this and select seems to work fine now :+1:
There is one little open issue: if the cursor is in a closing tag and the
matching opening tag starts at the beginning of the document, then goto does
not work.
--
You are receiving
Works fine for me with Geany master branch, Ubuntu 18.04.3, Files (Nautilus)
application.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2357#issuecomment-541740609
LarsGit223 commented on this pull request.
>
ctype = g_content_type_guess(path, NULL, 0, NULL);
icon = g_content_type_get_icon(ctype);
g_free(ctype);
if (icon != NULL)
{
- gtk_icon_size_lookup(GTK_ICON_SIZE_MENU, , N
LarsGit223 requested changes on this pull request.
Apart from the two little remarks, it looks good to me.
> - GtkIconSet *icon_set;
-
- icon_set = gtk_icon_factory_lookup_default(stock_id);
-
- if (icon_set)
- return gtk_icon_set_render_icon(icon_
LarsGit223 commented on this pull request.
> @@ -27,7 +27,7 @@
#include
#include
-
+#include
This is not required. I removed it and can still build Geany-Plugins. Also it
makes the Travis-CI build fail for some reason (but I don't know why).
--
You are receiving this because
LarsGit223 requested changes on this pull request.
Fine for me, except that ```cb_table_convert_change_document``` should also be
a static function.
> @@ -35,6 +35,19 @@ PLUGIN_SET_TRANSLATABLE_INFO(
GeanyPlugin*geany_plugin;
GeanyData *geany_data;
+
+PluginCallb
@vmkononenko: please have a look.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/914#issuecomment-539587374
What is this PR doing or better said what is the advantage compared to the
current code?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2347#issuecomment-539585330
LarsGit223 commented on this pull request.
> @@ -338,6 +351,31 @@ void cb_table_convert_type(G_GNUC_UNUSED GtkMenuItem
> *menuitem, G_GNUC_UNUSED gp
convert_to_table(TRUE, GPOINTER_TO_INT(gdata));
}
+void cb_table_convert_change_document(G_GNUC_UNUSED GtkMenuItem *me
LarsGit223 commented on this pull request.
> @@ -338,6 +351,31 @@ void cb_table_convert_type(G_GNUC_UNUSED GtkMenuItem
> *menuitem, G_GNUC_UNUSED gp
convert_to_table(TRUE, GPOINTER_TO_INT(gdata));
}
+void cb_table_convert_change_document(G_GNUC_UNUSED GtkMenuItem *me
@allanwmacdonald: We added a section to the manual describing the Color Chooser.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2204#issuecomment-539110711
> In any case, I'm fine with this PR if it shuts up cppcheck; this isn't
> performance critical in anyway, and it doesn't affect readability.
I agree to this and vote for merging it.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on
@frlan: it would be nice if you could prefix the commit message with
```tableconvert: ```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/922#issuecomment-538747334
LarsGit223 requested changes on this pull request.
> @@ -338,6 +351,31 @@ void cb_table_convert_type(G_GNUC_UNUSED GtkMenuItem
> *menuitem, G_GNUC_UNUSED gp
convert_to_table(TRUE, GPOINTER_TO_INT(gdata));
}
+void cb_table_convert_change_document(G_GNUC_UNUSED GtkMenuItem *me
LarsGit223 requested changes on this pull request.
The gtk version checks are not correct. This will break on systems between gtk
version 3.0 and 3.4.
> @@ -828,20 +842,27 @@ void tools_color_chooser(const gchar *color)
if (ui_widgets.open_colorsel == N
@codebrainz: thanks, did not know that I can rename branches. I'll try to
remeber that if I get to the same situation again. Now I got the new PR open
anyway so I will keep that.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on
#2339 is not a fix of this branch, I just checked out master and applied the
changes.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1697#issuecomment-538672669
@codebrainz: I mixed up the commit history.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1697#issuecomment-538667634
@kugel-: I did something wrong on rebasing/squashing the original PR and so the
commit history was completely messed up. From there I did not know how to get
back to a clean history. (I usually squash without problems and do not create
new PRs without reason)
--
You are receiving this because
> Could also mention that if the cursor is next to/within a hash-prefixed hex
> code, then the dialog will display the color the code represents.
Done.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@LarsGit223 pushed 1 commit.
e32e5bb0bf7f8fa31940e1edc9b284b75de2845a doc: added documentation for the
Color Chooser
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/geany/geany/pull/2337/files/a9d88e7dc5696b922295d1ad1395afbc729f382d
Do not merge this, closing in favor of #2339.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1697#issuecomment-538641738
Closed #1697.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1697#event-2689249777
Replacement PR for PR #1697.
I re-applied the changes to the current master, re-tested and created this PR.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/2339
-- Commit Summary --
* Show zoom in status bar (use specifier %z).
-- File
Sorry, broke it. Will post another clean PR.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1697#issuecomment-538640073
I will try to squash it myself.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1697#issuecomment-538637393
LarsGit223 commented on this pull request.
> @@ -1145,6 +1145,17 @@ applications, in that you'll need to continue to hold
> down the Ctrl and Shift
keys while typing the code point hex digits (and the Enter or Return to finish
the code point).
+Inserting color
LarsGit223 commented on this pull request.
> @@ -1145,6 +1145,17 @@ applications, in that you'll need to continue to hold
> down the Ctrl and Shift
keys while typing the code point hex digits (and the Enter or Return to finish
the code point).
+Inserting color
LarsGit223 commented on this pull request.
> @@ -1145,6 +1145,17 @@ applications, in that you'll need to continue to hold
> down the Ctrl and Shift
keys while typing the code point hex digits (and the Enter or Return to finish
the code point).
+Inserting color
@LarsGit223 pushed 1 commit.
90eb26f432f2557001c8bca22e1388543864ecb6 doc: added documentation for the
Colour Chooser
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/geany/geany/pull/2337/files
LarsGit223 commented on this pull request.
> @@ -1145,6 +1145,17 @@ applications, in that you'll need to continue to hold
> down the Ctrl and Shift
keys while typing the code point hex digits (and the Enter or Return to finish
the code point).
+Inserting color
I added a little section documenting the Colour Chooser to the manual. Also see
#2204.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/2337
-- Commit Summary --
* doc: added documentation for the Colour Chooser
-- File Changes --
M
LarsGit223 commented on this pull request.
> +gint sci_get_fontsize(ScintillaObject *sci, gint style)
+{
+ return (gint) SSM(sci, SCI_STYLEGETSIZE, (uptr_t) style, 0);
+}
Changed and tested. Now looks like your code snippet below.
--
You are receiving this because you are subscri
LarsGit223 commented on this pull request.
> @@ -218,6 +219,8 @@ void
> sci_move_selected_lines_up (ScintillaObject *sci);
void sci_set_font_fractional
(ScintillaObject *sci, gint style, const gchar *font, gdoubl
@LarsGit223 pushed 1 commit.
e7b9ece9256e0f890899eb06aa52313290b7cacf sciwrappers: use fractional size in
'sci_get_font_size()'
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/geany/geany/pull/1697/files
LarsGit223 commented on this pull request.
> @@ -304,6 +305,21 @@ static gchar *create_statusbar_statistics(GeanyDocument
> *doc,
g_string_append_printf(stats_str, "%d",
sci_get_style_at(doc-&g
LarsGit223 requested changes on this pull request.
I tested this and 2 things do not seem to work:
- if the opening tag starts at position 0, then goto and select do not work
- if the cursor is in the closing tag, then select does not work
--
You are receiving this because you are subscribed
LarsGit223 commented on this pull request.
> + * @return A pointer to the style struct.
+ */
+GEANY_API_SYMBOL
+const GeanyLexerStyle *highlighting_get_named_style(const gchar *named_style)
+{
+ GeanyLexerStyle *cs;
+ gchar *comma, *name = NULL;
+
+ g_return_val_if_f
@LarsGit223 pushed 1 commit.
e096b0f080ebe92c4c4d9b9b442174212fe4f096 highlighting: added API call to query
GeanyLexerStyle by name
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/geany/geany/pull/2336/files
This PR adds a new API call to ```highlighting.c```:
``` C
const GeanyLexerStyle *highlighting_get_named_style(const gchar *named_style);
```
This shall enable plugins to query styles dedicated to plugin specific
highlighting. Plugins could have their own styles with dedicated keys/names and
@codebrainz: yes, your suggested change fixes the issue. Posted a PR.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/744#issuecomment-537913556
Fixes #744.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/917
-- Commit Summary --
* geanyprj: fixed cut-off sidebar tab under gtk3
-- File Changes --
M geanyprj/src/sidebar.c (2)
-- Patch Links --
This has now been implemented in PR #896 and merged into master. So it will be
included in the next Geany release 1.37. Please test.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Actually the Tableconvert plugin supports the filetypes HTML, LaTeX and SQL. I
suggest that the menu item _"Convert to table"_ should be disabled if the
current document's filetype is not supported.
--
You are receiving this because you are subscribed to this thread.
Reply to this email
@abbrdr: any feedback? did you have a chance to try my advice?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/893#issuecomment-537668292
> -fixed a bug when one selects text from right to left and then shifts it
> (see comment "in case selection_start was after selection_end" in my code)
This seems to already have been fixed by @b4n in
dc0af51b96d4b98ada550d464b0cd17b24268419. I cannot reproduce any issue on
selecting text from
I guess this can be closed?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/258#issuecomment-537638466
@codebrainz, @elextr: What do you think? Can we merge this? We just had a new
release so if this is merged there is plenty of time for testing. I am asking
cause a PR for the workbench plugin is depending on this PR.
--
You are receiving this because you are subscribed to this thread.
Reply to
Can this be merged? I just resolved the conflicts.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1697#issuecomment-537629699
@LarsGit223 pushed 1 commit.
9ea258374dfb791e19af46c354a01bbdcc4f5a31 Merge branch 'master' into showzoom
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/geany/geany/pull/1697/files/9510042013e1fe0c476c25dce6f1183cb52c85b6
@b4n, @codebrainz, @elextr: ping. What's the final decission? Merge or close it
unmerged? I'm fine with both, just want to get the ticket done.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@elextr:
> Ahh, probably the best would be to use indicators for that,
My question is not about how highlighting itself can be implemented. The
highlighting is already implemented in the plugin, see the code below and yes
it's using indicators:
```
static void highlight_tag(ScintillaObject
> There is no API because setting it programatically would break this
> configuration scheme.
I only want to read a value, preferably be key name. There is a function for
it, but it's static.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or
@codebrainz: I saw an issue for the pairtaghighlighter plugin asking to make
the highlihgt color/style configurable. Then I thought let's quickly add a new
key/value pair to a color scheme and use that values. But then I stumbled
across the API.
--
You are receiving this because you are
@philiprbrenan: can you still re-produce this issue? If yes could you please
paste the original text here in the issue rather than an image for testing?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@elextr: do you really think it's OK to boldly remove the exisiting capability?
If yes, maybe we should remove it in Geany core and the new feature "Join
lines" (as described above) IMHO is also a good candidate for the Line
Operations plugin.
--
You are receiving this because you are
@gsantner: I think what @philiprbrenan means is that it works fine if you close
and re-open Geany. But it does not work as expected if you only close the
document in Geany and then re-open it (without closing Geany itself).
--
You are receiving this because you are subscribed to this thread.
I like to find the best way to let the user specify colors, e.g. by config,
theme or whatever (I am talking about colors for text highlighting here not the
UI parts outside the editor widget). The colorschemes seem to do the job.
Looking at ```highlight.c``` it seems that every style specified
Should we close this? The ticket is 3 years old and there is no feedback to our
questions and it was maybe fixed in the meantime. Can anybody reproduce this?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Before this change the plugin stopped scanning for a tag on the start or the
end of a line. Therefore tags which were split over multiple lines were not
recognized. With this change the plugin scans forward or backward up to a
certain limit and does not stop on a linebreak. The default limit is
You are welcome.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/913#issuecomment-536686905
Closed #913.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/913#event-2674298026
Hmmm...you could try to build ```libvte``` from source. But I have never done
it, so I do not know how simple or difficult it is. Maybe you can ask somewhere
in the Arch community if they know how to get it or build it on Arch. But
without ```libvte``` you cannot build the debugger plugin or
First, let me inform you that there are two debugger plugins in the
Geany-Plugins package you can choose from:
- the debugger plugin
- the scope plugin
If the configure script tells you that the debugger plugin is not enabled than
a requirement to build the debugger plugin is missing. It could
@scriptum: ping.
@frlan: maybe we should merge this if there is no reaction and so others can
test and use it in master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Closed #758.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/758#event-2670587632
I close this now as the debugger plugin with GTK2 & 3 support was just released
in Geany-Plugins 1.36.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/758#issuecomment-536193931
This issue was only a temporary problem during 1.36 development. The issue that
was fixed did not exist in 1.35 so this bugfix shouldnt be mentioned in
NEWS.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/911
-- Commit Summary --
@intact: ooops, of course. Did totally oversee that.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2317#issuecomment-534697093
As an alternative to the possible feature name _"Increment selection"_ I
suggest _"Enumerate selection"_.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2317#issuecomment-534663769
@AdamDanischewski: thanks, I think we have enough information :smile: IMHO this
can be implemented in a new plugin or maybe better as an extension of the
Line-Operations plugin.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on
@RufusVS: the open dialog is created in the function
```create_open_file_dialog()```. It calls the function
```filetypes_create_file_filter()``` to create the filter and that function is
filling the filter with all filetypes from the list ```filetypes_by_title```.
This is filled on startup of
I noticed that there is no new line at the end of the file if the option
```Ensure new line at file end``` is disabled and the file is closed. I checked
that with a different editor (not with Geany). Only on re-opening the file in
Geany the new line appears in the editor window - but it's not
It works if I select it from the file browser inside of Geany or if I use
_"File / Open"_ from the menu.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2303#issuecomment-531591143
Closed #2302.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2302#event-2634767742
You are right! Executing the command
```
gsettings set org.gnome.settings-daemon.plugins.xsettings overrides
"{'Gtk/ButtonImages': <1>, 'Gtk/MenuImages': <1>}"
```
and a reboot fixed the problem. Thanks.
--
You are receiving this because you are subscribed to this thread.
Reply to this email
@codebrainz: Thanks. I use Ubuntu 18.04.3, Gnome desktop. What OS do you use?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2302#issuecomment-531578180
On looking at the build code I noticed the following table:
``` C
static struct BuildMenuItemSpec {
const gchar *stock_id;
const gint key_binding;
const guint build_grp;
const guint build_cmd;
const gchar *fix_label;
Callback
@b4n
> @LarsGit223 at least projfilecmds is being accessed outside build.c, in
> project.c, so it's not actually completely private to build.c. If it was,
> build.h should have had the forward declaration, and build.c the complete one.
Maybe I was not precise enough. The ```GeanyBui
@elextr:
I did a code search in Geany of these pointers:
```
/* TODO: move to structure in build.h and only put a pointer here */
GeanyBuildCommand *filecmds;
GeanyBuildCommand *ftdefcmds;
GeanyBuildCommand *execcmds;
GeanyBuildCommand *homefilecmds;
> Yes, but then they shouldn't be in ```filetypesprivate.h```
Why? Even if the struct items are not accessed then you still need the pointers
to the memory for the filetype specific build commands. So I agree we might
need to include ```build.h``` for the function declarations but I like the
> This doesn't make any sense, the point of including headers is so that
> definitions are available to compilers for checking and optimisations. By
> making them opaque pointers that is defeated.
I disagree. If items inside ```struct GeanyBuildCommand``` are private and
shall only be used
1 - 100 of 893 matches
Mail list logo
