Re: [Github-comments] [geany/geany] Cancel 'MSG_TYPE_RESAVE' info bar if still open in function 'document_reload_force'. (#1621)

2017-10-05 Thread LarsGit223
I created a new PR with a different commit message, see #1628. So this can be closed. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1621#issuecomment-334538995

Re: [Github-comments] [geany/geany] Cancel 'MSG_TYPE_RESAVE' info bar if still open in function 'document_reload_force'. (#1621)

2017-10-05 Thread LarsGit223
Closed #1621. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1621#event-1280407787

[Github-comments] [geany/geany] Close "Deleted from Disk" Infobar on Reload. (#1628)

2017-10-05 Thread LarsGit223
Cancel 'MSG_TYPE_RESAVE' info bar if still open in function 'document_reload_force'. This closes the "Deleted from Disk" message if the user clicks on the reload button. Fixes #1330. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/1628 --

Re: [Github-comments] [geany/geany-plugins] Workbench: fixed not closed file handles on directory scanning (thanks to techee). Fixes #607. (#608)

2017-10-05 Thread LarsGit223
LarsGit223 commented on this pull request. > @@ -245,14 +248,17 @@ static GSList > *wb_project_dir_get_file_list(WB_PROJECT_DIR *root, const gchar *u g_hash_table_insert(visited_paths, real_path, GINT_TO_POINTER(1)); - while (TRUE) + while ((child_name = g_dir_rea

Re: [Github-comments] [geany/geany-plugins] Workbench: fixed not closed file handles on directory scanning (thanks to techee). Fixes #607. (#608)

2017-10-05 Thread LarsGit223
@LarsGit223 pushed 1 commit. 45e8a2d workbench: Small code re-factoring. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany-plugins/pull/608/files/d41742972cd0ae3e134f2411f2df18e008f5fcf3

Re: [Github-comments] [geany/geany-plugins] workbench: Increased required geany API version to 235 for usage of 'utils_get_real_path'. (#613)

2017-10-04 Thread LarsGit223
Never mind, s... happens. At least I learned something :wink: -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/613#issuecomment-334361030

Re: [Github-comments] [geany/geany-plugins] Geany-scope blank window, inusable (#433)

2017-10-04 Thread LarsGit223
@elextr: yes, of course. I have repeated my question there. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/433#issuecomment-334360606

Re: [Github-comments] [geany/geany] Handle continuous G_IO_IN-s without any data (#1461)

2017-10-04 Thread LarsGit223
@elextr @b4n @kugel-: I can confirm that this also fixed the problem on my system. Are there any plans to merge this in the next time? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany-plugins] Workbench: fixed not closed file handles on directory scanning (thanks to techee). Fixes #607. (#608)

2017-10-04 Thread LarsGit223
LarsGit223 commented on this pull request. > @@ -245,14 +248,17 @@ static GSList > *wb_project_dir_get_file_list(WB_PROJECT_DIR *root, const gchar *u g_hash_table_insert(visited_paths, real_path, GINT_TO_POINTER(1)); - while (TRUE) + while ((child_name = g_dir_rea

Re: [Github-comments] [geany/geany-plugins] Workbench: fixed not closed file handles on directory scanning (thanks to techee). Fixes #607. (#608)

2017-10-04 Thread LarsGit223
@LarsGit223 pushed 1 commit. d417429 workbench: Initialize 'child' to prevent cppcheck warning. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany-plugins/pull/608/files/daa71c69ffd689e08f6b31cc0b67d4bf3adf4b9e

Re: [Github-comments] [geany/geany-plugins] Geany-scope blank window, inusable (#433)

2017-10-04 Thread LarsGit223
@zhekov: thanks for the fix :thumbsup: @elextr @kugel-: I can confirm that this also fixed the problem on my system. Are there any plans to merge this in the next time? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[Github-comments] [geany/geany-plugins] workbench: Increased required geany API version to 235 for usage of 'utils_get_real_path'. (#613)

2017-10-04 Thread LarsGit223
Nothing more to say. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/613 -- Commit Summary -- * workbench: Increased required geany API version to 235 for usage of 'utils_get_real_path'. -- File Changes -- M

[Github-comments] [geany/geany-plugins] projectorganizer: Increased required geany API version to 235 for usage of 'utils_get_real_path'. (#612)

2017-10-04 Thread LarsGit223
Nothing more to say. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/612 -- Commit Summary -- * projectorganizer: Increased required geany API version to 235 for usage of 'utils_get_real_path'. -- File Changes -- M

[Github-comments] [geany/geany-plugins] geanylua: Increased required geany API version to 235 for usage of 'utils_get_real_path'. (#611)

2017-10-04 Thread LarsGit223
Nothing more to say. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/611 -- Commit Summary -- * geanylua: Increased required geany API version to 235 for usage of 'utils_get_real_path'. -- File Changes -- M

Re: [Github-comments] [geany/geany] Cancel 'MSG_TYPE_RESAVE' info bar if still open in function 'document_reload_force'. (#1621)

2017-10-04 Thread LarsGit223
To what? Take the title from issue 1330? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1621#issuecomment-334210819

Re: [Github-comments] [geany/geany-plugins] projectorganizer: Replace deprecated tm_get_real_path(). (#609)

2017-10-03 Thread LarsGit223
Ok, thanks. Will do it for geanylua, projectorganizer and workbench soon (not today). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/609#issuecomment-333958003

[Github-comments] [geany/geany] Cancel 'MSG_TYPE_RESAVE' info bar if still open in function 'document_reload_force'. (#1621)

2017-10-03 Thread LarsGit223
Fixes #1330. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/1621 -- Commit Summary -- * Cancel 'MSG_TYPE_RESAVE' info bar if still open in function 'document_reload_force'. Fixes #1330. -- File Changes -- M src/document.c (4) --

Re: [Github-comments] [geany/geany] Geany hangs up when clicking 'replace and find' button in 'replace' dialog while the 'end of document' dialog is open (#1232)

2017-10-02 Thread LarsGit223
@orwell96: I also cannot reproduce this. Any news? Can this be closed? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1232#issuecomment-333649007

[Github-comments] [geany/geany-plugins] geanylua: Replace deprecated tm_get_real_path(). (#610)

2017-10-02 Thread LarsGit223
Nothing more to say. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/610 -- Commit Summary -- * geanylua: Replace deprecated tm_get_real_path(). -- File Changes -- M geanylua/glspi_app.c (2) M geanylua/gsdlg.c (4) --

[Github-comments] [geany/geany-plugins] projectorganizer: Replace deprecated tm_get_real_path(). (#609)

2017-10-02 Thread LarsGit223
Nothing more to say. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/609 -- Commit Summary -- * projectorganizer: Replace deprecated tm_get_real_path(). -- File Changes -- M projectorganizer/src/prjorg-project.c (6) -- Patch

[Github-comments] [geany/geany-plugins] Workbench: fixed not closed file handles on directory scanning (thanks to techee). Fixes #607. (#608)

2017-10-02 Thread LarsGit223
Nothing more to say. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/608 -- Commit Summary -- * Workbench: fixed not closed file handles on directory scanning (thanks to techee). Fixes #607. -- File Changes -- M

Re: [Github-comments] [geany/geany-plugins] Workbench: open file handles not closed on directory scanning (#607)

2017-10-02 Thread LarsGit223
Thanks for the notification. If I remember right the already fixed part was found by the guys during the code review. And yes, huge code parts are copied and modified from the ProjectOrganizer plugin. Basically everything regarding directory/file scanning. -- You are receiving this because

Re: [Github-comments] [geany/geany-plugins] New plugin 'workbench': initial commit. (Follow-up/clean PR) (#601)

2017-09-27 Thread LarsGit223
Cool :thumbsup: THANKS FOR ACCEPTING IT! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/601#issuecomment-332604767

Re: [Github-comments] [geany/geany-plugins] New plugin 'workbench': initial commit. (Follow-up/clean PR) (#601)

2017-09-21 Thread LarsGit223
I checked that before, they are fine. That are all calls to ```foreach_slist```, e.g. ``` static guint wb_project_get_file_count(WB_PROJECT *prj) { GSList *elem; guint filenum = 0; foreach_slist(elem, prj->directories) { filenum +=

Re: [Github-comments] [geany/geany-plugins] New plugin 'workbench': initial commit. (Follow-up/clean PR) (#601)

2017-09-20 Thread LarsGit223
Yes, I just did again because I do not remeber when I last checked it. No messages, seems to be OK (Only saw messages for plugin **xmlsnippets** but that's not my building site). One question: What exactly is make check doing? Do I need to install additional tools to get the full usage/checks?

Re: [Github-comments] [geany/geany-plugins] New plugin 'workbench': initial commit. (Follow-up/clean PR) (#601)

2017-09-20 Thread LarsGit223
LarsGit223 commented on this pull request. > +} + + +/* Create a branch for a folder */ +static void sidebar_create_branch(gint level, const gchar *abs_base_dir, GSList *leaf_list, GtkTreeIter *parent) +{ + GSList *dir_list = NULL; + GSList *file_list = NULL; + GSList *e

Re: [Github-comments] [geany/geany-plugins] New plugin 'workbench': initial commit. (Follow-up/clean PR) (#601)

2017-09-19 Thread LarsGit223
Just as a follow-up: I consider this PR as being in a good condition. If there are any more change-requests please let me know. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany-plugins] Auto-mark: highlights only words visible on screen (#294)

2017-09-12 Thread LarsGit223
> This is the reason - while using PdUp/PgDn for scrolling, you move cursor, > loosing current word selection. I have no idea how to fix that without > breaking other things. ohhh...of course :blush: So Issue 2 is the only one I can re-produce. @stosunek: do you encounter the problem if you

Re: [Github-comments] [geany/geany-plugins] New plugin 'workbench': initial commit. (Follow-up/clean PR) (#601)

2017-09-11 Thread LarsGit223
@LarsGit223 pushed 1 commit. 43b2cdf Fixed missing workbench files in POTFILES.in. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany-plugins/pull/601/files/fcc730087c947a003a8b0b21ed8f99404ab48b44

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-09-02 Thread LarsGit223
I close this one now, see follow-up PR #601. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/598#issuecomment-326732804

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-09-02 Thread LarsGit223
Closed #598. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/598#event-1232282600

[Github-comments] [geany/geany-plugins] New plugin 'workbench': initial commit. (Follow-up/clean PR) (#601)

2017-09-02 Thread LarsGit223
This is a new plugin called workbench. It has the following features: - assign multiple projects to a workbench - assign directories and file patterns to each project for easy file listing - create "global" workbench or project bookmarks to have quick access to often used files - the plugin

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-22 Thread LarsGit223
@codebrainz: thanks, just compiled with that list. The warnings that I get can be ignored. I saved the list to my wiki so I can't lose it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-21 Thread LarsGit223
> Thats why @b4n doesn't advise his option set and use it on Travis, the > results cannot be taken at face value, they need interpretation. Well, true for every warning I guess. It's always good to think about what you are doing :smile: In this case it looked like a inconsistency that was easy

Re: [Github-comments] [geany/geany-plugins] Auto-mark: highlights only words visible on screen (#294)

2017-08-21 Thread LarsGit223
I just found out that **Issue 2** is the intended/implemented behaviour. See ```automark/src/automark.c```, lines 116-118: ``` /* Do not highlight while selecting text and allow other markers to work */ if (sci_has_selection(sci)) return FALSE; ``` -- You are receiving this because you

Re: [Github-comments] [geany/geany-plugins] Auto-mark: highlights only words visible on screen (#294)

2017-08-21 Thread LarsGit223
I have an actual version installed/compiled and noticed the following: **This works well :white_check_mark::** - click on a word once - scroll with the mouse wheel - new occurrences of the word coming into the visible area are properly marked **This things do not seem to work :x:: Issue 1:** -

Re: [Github-comments] [geany/geany-plugins] Find in file not working in geany on ubuntu 16.04 (#593)

2017-08-21 Thread LarsGit223
@raghuirs: can this be closed? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/593#issuecomment-323810348

[Github-comments] [geany/geany] Added small description of G_GNUC_UNUSED macro. (#1582)

2017-08-21 Thread LarsGit223
Nothing more to say. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/1582 -- Commit Summary -- * Added small description of G_GNUC_UNUSED macro. -- File Changes -- M HACKING (5) -- Patch Links --

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-21 Thread LarsGit223
@b4n, @elextr: Thanks, fixed the warnings. @b4n: could you give me your CFLAGS list anyway please? It should be fixed but I did not get the warning about the sign change on the return values with using ```-Wall -Wextra``` only. -- You are receiving this because you are subscribed to this

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-21 Thread LarsGit223
@LarsGit223 pushed 1 commit. 9fecc2c Fixed missing NULL pointer check. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany-plugins/pull/598/files/d19678cdcf0c68dd7e578274016f367faa2b0dea

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-21 Thread LarsGit223
LarsGit223 commented on this pull request. > +} + + +/* Get the list of files for root */ +static GSList *wb_project_dir_get_file_list(WB_PROJECT_DIR *root, const gchar *utf8_path, GSList *patterns, + GSList *ignored_dirs_patterns, GSList *ignored_file_patterns, GHashTa

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-21 Thread LarsGit223
@LarsGit223 pushed 1 commit. d19678c Set attribute "text" instead of markup for "GtkCellRendererText". -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany-plugins/pull/598/files/01a8dfaa8627957e190d

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-21 Thread LarsGit223
@LarsGit223 pushed 1 commit. 01a8dfa Fixed more compiler warnings. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany-plugins/pull/598/files/bea0a0fcc811a80f6c4ecdc33b84fa5e82a76991..01a8dfaa8627957e190d89791cc7c942bb30e98b

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-21 Thread LarsGit223
@LarsGit223 pushed 1 commit. bea0a0f Suppress warnings for intentionally unused parameters in callback functions with G_GNUC_UNUSED. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany-plugins/pull/598/files

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-20 Thread LarsGit223
LarsGit223 commented on this pull request. > @@ -0,0 +1,20 @@ +icondir = $(datadir)/icons/hicolor/16x16/apps Fixed. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-20 Thread LarsGit223
@LarsGit223 pushed 1 commit. f7ba628 Fixed wrong dest directories (iconsdir) in sub-makefiles. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany-plugins/pull/598/files/6199a6bdb6be1bff9e8cd7fccb75311c7a5a2ac6

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-20 Thread LarsGit223
@b4n: which settings did you use? Where is the best place to change the compiler flags in the makefile? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/598#issuecomment-323648365

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-20 Thread LarsGit223
LarsGit223 commented on this pull request. > @@ -0,0 +1,20 @@ +icondir = $(datadir)/icons/hicolor/16x16/apps Ahrgh...stupid copy fault. Thanks. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/ge

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-20 Thread LarsGit223
LarsGit223 commented on this pull request. > @@ -0,0 +1,20 @@ +icondir = $(datadir)/icons/hicolor/16x16/apps See this screenshot: ![workbenchscreenshoticons](https://user-images.githubusercontent.com/9009011/29498420-402b400c-85fc-11e7-9374-4b985e082e53.png) I would like to have all ic

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-20 Thread LarsGit223
LarsGit223 commented on this pull request. > @@ -0,0 +1,20 @@ +icondir = $(datadir)/icons/hicolor/16x16/apps Yes, thanks. Works now. I added icons for 24x24, 32x32, 48x48 and scalable. The scalable icons are only symbolic which means they are painted in one color only (gray). Now I

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-20 Thread LarsGit223
@LarsGit223 pushed 1 commit. 6199a6b Also supply icons of the size 24x24, 32x32, 48x48 and scalable. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany-plugins/pull/598/files/2e09b553c495aeed36dfcd7e901ada5e4c7ba113

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-20 Thread LarsGit223
LarsGit223 commented on this pull request. > @@ -0,0 +1,10 @@ +AC_DEFUN([GP_CHECK_WORKBENCH], +[ +GP_ARG_DISABLE([Workbench], [auto]) +GP_COMMIT_PLUGIN_STATUS([Workbench]) +AC_CONFIG_FILES([ +workbench/Makefile +workbench/src/Makefile +workbench/ic

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-20 Thread LarsGit223
LarsGit223 commented on this pull request. > + return NULL; + } + g_snprintf(result, length+1, "%s%s", basedir, start); + + return result; +} + + +/** Get the relative path. + * + * The function examines the relative path of @a target in relation t

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-20 Thread LarsGit223
@LarsGit223 pushed 1 commit. 2e09b55 Re-factored "get_any_relative_path()": use "GPtrArray" to get rid of the limitation and fixed memory leaks. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany-pl

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-20 Thread LarsGit223
LarsGit223 commented on this pull request. > + basedir_end--; + } + if (*basedir_end == G_DIR_SEPARATOR) + { + *basedir_end = '\0'; + } + e

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-20 Thread LarsGit223
LarsGit223 commented on this pull request. > + * string with g_free(). + * + * @param base The absolute path. + * @param relative The relative path. + * @return Combined path or NULL if no memory is available + * + **/ +gchar *get_combined_path(const gchar *base, const gchar *relat

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-20 Thread LarsGit223
@LarsGit223 pushed 1 commit. 48c08cc Re-factored "get_combined_path()": now uses g_strconcat and handles all relative pathes. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany-plugins/pull

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-20 Thread LarsGit223
LarsGit223 commented on this pull request. > + wb_project_remove_bookmark(context.project, > context.prj_bookmark); + sidebar_update(SIDEBAR_CONTEXT_PRJ_BOOKMARK_REMOVED, ); + } +} + + +/** Setup/Initialize the popup menu. + * + **/ +void popup_menu_ini

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-20 Thread LarsGit223
@LarsGit223 pushed 1 commit. 8409530 Added mnemonics to popup menu. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany-plugins/pull/598/files/039d43f4b6c22e83a7ae4c673855b0077c478927..8409530f4fd49663396a8ad5bf74d023c8a5ddbf

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-20 Thread LarsGit223
LarsGit223 commented on this pull request. > + sidebar_update(SIDEBAR_CONTEXT_WB_CLOSED, NULL); +} + + +/** Setup the workbench menu. + * + **/ +gboolean menu_init(void) +{ + /* Create menu and root item/label */ + menu_data.menu = gtk_menu_new(); + menu_data.root_i

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-20 Thread LarsGit223
@LarsGit223 pushed 1 commit. 039d43f Added ellipses (…) to "New", "Open", "Add project" and "Add directory". -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany-plugins/pull/598/files/

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-20 Thread LarsGit223
LarsGit223 commented on this pull request. > @@ -0,0 +1,20 @@ +icondir = $(datadir)/icons/hicolor/16x16/apps (I will now be AFK for about an hour) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/ge

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-20 Thread LarsGit223
LarsGit223 commented on this pull request. > @@ -0,0 +1,20 @@ +icondir = $(datadir)/icons/hicolor/16x16/apps I had a look again and changed my opinion: the directories in geany look clean and simple so I tried starting to do it that way, @codebrainz: thanks for the link. But I can't

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-20 Thread LarsGit223
LarsGit223 commented on this pull request. > + + if (wb_globals.opened_wb == NULL) + { + gtk_label_set_text (GTK_LABEL(sidebar.file_view_label), _("No workbench opened.")); + gtk_tree_store_clear(sideb

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-20 Thread LarsGit223
@LarsGit223 pushed 1 commit. ed27167 Made sidebar title translateable. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany-plugins/pull/598/files/145476a3ca111790b3fa3885652c0e2dfb39d579

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-20 Thread LarsGit223
LarsGit223 commented on this pull request. > + check = g_key_file_get_string (kf, "General", > "filetype", error); + if (check == NULL || g_strcmp0(check, "workbench") != 0) + { +

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-20 Thread LarsGit223
@LarsGit223 pushed 1 commit. 145476a Made message "File %s is not a valid workbench file!" translateable and translated it to german. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany-plugins/pull

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-20 Thread LarsGit223
LarsGit223 commented on this pull request. > + gtk_tree_view_column_pack_start(column, renderer, FALSE); + gtk_tree_view_column_add_attribute(column, renderer, "gicon", FILEVIEW_COLUMN_ICON); + + renderer = gtk_cell_renderer_text_new(); + gtk_tree_view_colu

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-20 Thread LarsGit223
@LarsGit223 pushed 1 commit. 6d8d2d8 Use "ui_widget_modify_font_from_string()" to change the workbench sidebar font. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany-plugins/pull

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-20 Thread LarsGit223
LarsGit223 commented on this pull request. > +} MatchType; + +typedef struct +{ + GeanyProject *project; + GPtrArray *expanded_paths; +} ExpandData; + +typedef struct SIDEBAR +{ +GtkWidget *file_view_vbox; +GtkWidget *file_view; +GtkTreeStore *file_store; +GtkWid

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-20 Thread LarsGit223
@LarsGit223 pushed 1 commit. 316e11f Fixed too many initializers. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany-plugins/pull/598/files/eaa9265e004da995d69f8e32d7c875a310564720..316e11fe59212483ca0117375984e3a261bed089

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-20 Thread LarsGit223
LarsGit223 commented on this pull request. > + + +/** Setup the workbench menu. + * + **/ +gboolean menu_init(void) +{ + /* Create menu and root item/label */ + menu_data.menu = gtk_menu_new(); + menu_data.root_item = gtk_menu_item_new_with_label(_("W

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-20 Thread LarsGit223
@LarsGit223 pushed 1 commit. eaa9265 Replaced deprecated "gtk_menu_append()" with "gtk_menu_shell_append()". -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany-plugins/pull/598/files/fa350235bca60f53d98b

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-20 Thread LarsGit223
LarsGit223 commented on this pull request. > @@ -3405,7 +3405,7 @@ msgstr "" msgid "Toggle Insert/Overwrite mode" Yes, I tried to restore the not changed translation files to the original state but that did not work. The only really changed file is ```po/de.po```. May

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-20 Thread LarsGit223
LarsGit223 commented on this pull request. > + > G_CALLBACK(item_workbench_settings_activate_cb), NULL); + geany_plugin_set_data(wb_globals.geany_plugin, menu_data.item_settings, NULL); + + /* Create new menu item "Clos

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-20 Thread LarsGit223
@LarsGit223 pushed 1 commit. fa35023 Attach workbench menu to the tools menu, not to the main menu bar. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany-plugins/pull/598/files/be25badfa35f1ebcf90f1b9de7d76bc107f1fa95

Re: [Github-comments] [geany/geany-plugins] Use "g_return_val_if_fail()" instead of producing an own error message. (109b8d0)

2017-08-20 Thread LarsGit223
:smile: No problem. Maybe we should open a new ticket as a discussion of this point. The goal for me would be to find a common way that every one can agree to and probably could become part of the coding guidelines. -- You are receiving this because you are subscribed to this thread. Reply to

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-19 Thread LarsGit223
Enough work for today. Sorry for all the messages/noise :wink: -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/598#issuecomment-323536459

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-19 Thread LarsGit223
LarsGit223 commented on this pull request. > + { + g_free (bookmarks_strings[index]); + } + g_free(bookmarks_strings); + } + + /* Save projects d

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-19 Thread LarsGit223
@LarsGit223 pushed 1 commit. be25bad Make sure to not continue if "g_key_file_to_data()" fails (especially do not re-use "error"). -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany-pl

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-19 Thread LarsGit223
LarsGit223 commented on this pull request. > + abs_path = > get_combined_path(prj->filename, *file); + if (abs_pat

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-19 Thread LarsGit223
@LarsGit223 pushed 1 commit. 9c90b80 Removed useless/duplicate check. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany-plugins/pull/598/files/c24fe00d8a8c8bbf488c5ddd6d885e27ab4844d9

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-19 Thread LarsGit223
LarsGit223 commented on this pull request. > + pos += g_snprintf(&(text[pos]), sizeof(text)-pos, _("Number of Files: > %u\n"), dir->file_count); + + return g_strdup(text); +} + + +/** Get an info string for the project. + * + * @param prj The project + *

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-19 Thread LarsGit223
LarsGit223 commented on this pull request. > + } +return FALSE; +} + + +/** Get an info string for the project dir. + * + * @param dir The project dir + * @return The info string + * + **/ +gchar *wb_project_dir_get_info (WB_PROJECT_DIR *dir) +{ + guint pos = 0; + gchar *

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-19 Thread LarsGit223
@LarsGit223 pushed 1 commit. c24fe00 Restored accidentally deleted strings. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany-plugins/pull/598/files/6aa0b70305f8418a4608fe5d2aaff8e6a7a8d664

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-19 Thread LarsGit223
@LarsGit223 pushed 1 commit. 6aa0b70 Use "GString" instead of "g_snprintf()" in "wb_project_get_info()". -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany-plugins/pull/598/files/f67c194006

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-19 Thread LarsGit223
@LarsGit223 pushed 1 commit. f67c194 Use "GString" instead of "g_snprintf()" in "wb_project_dir_get_info()". -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany-plugins/pull/598/files/bfa86623d6

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-19 Thread LarsGit223
@LarsGit223 pushed 1 commit. bfa8662 Use "GString" instead of doing manual string manipulation in "sidebar_insert_all_projects()". -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany-pl

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-19 Thread LarsGit223
LarsGit223 commented on this pull request. > + sidebar_show_intro_message(_("Create or open a workbench\nusing > the workbench menu."), FALSE); + sidebar_deactivate(); + } + else + { + gint length; +

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-19 Thread LarsGit223
LarsGit223 commented on this pull request. > + == + PROJECT_ENTRY_STATUS_OK) + { + icon = icon_ok; + } + else + { + icon = icon

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-19 Thread LarsGit223
LarsGit223 commented on this pull request. > + return; + + if (sidebar_get_project_iter(project, )) + { + gint length, position; + gchar text[200]; + + length = g_snprintf(text, sizeof(text), "%s", wb_project_get

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-19 Thread LarsGit223
@LarsGit223 pushed 1 commit. 6560f6b Merged "sidebar_update_project()" and "sidebar_update_project_title()" into one function and revised string usage. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/ge

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-19 Thread LarsGit223
LarsGit223 commented on this pull request. > + GtkTreeIter iter; + + if (wb_globals.opened_wb == NULL) + return; + + if (sidebar_get_project_iter(project, )) + { + gint length; + gchar text[200]; + + len

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-19 Thread LarsGit223
LarsGit223 commented on this pull request. > +/** Cleanup menu data/mem. + * + **/ +void menu_cleanup (void) +{ + gtk_container_remove (GTK_CONTAINER(ui_lookup_widget(wb_globals.geany_plugin->geany_data->main_widgets->window

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-19 Thread LarsGit223
LarsGit223 commented on this pull request. > + GError *error = NULL; + + filename = dialogs_create_new_workbench(); + if (filename == NULL) + { + return; + } + wb_globals.opened_wb = workbench_new(); + workbench_set_filen

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-19 Thread LarsGit223
@LarsGit223 pushed 1 commit. c20dc6f Re-factored control of menu item activation and de-activation. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany-plugins/pull/598/files/4ae4580c1cc848f80250bf1b3848efd40c9c701c

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-19 Thread LarsGit223
LarsGit223 commented on this pull request. > + gtk_menu_item_set_submenu(GTK_MENU_ITEM(menu_data.root_item), > menu_data.menu); + gtk_menu_shell_insert + (GTK_MENU_SHELL (ui_lookup_widget(wb_globals.geany_plugin->geany_data->main_widgets->win

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-19 Thread LarsGit223
@LarsGit223 pushed 1 commit. 4ae4580 Use "gtk_widget_destroy()" to clean up workbench menu. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany-plugins/pull/598/files/d6993d836816239e45bf55dacd5b14

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-19 Thread LarsGit223
LarsGit223 commented on this pull request. > + **/ +gboolean dialogs_directory_settings(WB_PROJECT_DIR *directory) +{ + GtkWidget *w_file_patterns, *w_ignored_dirs_patterns, *w_ignored_file_patterns; + GtkWidget *dialog, *label, *content_area; + GtkWidget *vbox, *hbox, *hb

Re: [Github-comments] [geany/geany-plugins] Workbench (#598)

2017-08-19 Thread LarsGit223
LarsGit223 commented on this pull request. > + **/ +gboolean dialogs_directory_settings(WB_PROJECT_DIR *directory) +{ + GtkWidget *w_file_patterns, *w_ignored_dirs_patterns, *w_ignored_file_patterns; + GtkWidget *dialog, *label, *content_area; + GtkWidget *vbox, *hbox, *hb

<    3   4   5   6   7   8   9   >