[Github-comments] Re: [geany/geany-plugins] Vimode: implement fold in vimode plugin (PR #1350)

2024-05-27 Thread cresto sylvain via Github-comments
Thanks -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1350#issuecomment-2132802179 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Vimode: implement fold in vimode plugin (PR #1350)

2024-05-25 Thread cresto sylvain via Github-comments
OK I did it -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1350#issuecomment-2131158773 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Vimode: handle fold and margin click event (PR #1349)

2024-05-25 Thread cresto sylvain via Github-comments
Thanks -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1349#issuecomment-2131149543 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] New IncDec plugin for Geany (PR #1351)

2024-05-24 Thread cresto sylvain via Github-comments
@scresto09 pushed 1 commit. 5889910191ed1fa066bd7e188a9032b41ab6e859 incdec: fix POTFILES.in -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1351/files/3edee2d32694a62cc515fba4082ea87d875a38d2..5889910191ed1fa066bd7e188a9032b41ab6e859 You are receiving this because you are

[Github-comments] Re: [geany/geany-plugins] New IncDec plugin for Geany (PR #1351)

2024-05-24 Thread cresto sylvain via Github-comments
This pull request replace previous #1337 -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1351#issuecomment-2129567565 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] [geany/geany-plugins] New IncDec plugin for Geany (PR #1351)

2024-05-24 Thread cresto sylvain via Github-comments
IncDec is a plugin for Geany that provides shortcuts to increment an decrement number at the cursor, or to the right of the cursor (on the same line). By default, typing **Shift-+** will increment the next number, and typing **Shift--** will decrement the next number. You can also increment and

[Github-comments] Re: [geany/geany-plugins] Vimode: handle fold and margin click event (PR #1349)

2024-05-24 Thread cresto sylvain via Github-comments
Is it better now ? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1349#issuecomment-2129425609 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Vimode: handle fold and margin click event (PR #1349)

2024-05-24 Thread cresto sylvain via Github-comments
@scresto09 pushed 1 commit. fade2b75401f0ef57486ef93ea854d7ff226b211 Vimode: handle fold and margin click event -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1349/files/d861058c49959d619f73d65c956452b2e4cfdefb..fade2b75401f0ef57486ef93ea854d7ff226b211 You are receiving

[Github-comments] Re: [geany/geany-plugins] Vimode: handle fold and margin click event (PR #1349)

2024-05-24 Thread cresto sylvain via Github-comments
@scresto09 pushed 1 commit. d861058c49959d619f73d65c956452b2e4cfdefb Vimode: handle fold and margin click event -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1349/files/ba05577f6b60489bad1f7dafc0680666398bf5f2..d861058c49959d619f73d65c956452b2e4cfdefb You are receiving

[Github-comments] Re: [geany/geany-plugins] Vimode: implement fold in vimode plugin (PR #1350)

2024-05-24 Thread cresto sylvain via Github-comments
Previous pull request #1327 -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1350#issuecomment-2129195678 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Vimode: Added folding support (PR #1327)

2024-05-24 Thread cresto sylvain via Github-comments
Sorry, I made a mistake and this closed this pull request... I just created a new pull request [#1350](https://github.com/geany/geany-plugins/pull/1350) with all these changes.. sorry! -- Reply to this email directly or view it on GitHub:

[Github-comments] [geany/geany-plugins] Vimode: implement fold in vimode plugin (PR #1350)

2024-05-24 Thread cresto sylvain via Github-comments
Supported commands are: za / zo / zc toggle / open / close fold on one level of folding zA / zO / zC toggle / open / close fold on all folding levels zR / zM open / close all folds You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1350

[Github-comments] Re: [geany/geany-plugins] New IncDec plugin for Geany (PR #1337)

2024-05-23 Thread cresto sylvain via Github-comments
Closed #1337. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1337#event-12909308573 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] New IncDec plugin for Geany (PR #1337)

2024-05-23 Thread cresto sylvain via Github-comments
@scresto09 pushed 0 commits. -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1337/files/df38e23bc2f0a256157371f8efd0dc7729217355..644550babb52013d2625a3f8e789bbe94a335b6f You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Vimode: Added folding support (PR #1327)

2024-05-23 Thread cresto sylvain via Github-comments
Closed #1327. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1327#event-12908283439 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Vimode: Added folding support (PR #1327)

2024-05-23 Thread cresto sylvain via Github-comments
@scresto09 pushed 0 commits. -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1327/files/e0252c96bc17c21d1f9723cfa8e89fbb021644ad..0e299a898165cedfc8010d1ae43fa14a0c9f8e00 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Vimode: Added folding support (PR #1327)

2024-05-23 Thread cresto sylvain via Github-comments
@scresto09 pushed 1 commit. e0252c96bc17c21d1f9723cfa8e89fbb021644ad Vimode: constants and functions renamed and README completed -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1327/files/c902da4df5df85fcbcb2bd6a2d8048480635ebc7..e0252c96bc17c21d1f9723cfa8e89fbb021644ad You

[Github-comments] Re: [geany/geany-plugins] Vimode: handle fold and margin click event (PR #1349)

2024-05-22 Thread cresto sylvain via Github-comments
@scresto09 pushed 1 commit. 2c473da72b5eb9ebf9b54e02e60682697c46140f Merge branch 'master' into vimode-handle-fold-marginclick -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1349/files/0105a26a29b7dadb71c8703e47dfd63b287f9b14..2c473da72b5eb9ebf9b54e02e60682697c46140f You

[Github-comments] Re: [geany/geany-plugins] Vimode: handle fold and margin click event (PR #1349)

2024-05-22 Thread cresto sylvain via Github-comments
@scresto09 pushed 1 commit. 0105a26a29b7dadb71c8703e47dfd63b287f9b14 Formatting issue -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1349/files/7ecdbba5a39e3f7b91e4debf95e44eeacc267b67..0105a26a29b7dadb71c8703e47dfd63b287f9b14 You are receiving this because you are

[Github-comments] Re: [geany/geany-plugins] New IncDec plugin for Geany (PR #1337)

2024-05-22 Thread cresto sylvain via Github-comments
@scresto09 pushed 0 commits. -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1337/files/69a08680c5037816226d3f00a488e2b38c81ec2c..7615fdcdeae24739d65ddf42554fcaf48a380d82 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Vimode: Fix cursor hang with folded lines (PR #1326)

2024-05-22 Thread cresto sylvain via Github-comments
OK, I just create #1349 for SCN_MARGINCLICK part. Thanks -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1326#issuecomment-2124751106 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] vimode: Handle folded lines correctly (PR #1338)

2024-05-22 Thread cresto sylvain via Github-comments
I just create #1349 for SCN_MARGINCLICK part. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1338#issuecomment-2124750459 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] [geany/geany-plugins] Vimode: handle fold and margin click event (PR #1349)

2024-05-22 Thread cresto sylvain via Github-comments
Automatically set the cursor position on the visible line on SCN_MARGINCLICK event You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1349 -- Commit Summary -- * Vimode: handle fold and margin click event -- File Changes -- M

[Github-comments] Re: [geany/geany-plugins] vimode: Handle folded lines correctly (PR #1338)

2024-05-22 Thread cresto sylvain via Github-comments
OK, it's works fine, thanks -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1338#issuecomment-2124413450 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Vimode: Added folding support (PR #1327)

2024-05-22 Thread cresto sylvain via Github-comments
OK, I tried to make some changes to improve fold support and react more like vim. With za/zo/zc we fold the current block as before. With zA we change the fold depending on the state of the parent, if there is one that is contracted we expand it otherwise we contract it. I was unable to

[Github-comments] Re: [geany/geany-plugins] Vimode: Added folding support (PR #1327)

2024-05-22 Thread cresto sylvain via Github-comments
@scresto09 pushed 3 commits. c5e4c30b9a8e2eef9bbc6a7ba9c3516e1b6b33a3 Move fold functions to fold.c/fold.h files c9e04135595b28fc2390d156b9686621b2d6dd24 Merge branch 'vimode-fold-support' of https://github.com/scresto09/geany-plugins into vimode-fold-support

[Github-comments] Re: [geany/geany-plugins] Vimode: Added folding support (PR #1327)

2024-05-22 Thread cresto sylvain via Github-comments
@scresto09 pushed 1 commit. 904ee74be16f74c9cd0173353c224497c87b861e Merge branch 'geany:master' into vimode-fold-support -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1327/files/cd00fbc84dc0480e6a7b9e3c8a934225057fc051..904ee74be16f74c9cd0173353c224497c87b861e You are

[Github-comments] Re: [geany/geany-plugins] Vimode: fix cursor position after using undo (PR #1328)

2024-05-22 Thread cresto sylvain via Github-comments
OK, I did it, is it okay? Thanks -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1328#issuecomment-2124232024 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Vimode: fix cursor position after using undo (PR #1328)

2024-05-21 Thread cresto sylvain via Github-comments
@scresto09 commented on this pull request. > @@ -162,14 +163,14 @@ void cmd_del_word_left(CmdContext *c, CmdParams *p) void cmd_undo(CmdContext *c, CmdParams *p) { gint i; - gint pos = SSM(p->sci, SCI_GETCURRENTPOS, 0, 0); + start_undo(c); for (i = 0; i < p->num;

[Github-comments] Re: [geany/geany-plugins] Vimode: fix cursor position after using undo (PR #1328)

2024-05-21 Thread cresto sylvain via Github-comments
@scresto09 pushed 1 commit. 63b7e25242e485448c81185eadabab38d7a65b52 Refactor the code to take into account the latest comments -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1328/files/1be4e6adeb28c19ac35c9a9682d21c35f08532f3..63b7e25242e485448c81185eadabab38d7a65b52 You

[Github-comments] Re: [geany/geany-plugins] Vimode: fix cursor position after using undo (PR #1328)

2024-05-17 Thread cresto sylvain via Github-comments
@scresto09 pushed 1 commit. 1be4e6adeb28c19ac35c9a9682d21c35f08532f3 added two empty lines -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1328/files/2b99b719de64166b3833280a5ba0c1fdf00c6a4c..1be4e6adeb28c19ac35c9a9682d21c35f08532f3 You are receiving this because you are

[Github-comments] Re: [geany/geany-plugins] Vimode: fix cursor position after using undo (PR #1328)

2024-05-17 Thread cresto sylvain via Github-comments
@scresto09 commented on this pull request. > @@ -162,14 +163,14 @@ void cmd_del_word_left(CmdContext *c, CmdParams *p) void cmd_undo(CmdContext *c, CmdParams *p) { gint i; - gint pos = SSM(p->sci, SCI_GETCURRENTPOS, 0, 0); + start_undo(c); for (i = 0; i < p->num;

[Github-comments] Re: [geany/geany-plugins] Vimode: fix cursor position after using undo (PR #1328)

2024-05-17 Thread cresto sylvain via Github-comments
@scresto09 pushed 1 commit. 2b99b719de64166b3833280a5ba0c1fdf00c6a4c used goto_nonempty to go to the first non-white character and some more changes -- View it on GitHub:

[Github-comments] Re: [geany/geany-plugins] Vimode: Fix cursor hang with folded lines (PR #1326)

2024-05-14 Thread cresto sylvain via Github-comments
@scresto09 commented on this pull request. > return; - /* see cmd_goto_up() for explanation */ - one_above = p->line + num - 1; - one_above = one_above < last_line ? one_above : last_line - 1; - pos = SSM(p->sci, SCI_GETLINEENDPOSITION, one_above, 0); -

[Github-comments] Re: [geany/geany-plugins] Vimode: Fix cursor hang with folded lines (PR #1326)

2024-05-13 Thread cresto sylvain via Github-comments
@scresto09 commented on this pull request. > /* Calling SCI_LINEUP/SCI_LINEDOWN in a loop for num lines leads to > visible * slow scrolling. On the other hand, SCI_LINEUP preserves the value of * SCI_CHOOSECARETX which we cannot read directly from Scintilla and which

[Github-comments] Re: [geany/geany-plugins] Vimode: fix cursor position after using undo (PR #1328)

2024-05-13 Thread cresto sylvain via Github-comments
You're right, my previous correction was not correct. [327cdde](https://github.com/geany/geany-plugins/pull/1328/commits/327cdde2d506400ad6e05342c0d6095e9c254e0e) is a new fix using the SC_MOD_BEFOREINSERT and SC_PERFORMED_UNDO events to save the cursor position. -- Reply to this email

[Github-comments] Re: [geany/geany-plugins] Vimode: fix cursor position after using undo (PR #1328)

2024-05-13 Thread cresto sylvain via Github-comments
@scresto09 pushed 1 commit. 327cdde2d506400ad6e05342c0d6095e9c254e0e use SC_MOD_BEFOREINSERT and SC_PERFORMED_UNDO events to track cursor position to restore after undo -- View it on GitHub:

[Github-comments] Re: [geany/geany-plugins] vimode: Handle folded lines correctly (PR #1338)

2024-05-07 Thread cresto sylvain via Github-comments
It seems there are some issues with the changes in commit [907b9bc](https://github.com/geany/geany-plugins/pull/1338/commits/907b9bc9830e601119e1d9df9d39848c3f697932), for example the cursor can no longer go up to the first line, or when some lines wrap. I've made some changes to try and fix

[Github-comments] Re: [geany/geany-plugins] vimode: Handle folded lines correctly (PR #1338)

2024-05-07 Thread cresto sylvain via Github-comments
Hello, After read the [https://sourceforge.net/p/scintilla/bugs/2438/](https://sourceforge.net/p/scintilla/bugs/2438/) report, I think the best way to automatically set the cursor position on the visible line is surely to track the SCN_MARGINCLICK event. I did some modification to handle this

[Github-comments] Re: [geany/geany-plugins] Vimode: Fix cursor hang with folded lines (PR #1326)

2024-05-07 Thread cresto sylvain via Github-comments
@scresto09 pushed 1 commit. 274ff97f51e65b02ae86579768ec8d41f5b5c611 try to fix some issues of the plugin with folded lines -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1326/files/5608b74cba25b571428da9a055e696ddb053a247..274ff97f51e65b02ae86579768ec8d41f5b5c611 You are

[Github-comments] Re: [geany/geany-plugins] Vimode: Fix cursor hang with folded lines (PR #1326)

2024-05-07 Thread cresto sylvain via Github-comments
In response to pull request [#1338](https://github.com/geany/geany-plugins/pull/1338) After read the [https://sourceforge.net/p/scintilla/bugs/2438/](https://sourceforge.net/p/scintilla/bugs/2438/) report, I think the best way to automatically set the cursor position on the visible line is

[Github-comments] Re: [geany/geany-plugins] Vimode: Fix cursor hang with folded lines (PR #1326)

2024-05-07 Thread cresto sylvain via Github-comments
@scresto09 pushed 1 commit. 5608b74cba25b571428da9a055e696ddb053a247 Automatically set the cursor position on the visible line -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1326/files/be15445fa3fd4893f04945af6af94522db2e5e99..5608b74cba25b571428da9a055e696ddb053a247 You

[Github-comments] Re: [geany/geany-plugins] Vimode: fix cursor position after using undo (PR #1328)

2024-04-25 Thread cresto sylvain via Github-comments
Sure, here's an example: Open a 5 line file Move the cursor to line 2 press "2dd" to delete 2 lines press "u" to cancel With a real VIM, the cursor stays on line 2 With Geany Vimode not patched, the cursor goes to the last line -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany-plugins] New IncDec plugin for Geany (PR #1337)

2024-04-25 Thread cresto sylvain via Github-comments
@scresto09 pushed 1 commit. 7615fdcdeae24739d65ddf42554fcaf48a380d82 Update README and geany-plugins.nsi files -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1337/files/1a06f6b2c2336da69fbfa1a035d6f4640cfd6f4f..7615fdcdeae24739d65ddf42554fcaf48a380d82 You are receiving this

[Github-comments] [geany/geany-plugins] New IncDec plugin for Geany (PR #1337)

2024-04-25 Thread cresto sylvain via Github-comments
IncDec is a plugin for Geany that provides shortcuts to increment an decrement number at the cursor, or to the right of the cursor (on the same line). By default, typing Shift-+ will increment the next number, and typing Shift-- will decrement the next number. You can also increment and

[Github-comments] [geany/geany-plugins] Vimode: fix cursor position after using undo (PR #1328)

2024-04-16 Thread cresto sylvain via Github-comments
Trying to get more Vim-like behavior for cursor position after using undo (U key) You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1328 -- Commit Summary -- * fix cursor position after using undo (u key) -- File Changes -- M

[Github-comments] [geany/geany-plugins] Vimode: Added folding support (PR #1327)

2024-04-16 Thread cresto sylvain via Github-comments
Supported commands are: za / zo / zc toggle / open / close fold on one level of folding zA / zO / zCtoggle / open / close fold on all folding levels zR / zM open / close all folds You can view, comment on, or merge this pull request online at:

[Github-comments] Re: [geany/geany-plugins] Fix cursor hang with folded lines (PR #1326)

2024-04-16 Thread cresto sylvain via Github-comments
Reopened #1326. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1326#event-12486535931 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Fix cursor hang with folded lines (PR #1326)

2024-04-15 Thread cresto sylvain via Github-comments
Closed #1326. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1326#event-12472026207 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] [geany/geany-plugins] Fix cursor hang with folded lines (PR #1326)

2024-04-15 Thread cresto sylvain via Github-comments
Fix cursor hang when we want to move cursor on top line and this line is folded To reproduce the problem, when vimode plugin is enabled: Fold a few lines by clicking the minus icon. Move the cursor to the bottom of these lines and try to move back to the top. The cursor doesnt go back and seem to