Re: [Github-comments] [geany/geany] "Find in files" output really messy for long-line matches (#2247)

2019-09-10 Thread Chris Graham
Agreed, that makes more sense. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2247#issuecomment-530174540

Re: [Github-comments] [geany/geany] "Find in files" output really messy for long-line matches (#2247)

2019-09-10 Thread elextr
Thanks for the patch, but why not pass 1024 to `stdout_max_length` when spawn is called to run programs displaying in the message window rather than add yet another mysterious constant to _every_ call to spawn? -- You are receiving this because you are subscribed to this thread. Reply to this

Re: [Github-comments] [geany/geany] "Find in files" output really messy for long-line matches (#2247)

2019-09-10 Thread Chris Graham
(Thanks for all your replies to my issues @elextr - I know I've been posting a lot and fixing nothing myself, but I have too many backlogged commitments right now to start making pull requests.) This patch resolves the problem, simply by matching the spawn API line limit to the messaging

Re: [Github-comments] [geany/geany] "Find in files" output really messy for long-line matches (#2247)

2019-08-07 Thread elextr
See comments [here](https://github.com/geany/geany/blob/21b06d1e4bf18f2cab137ab08a976dbf14274d58/src/msgwindow.c#L458). Fixes welcome. Unfortunately the grep is not run in a shell, so piping to cut isn't possible. -- You are receiving this because you are subscribed to this thread. Reply to

[Github-comments] [geany/geany] "Find in files" output really messy for long-line matches (#2247)

2019-08-07 Thread Chris Graham
If long lines are matched (e.g. in binary or minified files) then 2 bad things happen... 1) An internal buffer apparently crops each line, before the length of the line grepping is wrapping to (apparently) 2) Subsequent lines which grep has wrapped then show on separate lines The result is a