LGBI
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1572#issuecomment-320168043
elextr approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1572#pullrequestreview-54288742
elextr commented on this pull request.
> + case SC_STATUS_BADALLOC:
+ sub_msg = "memory is exhausted";
+ break;
+ case SC_STATUS_WARN_REGEX:
+ sub_msg = "regular
Note that no public API is changed by this PR, so if similar checks are desired
inside of plugins (core or otherwise) it should be done as a separate PR.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Now it's showing like this:
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
The debug message is fixed in last commit, was using 64-bit instead of 32-bit
placeholders in printf string. Also changed it to use a literal for the format
string.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@codebrainz pushed 1 commit.
13d8d94 Fix message formatting string
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/geany/geany/pull/1572/files/c88bbc8e9cf491833341dc19b1d34ab7f71ee89b..13d8d942263f5ef4df97045b0e58051f9c228b0f
codebrainz commented on this pull request.
> @@ -42,7 +42,51 @@
#include
-#define SSM(s, m, w, l) scintilla_send_message(s, m, w, l)
+#ifndef NDEBUG
+
FIXME: spurious line break
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it
I'm not sure why it doesn't output ": memory is exhausted" at the end of the
debug message. Maybe because it's freaking out due to no memory?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
A quick test built with msys2 32-bit gives this kind of output:
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on
@codebrainz nice.
This is going to need people with 32 bit systems to test, 64 bit systems will
start swapping and get unusabley slow waaay before they fail allocation (found
that when trying #1540 :)
--
You are receiving this because you are subscribed to this thread.
Reply to this email
Partially resolves, or improves debugging for #1569.
In the future we could give better feedback to the user by showing a dialog or
something.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/1572
-- Commit Summary --
* Remove redundant
12 matches
Mail list logo
