Closed in 4a60cdd12727f8f252a3e0d6921e26377ef84904
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1224#issuecomment-320219614
Closed #1224.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1224#event-1192947093
I'm fine with this.
However, I would support the idea of moving the implementation into
`src/utils.c` as it is where it should live after any deprecation.
And of course, updating Geany and API version.
--
You are receiving this because you are subscribed to this thread.
Reply to this email
What about this?
(On a related note, our `realpath()` implementation for win32, called by
`tm_get_real_path()` is buggy, see #1534)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Sorry @techee I misread :)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1224#issuecomment-281952301
@elextr As I said, for 1.31, not 1.30.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1224#issuecomment-281950577
@techee it would be nice to get it done, but since its now only just over a
week to release IMHO no more changes other than bugfixes should be included.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Would be nice to stop incrementing the target release get this finally merged
in 1.31. I believe the only thing that @b4n requested was updating the API in
the docstring which should now be 1.31. @codebrainz could you make this change?
--
You are receiving this because you are subscribed to
Moved to 1.31
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1224#issuecomment-281868370
Okay if you want, we can always move the implementation later.
The API version should be fixed, because it won't merge cleanly as is (no idea
why GitHub doesn't complain BTW).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on
codebrainz commented on this pull request.
> @@ -42,7 +42,11 @@ TMSourceFile *tm_source_file_new(const char *file_name,
> const char *name);
void tm_source_file_free(TMSourceFile *source_file);
-gchar *tm_get_real_path(const gchar *file_name);
+gchar *tm_get_real_path(const gchar
b4n commented on this pull request.
> @@ -42,7 +42,11 @@ TMSourceFile *tm_source_file_new(const char *file_name,
> const char *name);
void tm_source_file_free(TMSourceFile *source_file);
-gchar *tm_get_real_path(const gchar *file_name);
+gchar *tm_get_real_path(const gchar *file_name)
codebrainz commented on this pull request.
> @@ -42,7 +42,11 @@ TMSourceFile *tm_source_file_new(const char *file_name,
> const char *name);
void tm_source_file_free(TMSourceFile *source_file);
-gchar *tm_get_real_path(const gchar *file_name);
+gchar *tm_get_real_path(const gchar
b4n commented on this pull request.
Otherwise, LGTM
> @@ -42,7 +42,11 @@ TMSourceFile *tm_source_file_new(const char *file_name,
> const char *name);
void tm_source_file_free(TMSourceFile *source_file);
-gchar *tm_get_real_path(const gchar *file_name);
+gchar *tm_get_real_path(const gchar
elextr commented on this pull request.
LGBI
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1224#pullrequestreview-466340
If there are no objections, I will merge this "soon".
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1224#issuecomment-247817059
@codebrainz pushed 1 commit.
0370112 Mark tm_get_real_path with G_DEPRECATED_FOR
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
This is a wrapper around `tm_get_real_path()` but is in a more suitable
namespace/module.
I think it makes more sense like this. I typically dislike adding
general-purpose functions to the API, but since Glib doesn't provide any
equivalent, it really is useful.
You can view, comment on, or
18 matches
Mail list logo
