Re: [Github-comments] [geany/geany] Added template file for CSS (#2259)

2019-10-02 Thread Matthew Brush
Closing due to lack of interest, feel free to re-open if anyone feeling strongly comes along. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2259#issuecomment-537766585

Re: [Github-comments] [geany/geany] Added template file for CSS (#2259)

2019-10-02 Thread Matthew Brush
Closed #2259. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2259#event-2682645008

Re: [Github-comments] [geany/geany] Added template file for CSS (#2259)

2019-10-02 Thread elextr
IMO @codebrainz said it above. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2259#issuecomment-537720973

Re: [Github-comments] [geany/geany] Added template file for CSS (#2259)

2019-10-02 Thread LarsGit223
@b4n, @codebrainz, @elextr: ping. What's the final decission? Merge or close it unmerged? I'm fine with both, just want to get the ticket done. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany] Added template file for CSS (#2259)

2019-09-02 Thread Gregor Santner
Isn't there some kind of Geany "user resources" forum / wiki where users upload filedefs, templates, ctags etc? I think this would fit well there. This doesn't add any bloat (as per my understanding what this discussion is about^^) to Geany. -- You are receiving this because you are

Re: [Github-comments] [geany/geany] Added template file for CSS (#2259)

2019-08-15 Thread Matthew Brush
If nobody except @franco999 in 2015, including this pull requestor, is convinced this is useful, then I guess it should be closed? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany] Added template file for CSS (#2259)

2019-08-15 Thread Colomban Wendling
I still don't have a strong opinion, but as is the file doesn't seem very useful. I tend to agree with @codebrainz, mostly because in 2019 it's likely user CSS will add rules on top of a framework, and if it's not it's likely be to either highly complex or very simple. If we suppose very

Re: [Github-comments] [geany/geany] Added template file for CSS (#2259)

2019-08-13 Thread LarsGit223
Yeah, I don't feel strong on this one either. In the original post it seemed to be reasonable for some people. The original PR is already 4 years old and the original source branch seems to have been removed. Let's close #607 by merging this one or let's close both if it's not going to be

Re: [Github-comments] [geany/geany] Added template file for CSS (#2259)

2019-08-13 Thread elextr
Looks ok. I doubt it will ever get used, but has minimal cost to add. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2259#issuecomment-521036457

[Github-comments] [geany/geany] Added template file for CSS (#2259)

2019-08-13 Thread LarsGit223
This PR adds a "new file" template for CSS files. It's meant to be a follow-up/replacement for PR #607. Following the discussion there the template includes the ```{fileheader}``` token and only minimal CSS content without much placeholders bloating up the file. IMHO we cannot predict much