@codebrainz You're welcome, thanks for the help :)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2697#issuecomment-751859461
@etkaar thanks, and sorry about all the confusion.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2697#issuecomment-751856162
Merged #2697 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2697#event-4153008432
I was a bit struggling, sorry for any inconvinience, but I think now the
correct commit is used for this PL now. @codebrainz I have used your patch, it
seems to work as intended after compiling and testing.
--
You are receiving this because you are subscribed to this thread.
Reply to this
Reopened #2697.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2697#event-4152365533
Closed #2697.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2697#event-4152334810
@etkaar pushed 0 commits.
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/geany/geany/pull/2697/files/6185afa4241d9861394af82fca61c63fcd53c107..d2740f21feb84b6f951398c6f683674b2b56bfed
@etkaar pushed 1 commit.
6185afa4241d9861394af82fca61c63fcd53c107 Update search phrase for
search/replace dialogs always with selected text on dialog reopening
(especially when using shortcuts).
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
@codebrainz Perfect, then I will do that. I am not so familiar with all of
that, but it makes fun! Thanks for your help.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@etkaar since this is already a duplicate of #2565, why not just force push to
the branch of this PR? This topic already has a number of duplicate issues and
PRs, no need to make more, IMO.
You can still keep this current work in a branch on your Github fork, Git lets
you branch off of
@elextr @kugel- Thanks a lot for your votes, then we will go with **3**.
@elextr However, I feel it would make more sense for me to create a new branch
(and so a new PL) for that, since it is more a fix than a feature and so the
original changes would be kept. Would that be okay?
--
You are
I vote for 3 as well
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2697#issuecomment-751633539
Lets examine the use-case, currently all `f` does when the dialog is
open, is it focuses the search pattern entry and selects its contents, it
doesn't do any actions like next or prev. To get next or previous with the
current pattern there are specific shortcuts (default bindings `g` and
How should we proceed here?
1. Not changing default behaviour, but adding the hidden preference with
default FALSE (= **this PR**).
2. Changing default behaviour by adding the hidden preference with default TRUE
(= only a _slight_ change on this PR).
3. Changing default behaviour without adding
> Perhaps I'm missing the use case for not wanting the search text to be
> updated.
Well, I also personally don't see a use case for it, but on the other side, I
don't see that many users complained. Also there must be a reason why the
search phrase is (seems intentionally?) not updated in the
> If I understand your patch correct, it would change the default behaviour to
> do exactly that what my PL does, but per default and without a hidden
> preference.
Correct.
> ...but I think a hidden preference may be better than changing the default
> behaviour without allowing users to fall
@codebrainz Correct, intention is **1**. I closed the old PR because of the
branch issue **and** because I changed the PL to also apply to _Search > Find
in Files_.
If I understand your patch correct, it would change the default behaviour to do
exactly that what my PL does, but per default and
I thought due to [this
comment](https://github.com/geany/geany/pull/2695#issuecomment-748722240) the
request for an option was dropped? I think all this started over not closing
#2693 as a duplicate of #758 and not reading the discussion there.
Key points (duplicated across issues):
1) The
See issue #2693.
Adds hidden preference always_set_from_selected (editable in the
various preferences) which always updates the search phrase in search dialogs
with selected text after reopening the dialog (esp. using shortcuts), since
default behaviour is to insert selected text as search
19 matches
Mail list logo
