Cool :).
A couple of notes:
- I do not believe "-M" makes "." match line breaks. My recent test confirms
this, unless I'm going crazy.
- If we're passing in lots of filenames in recursive mode isn't that going to
hit some kind of parameter string limit?
--
You are receiving this because you
> Without the recursive option, Geany actually passes the filenames to grep
> itself. That can be sorted
It actually is sorted already, so just the recursive option sorting needs
implementing (which is currently handled by grep).
--
You are receiving this because you are subscribed to this
Implementation in #2364.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2322#issuecomment-543273654
I'm now working on this, starting from your commits. I think -M shouldn't be
the only regex option for pcre, because sometimes you don't want `.` to match
EOL. The -M option could be manually enabled in the Extra Options field
(perhaps we could have 2 or 3 of these fields, each with checkboxes
Thanks.
To clarify, I don't consider the difference in `include` syntax a problem.
After my patch, everything works, it's just the user has to type in different
syntax. I think it works great, I like the additional control you get with
/s/globs/regexps.
--
You are receiving this because you
> It almost works, but I had to tweak the code:
Ok, thanks. Looks good, I didn't realize pcregrep doesn't have an -E option.
> The only other remark is the exclude-dir and exclude and include syntax works
> via regexps not globbing
Hmm, it's frustrating that they repurposed those options,
> I think you could already set pcregrep as the grep tool in Preferences. Then
> in the other options entry [of find in files] you can add any necessary flags
> for multi-line matching.
Thanks, I wasn't aware of the option. It almost works, but I had to tweak the
code:
> to implement the search in Geany and do away with grep
That would basically have to reimplement grep. People can pass custom options.
I don't think this is an effective use of time.
> (which isn't available on windows by default,
I think it's bundled with the installer.
> and isn't
I think you could already set pcregrep as the grep tool in preferences. Then
in the other options entry you can add any necessary flags for multi-line
matching.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Glib contains regexen support and directory reading and file reading, so it
would be a mere matter of programming to implement the search in Geany and do
away with grep (which isn't available on windows by default, and isn't
neccessarily GNU grep on BSDs etc.).
Just "somebody" has to do it :)
It would be very useful to be able to search across multiple lines in "Find in
Files". This doesn't work using patterns (\n) or by pasting in the line break
character.
I realize this is all because `grep` doesn't really support multi-line
searches, and it would not be difficult to implement
11 matches
Mail list logo
