Re: [Github-comments] [geany/geany] Search for selected text when pressing [Ctrl]+[F] (#2693)

2020-12-28 Thread Matthew Brush
Closed #2693 via #2697. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2693#event-4153008436

Re: [Github-comments] [geany/geany] Search for selected text when pressing [Ctrl]+[F] (#2693)

2020-12-21 Thread elextr
Reopened #2693. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2693#event-4135102103

Re: [Github-comments] [geany/geany] Search for selected text when pressing [Ctrl]+[F] (#2693)

2020-12-21 Thread elextr
Don't close until the PR is merged, see [github docs](https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword) for how to make it happen automatically when the merge happens. --

Re: [Github-comments] [geany/geany] Search for selected text when pressing [Ctrl]+[F] (#2693)

2020-12-21 Thread Edgar
Closed because of pending Pull Request: #2697 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2693#issuecomment-748866968

Re: [Github-comments] [geany/geany] Search for selected text when pressing [Ctrl]+[F] (#2693)

2020-12-21 Thread Edgar
Closed #2693. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2693#event-4135081562

Re: [Github-comments] [geany/geany] Search for selected text when pressing [Ctrl]+[F] (#2693)

2020-12-20 Thread Edgar
I created a pull request now, see #2695. Is it okay if I do another PL for the manual later? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2693#issuecomment-748676763

Re: [Github-comments] [geany/geany] Search for selected text when pressing [Ctrl]+[F] (#2693)

2020-12-18 Thread elextr
> Since the feature is already implemented I think it should be a little bit > easier to just add an option such like "Always search for selected text". Well, thats the whole point of the lng discussion on #758, changing the search string every time something is selected limits what editing

Re: [Github-comments] [geany/geany] Search for selected text when pressing [Ctrl]+[F] (#2693)

2020-12-18 Thread Edgar
I noticed that the default behaviour of Geany is to put the selected text into the "Search for:" as long the search dialog is not opened. If you open it using [Ctrl]+[F] or via the menu does not matter. Since the feature is already implemented I think it should be a little bit easier to just

Re: [Github-comments] [geany/geany] Search for selected text when pressing [Ctrl]+[F] (#2693)

2020-12-17 Thread elextr
Duplicate of #758 (or at least one of the suggestions, its a big and confusing discussion) but nobody has made a PR. Although its a duplicate perhaps better to leave this open due to the complexity (and age) of #758. -- You are receiving this because you are subscribed to this thread. Reply

[Github-comments] [geany/geany] Search for selected text when pressing [Ctrl]+[F] (#2693)

2020-12-17 Thread Edgar
It would be nice if the selected text would be inserted into the "Search for:" input when pressing [Ctrl]+[F]. I know this behaviour from Notepad++ and it is very helpful. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: