Re: [Github-comments] [geany/geany] false continuation of comment following " \ " (#2715)

2021-09-23 Thread elextr
Well, the shell lexer maintainer in Scintilla noted they were busy and inviting submissions to fix it, so its up to "somebody" to do it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany] false continuation of comment following " \ " (#2715)

2021-09-23 Thread cousteau
I just wanted to add that as far as I know this is standard behavior. It is consistent in bash, dash (the closest thing to a POSIX shell I've seen), zsh, and even the heavily nonstandard csh. It seems to be quite extended too, to the point that some scripts rely on that behavior. For

Re: [Github-comments] [geany/geany] false continuation of comment following " \ " (#2715)

2020-12-30 Thread RayAndrews56
Pardon, I don't know the ropes. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2715#issuecomment-752801313

Re: [Github-comments] [geany/geany] false continuation of comment following " \ " (#2715)

2020-12-30 Thread elextr
Please don't copy everything from the Scintilla bug to here, @codebrainz posted a link to it above. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2715#issuecomment-752800969

Re: [Github-comments] [geany/geany] false continuation of comment following " \ " (#2715)

2020-12-30 Thread RayAndrews56
This is easier to read: https://sourceforge.net/p/scintilla/bugs/2226/ -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2715#issuecomment-752800511

Re: [Github-comments] [geany/geany] false continuation of comment following " \ " (#2715)

2020-12-30 Thread RayAndrews56
A certain Neil Hodgson seems to have looked at this but I have no idea what he's saying: - Description has changed: Diff: --- old +++ new @@ -1,4 +1,4 @@ -~~~ +~~~zsh function test2 { - **Comment**: A simpler example is: ~~~bash # comment \ echo "not a comment" ~~~ which

Re: [Github-comments] [geany/geany] false continuation of comment following " \ " (#2715)

2020-12-30 Thread RayAndrews56
It's debatable and I think you can make a case either way. If you think of it as commenting out a logical line, then of course the wrapped logical line should be commented, but if you think of it as a physical line then only the physical line should be commented. Consider this: ``` [ "$int" =

Re: [Github-comments] [geany/geany] false continuation of comment following " \ " (#2715)

2020-12-30 Thread elextr
If you commented out a line of code that ended in a backslash it would be a continuation onto the next line, so unless half a line makes sense you would actually want the comment to apply to both, so the _shells_ are dumb. Of course if _I_ was the Scintilla maintainer I would just say "Don't do

Re: [Github-comments] [geany/geany] false continuation of comment following " \ " (#2715)

2020-12-30 Thread RayAndrews56
Is there a posix compliant 'shell' we can try? As above, bash and sh flunk out the same way. If there's no other shell that passes this test then they should change it. And if you think about it a comment is a comment ... there is no active code in a comment line so parsing the backslash is

Re: [Github-comments] [geany/geany] false continuation of comment following " \ " (#2715)

2020-12-29 Thread elextr
But reading the [POSIX spec](https://pubs.opengroup.org/onlinepubs/007904875/utilities/xcu_chap02.html) suggests the `\` should be removed before token recognition which is when the comment is recognised, so the highlighting is correct for POSIX shells. `` Since there is only one highlighter

Re: [Github-comments] [geany/geany] false continuation of comment following " \ " (#2715)

2020-12-29 Thread elextr
Well, bash is "wrong" too then ```bash #comment\ echo foo ``` echos foo. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2715#issuecomment-752297462

Re: [Github-comments] [geany/geany] false continuation of comment following " \ " (#2715)

2020-12-29 Thread Matthew Brush
Link: https://sourceforge.net/p/scintilla/bugs/2226/ I'm not saying Zsh has it "wrong" per se, just that it seems to be the correct behaviour for POSIX shells, and that in Geany, `*.zsh` files use the regular [Shell

Re: [Github-comments] [geany/geany] false continuation of comment following " \ " (#2715)

2020-12-29 Thread RayAndrews56
Ok I reported it to Scintilla but I have no idea how to link it back to here. Sorry, I'm not very familiar with any of this. Your quote would seem to suggest that zsh has it wrong tho. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view

Re: [Github-comments] [geany/geany] false continuation of comment following " \ " (#2715)

2020-12-29 Thread Matthew Brush
@RayAndrews56, @elextr is hoping you will open a bug on [the Scintilla bug tracker](https://sourceforge.net/p/scintilla/bugs/) (there might already be one for this, worth searching first), the project where the actual bug you're experiencing would come from. If you're willing to do that, he's

Re: [Github-comments] [geany/geany] false continuation of comment following " \ " (#2715)

2020-12-29 Thread RayAndrews56
Sorry, how do I post a link? Did you just do that with your "added the scintilla label" post above? If so, then am I done? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany] false continuation of comment following " \ " (#2715)

2020-12-29 Thread elextr
Highlighting is done by the editing component which comes from the [Scintilla](scintilla.org) project. We ask that Scintilla lexer bugs be reported directly to that project so there is not another communication step if there are questions. As Geany uses a slightly older version of Scintilla

[Github-comments] [geany/geany] false continuation of comment following " \ " (#2715)

2020-12-29 Thread RayAndrews56
This code: # some comment\ some more comment NOT! ... highlights as if the second line was comment, but zsh at least treats it as code. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: